[{"id":15578,"web_url":"https://patchwork.libcamera.org/comment/15578/","msgid":"","date":"2021-03-09T22:21:36","subject":"Re: [libcamera-devel] [PATCH v3 1/3] libcamera: media_device: add\n\thwRevision method","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Dafna,\n\nThank you for the patch.\n\nOn Tue, Mar 09, 2021 at 07:38:27AM +0100, Dafna Hirschfeld wrote:\n> Add a method 'hwRevision' to return the\n> info.hw_version reported by the driver.\n> \n> Signed-off-by: Dafna Hirschfeld \n> Reviewed-by: Paul Elder \n> ---\n> include/libcamera/internal/media_device.h | 2 ++\n> src/libcamera/media_device.cpp | 10 ++++++++++\n> 2 files changed, 12 insertions(+)\n> \n> diff --git a/include/libcamera/internal/media_device.h b/include/libcamera/internal/media_device.h\n> index d0459cde..c3292508 100644\n> --- a/include/libcamera/internal/media_device.h\n> +++ b/include/libcamera/internal/media_device.h\n> @@ -41,6 +41,7 @@ public:\n> \tconst std::string deviceNode() const { return deviceNode_; }\n> \tconst std::string model() const { return model_; }\n> \tunsigned int version() const { return version_; }\n> +\tunsigned int hwRevision() const { return hwRevision_; }\n> \n> \tconst std::vector &entities() const { return entities_; }\n> \tMediaEntity *getEntityByName(const std::string &name) const;\n> @@ -79,6 +80,7 @@ private:\n> \tstd::string deviceNode_;\n> \tstd::string model_;\n> \tunsigned int version_;\n> +\tunsigned int hwRevision_;\n> \n> \tint fd_;\n> \tbool valid_;\n> diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\n> index 8987de12..3c8ccd81 100644\n> --- a/src/libcamera/media_device.cpp\n> +++ b/src/libcamera/media_device.cpp\n> @@ -231,6 +231,7 @@ int MediaDevice::populate()\n> \tdriver_ = info.driver;\n> \tmodel_ = info.model;\n> \tversion_ = info.media_version;\n> +\thwRevision_ = info.hw_revision;\n> \n> \t/*\n> \t * Keep calling G_TOPOLOGY until the version number stays stable.\n> @@ -323,6 +324,15 @@ done:\n> * \\return The MediaDevice API version\n> */\n> \n> +/**\n> + * \\fn MediaDevice::hwRevision()\n> + * \\brief Retrieve the media device hardware revision\n> + *\n> + * The hardware revision is in a driver-specific format.\n> + *\n> + * \\return The MediaDevice API hardware revision\n\nI'd drop 'API' here as it's the hardware revision, not an API revision.\nOther than that,\n\nReviewed-by: Laurent Pinchart \n\n> + */\n> +\n> /**\n> * \\fn MediaDevice::entities()\n> * \\brief Retrieve the list of entities in the media graph","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 43236BD1F1\n\tfor ;\n\tTue, 9 Mar 2021 22:22:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B008568A9C;\n\tTue, 9 Mar 2021 23:22:11 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5EE6468A99\n\tfor ;\n\tTue, 9 Mar 2021 23:22:09 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A4B5AE9;\n\tTue, 9 Mar 2021 23:22:08 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JtVMDqy/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615328528;\n\tbh=F6JvZs8D0sdMlOKIjnM9RQmi1/4fvEblsq1QPnBIemo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=JtVMDqy/dL3IL6A/qv+fqrjQqSj6kKywigv8Xz4yIxXPTUuK057GwAXaN2Bruffq0\n\tkH9J/l/pXE4xPu7SAgPeeZgkphl1wQ9JDv0owzsIRlzYnQNNPXHSN6gS+cLVEXXcoC\n\tv7Bbo+cYnQo8ObuTOsJghO4B6EjZvN1njmRko4uA=","Date":"Wed, 10 Mar 2021 00:21:36 +0200","From":"Laurent Pinchart ","To":"Dafna Hirschfeld ","Message-ID":"","References":"<20210309063829.8710-1-dafna.hirschfeld@collabora.com>\n\t<20210309063829.8710-2-dafna.hirschfeld@collabora.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210309063829.8710-2-dafna.hirschfeld@collabora.com>","Subject":"Re: [libcamera-devel] [PATCH v3 1/3] libcamera: media_device: add\n\thwRevision method","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org, kernel@collabora.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]