[{"id":15545,"web_url":"https://patchwork.libcamera.org/comment/15545/","msgid":"","date":"2021-03-08T23:58:59","subject":"Re: [libcamera-devel] [PATCH 1/3] android: camera_device: Refuse\n\tunsupported templates","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Mon, Mar 08, 2021 at 06:07:26PM +0100, Jacopo Mondi wrote:\n> The current implementation of constructDefaultRequestSettings()\n> returns the same capture template for all the capture intent.\n> \n> As the correctness of the generated template is verified by CTS it\n> is better to return an error for unsupported capture use cases.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_device.cpp | 7 ++-----\n> 1 file changed, 2 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 6a10b09938fa..c72e0c73eb5e 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1495,14 +1495,11 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n> \tcase CAMERA3_TEMPLATE_VIDEO_SNAPSHOT:\n> \t\tcaptureIntent = ANDROID_CONTROL_CAPTURE_INTENT_VIDEO_SNAPSHOT;\n> \t\tbreak;\n> +\t/* \\todo Implement templates generation for the remaining use cases. */\n> \tcase CAMERA3_TEMPLATE_ZERO_SHUTTER_LAG:\n> -\t\tcaptureIntent = ANDROID_CONTROL_CAPTURE_INTENT_ZERO_SHUTTER_LAG;\n> -\t\tbreak;\n> \tcase CAMERA3_TEMPLATE_MANUAL:\n> -\t\tcaptureIntent = ANDROID_CONTROL_CAPTURE_INTENT_MANUAL;\n> -\t\tbreak;\n> \tdefault:\n> -\t\tLOG(HAL, Error) << \"Invalid template request type: \" << type;\n> +\t\tLOG(HAL, Error) << \"Unsupported template request type: \" << type;\n> \t\treturn nullptr;\n> \t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3027BBD80C\n\tfor ;\n\tMon, 8 Mar 2021 23:59:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A844F68A9C;\n\tTue, 9 Mar 2021 00:59:32 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A81DA602E4\n\tfor ;\n\tTue, 9 Mar 2021 00:59:31 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 13E7E99;\n\tTue, 9 Mar 2021 00:59:31 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TJ1bKxkP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615247971;\n\tbh=9eM+IWLdmht3lWtWV8n0aweokaz2A/+kUBl7DYF1oB0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=TJ1bKxkPPcjCAOb8ez6nsysP/QzxoOQ6WnT7hF3bjesXUOwmN00gmMr6bIFSRMVoh\n\tsBn7YMXx+zHp77Zhn+XrGZd7MHnDc1UKtMbNeAl2Qet2Ieq9f8dd4M8/llaYLjMS96\n\t0JT40kCW3jEmY2pvE19PnI7Y55qf6o3l+qqPSa3E=","Date":"Tue, 9 Mar 2021 01:58:59 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210308170728.2212649-1-jacopo@jmondi.org>\n\t<20210308170728.2212649-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210308170728.2212649-2-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 1/3] android: camera_device: Refuse\n\tunsupported templates","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]