[{"id":15502,"web_url":"https://patchwork.libcamera.org/comment/15502/","msgid":"<84ccadd3-b32a-7fe9-a4ed-ccfae934a98c@ideasonboard.com>","date":"2021-03-08T10:26:56","subject":"Re: [libcamera-devel] [PATCH 4/4] android: jpeg: exif: change GPS\n\tmethod from UNDEFINED format to ASCII","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Paul,\n\nOn 08/03/2021 10:13, Paul Elder wrote:\n> According to the EXIF specification, the GPS method should be UNDEFINED,\n> and the first 8 bytes will designate the type. However, CTS expects the\n> GPS method to be ASCII. Change the format to ASCII to appease CTS.\n\nIf the Spec says it should be UNDEFINED, doesn't that mean that the CTS\nis wrong? (and should be fixed there?)\n\n> This is part of the fix that allows the following CTS test to pass:\n> - android.hardware.cts.CameraTest#testJpegExif\n> \n> Signed-off-by: Paul Elder \n> ---\n> src/android/jpeg/exif.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/android/jpeg/exif.cpp b/src/android/jpeg/exif.cpp\n> index 5225d17f..83e6faba 100644\n> --- a/src/android/jpeg/exif.cpp\n> +++ b/src/android/jpeg/exif.cpp\n> @@ -404,7 +404,7 @@ void Exif::setGPSLocation(const double *coords)\n> void Exif::setGPSMethod(const std::string &method)\n> {\n> \tsetString(EXIF_IFD_GPS, static_cast(EXIF_TAG_GPS_PROCESSING_METHOD),\n> -\t\t EXIF_FORMAT_UNDEFINED, method, Unicode);\n> +\t\t EXIF_FORMAT_ASCII, method);\n> }\n> \n> void Exif::setOrientation(int orientation)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C8C0ABD80C\n\tfor ;\n\tMon, 8 Mar 2021 10:27:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 20A8B68A9A;\n\tMon, 8 Mar 2021 11:27:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3A587602E6\n\tfor ;\n\tMon, 8 Mar 2021 11:26:59 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9C3EA8A3;\n\tMon, 8 Mar 2021 11:26:58 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rqkRklu/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615199218;\n\tbh=1+nUUm0T6GkDcrs+MN27TituZRS2adlE/bJZqCbUg2o=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=rqkRklu/Td9JHq28Qk7y0URKKrjpirfBxDh2J4KS39+23SzsqcWptlqz7Og2UADDd\n\t1QV03tdNDrhk04xv1BZrUfZrFCxBizh5cOvsljtz413Ysx5mBpbzvcS91RiGifmhpk\n\tN6gaUnp3tO8X1XRwr/lDZj6XVroEox7ayHPC1DCc=","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210308101356.59333-1-paul.elder@ideasonboard.com>\n\t<20210308101356.59333-5-paul.elder@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<84ccadd3-b32a-7fe9-a4ed-ccfae934a98c@ideasonboard.com>","Date":"Mon, 8 Mar 2021 10:26:56 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210308101356.59333-5-paul.elder@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 4/4] android: jpeg: exif: change GPS\n\tmethod from UNDEFINED format to ASCII","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15520,"web_url":"https://patchwork.libcamera.org/comment/15520/","msgid":"","date":"2021-03-08T14:48:45","subject":"Re: [libcamera-devel] [PATCH 4/4] android: jpeg: exif: change GPS\n\tmethod from UNDEFINED format to ASCII","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Mon, Mar 08, 2021 at 10:26:56AM +0000, Kieran Bingham wrote:\n> On 08/03/2021 10:13, Paul Elder wrote:\n> > According to the EXIF specification, the GPS method should be UNDEFINED,\n> > and the first 8 bytes will designate the type. However, CTS expects the\n> > GPS method to be ASCII. Change the format to ASCII to appease CTS.\n> \n> If the Spec says it should be UNDEFINED, doesn't that mean that the CTS\n> is wrong? (and should be fixed there?)\n\nDoes CTS check that the tag type is set to ASCII rather than UNDEFINED,\nor does it fail because it it doesn't expect the 8-bytes encoding prefix\n? In the latter case, we could switch to the NoEncoding encoding and\nkeep the UNDEFINED type.\n\nThe Exif spec is very confusing here, it documents the tag as UNDEFINED,\nbut then shows a few examples where it mentions ASCII. It's not clear if\nASCII refers to the tag type or the encoding here.\n\n> > This is part of the fix that allows the following CTS test to pass:\n> > - android.hardware.cts.CameraTest#testJpegExif\n> > \n> > Signed-off-by: Paul Elder \n> > ---\n> > src/android/jpeg/exif.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/android/jpeg/exif.cpp b/src/android/jpeg/exif.cpp\n> > index 5225d17f..83e6faba 100644\n> > --- a/src/android/jpeg/exif.cpp\n> > +++ b/src/android/jpeg/exif.cpp\n> > @@ -404,7 +404,7 @@ void Exif::setGPSLocation(const double *coords)\n> > void Exif::setGPSMethod(const std::string &method)\n> > {\n> > \tsetString(EXIF_IFD_GPS, static_cast(EXIF_TAG_GPS_PROCESSING_METHOD),\n> > -\t\t EXIF_FORMAT_UNDEFINED, method, Unicode);\n> > +\t\t EXIF_FORMAT_ASCII, method);\n> > }\n> > \n> > void Exif::setOrientation(int orientation)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 98957BD80C\n\tfor ;\n\tMon, 8 Mar 2021 14:49:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1588868A9F;\n\tMon, 8 Mar 2021 15:49:18 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EDF6E60520\n\tfor ;\n\tMon, 8 Mar 2021 15:49:16 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 42A2EAC1;\n\tMon, 8 Mar 2021 15:49:16 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SG5aLVys\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615214956;\n\tbh=7iEYcSWnAtjLJ0DDlIXCvbohZNOcFa7m9fwe2ObZD6c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=SG5aLVysMUF2MvvWCS+46SIfQI/uvF5sWdYWYfPRYTjgw/R0lAygDpq/t8YPsGfSE\n\tOcWj9dtxmGKVa7lRQbmEzuFq2y4gPEtvMeaA4pakwYL8ypzj5FRnqNs3KyTO5U+dBO\n\tAr7VkZYAzLkN8Dr2vXNBHOtuIOPpm2ogqcsDWd7o=","Date":"Mon, 8 Mar 2021 16:48:45 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210308101356.59333-1-paul.elder@ideasonboard.com>\n\t<20210308101356.59333-5-paul.elder@ideasonboard.com>\n\t<84ccadd3-b32a-7fe9-a4ed-ccfae934a98c@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<84ccadd3-b32a-7fe9-a4ed-ccfae934a98c@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 4/4] android: jpeg: exif: change GPS\n\tmethod from UNDEFINED format to ASCII","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]