{"id":11513,"url":"https://patchwork.libcamera.org/api/patches/11513/?format=json","web_url":"https://patchwork.libcamera.org/patch/11513/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210308101356.59333-5-paul.elder@ideasonboard.com>","date":"2021-03-08T10:13:56","name":"[libcamera-devel,4/4] android: jpeg: exif: change GPS method from UNDEFINED format to ASCII","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"fbcca51a69937696703b83efaf32459948a683ec","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11513/mbox/","series":[{"id":1767,"url":"https://patchwork.libcamera.org/api/series/1767/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1767","date":"2021-03-08T10:13:52","name":"android: jpeg: exif: Fix GPS altitude","version":1,"mbox":"https://patchwork.libcamera.org/series/1767/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11513/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11513/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 19796BD1F1\n\tfor ;\n\tMon, 8 Mar 2021 10:14:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CA84068AA8;\n\tMon, 8 Mar 2021 11:14:14 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB48468A99\n\tfor ;\n\tMon, 8 Mar 2021 11:14:13 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6270B8A3;\n\tMon, 8 Mar 2021 11:14:12 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tfnwfDaI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615198453;\n\tbh=/Fx8yyQSgzgGtv+B7QuSN2Qw6K+T90Wo0Sas2I6MEpU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=tfnwfDaI4smfYzks6zj6TMVEN66R+Qzy3YnYzK2CaZNZc5bmVAwMDvdZfoxPX02O9\n\tzh374QSfYFgIdQHK1tuOuTZJaEyGNlkYTAX2S2hx+Pa+xbo7i0ffaSOFMioAZ5Ll6p\n\tqfKwWjnnnlfS1HVe54UADeuLZq9BHtkHotkD5rRQ=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 8 Mar 2021 19:13:56 +0900","Message-Id":"<20210308101356.59333-5-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210308101356.59333-1-paul.elder@ideasonboard.com>","References":"<20210308101356.59333-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 4/4] android: jpeg: exif: change GPS\n\tmethod from UNDEFINED format to ASCII","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"According to the EXIF specification, the GPS method should be UNDEFINED,\nand the first 8 bytes will designate the type. However, CTS expects the\nGPS method to be ASCII. Change the format to ASCII to appease CTS.\n\nThis is part of the fix that allows the following CTS test to pass:\n- android.hardware.cts.CameraTest#testJpegExif\n\nSigned-off-by: Paul Elder \n---\n src/android/jpeg/exif.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/android/jpeg/exif.cpp b/src/android/jpeg/exif.cpp\nindex 5225d17f..83e6faba 100644\n--- a/src/android/jpeg/exif.cpp\n+++ b/src/android/jpeg/exif.cpp\n@@ -404,7 +404,7 @@ void Exif::setGPSLocation(const double *coords)\n void Exif::setGPSMethod(const std::string &method)\n {\n \tsetString(EXIF_IFD_GPS, static_cast(EXIF_TAG_GPS_PROCESSING_METHOD),\n-\t\t EXIF_FORMAT_UNDEFINED, method, Unicode);\n+\t\t EXIF_FORMAT_ASCII, method);\n }\n \n void Exif::setOrientation(int orientation)\n","prefixes":["libcamera-devel","4/4"]}