[{"id":15475,"web_url":"https://patchwork.libcamera.org/comment/15475/","msgid":"","date":"2021-03-04T08:59:46","subject":"Re: [libcamera-devel] [PATCH v1 2/2] DEMO: raspberrypi: Use custom\n\tparameters to init()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Thu, Mar 04, 2021 at 05:47:43PM +0900, Paul Elder wrote:\n> This is just a demo to show custom parameters to init() with the\n> raspberrypi IPA interface.\n> \n> Signed-off-by: Paul Elder \n> ---\n> include/libcamera/ipa/raspberrypi.mojom | 3 ++-\n> src/ipa/raspberrypi/raspberrypi.cpp | 12 +++++++++---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 6 +++++-\n> 3 files changed, 16 insertions(+), 5 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/raspberrypi.mojom b/include/libcamera/ipa/raspberrypi.mojom\n> index f733a2cd..b8944227 100644\n> --- a/include/libcamera/ipa/raspberrypi.mojom\n> +++ b/include/libcamera/ipa/raspberrypi.mojom\n> @@ -51,7 +51,8 @@ struct StartControls {\n> };\n> \n> interface IPARPiInterface {\n> -\tinit(IPASettings settings) => (int32 ret);\n> +\tinit(IPASettings settings, string sensorName)\n> +\t\t=> (int32 ret, bool metadataSupport);\n> \tstart(StartControls controls) => (StartControls result);\n> \tstop();\n> \n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 6348d071..6a9aba6f 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -79,7 +79,8 @@ public:\n> \t\t\tmunmap(lsTable_, ipa::RPi::MaxLsGridSize);\n> \t}\n> \n> -\tint init(const IPASettings &settings) override;\n> +\tvoid init(const IPASettings &settings, const std::string &sensorName,\n> +\t\t int *ret, bool *metadataSupport) override;\n\nWould it make sense to handle the case where the first output parameter\nis an int32 to return it directly from the function ?\n\n\tint init(const IPASettings &settings, const std::string &sensorName,\n\t\t bool *metadataSupport) override;\n\nWould it be doable without too much effort on the IPC generator side ?\n\n> \tvoid start(const ipa::RPi::StartControls &data,\n> \t\t ipa::RPi::StartControls *result) override;\n> \tvoid stop() override {}\n> @@ -164,10 +165,15 @@ private:\n> \tdouble maxFrameDuration_;\n> };\n> \n> -int IPARPi::init(const IPASettings &settings)\n> +void IPARPi::init(const IPASettings &settings, const std::string &sensorName,\n> +\t\t int *ret, bool *metadataSupport)\n> {\n> +\tLOG(IPARPI, Debug) << \"sensor name is \" << sensorName;\n> +\n> \ttuningFile_ = settings.configurationFile;\n> -\treturn 0;\n> +\n> +\t*metadataSupport = true;\n> +\t*ret = 0;\n> }\n> \n> void IPARPi::start(const ipa::RPi::StartControls &data,\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index db91f1b5..a1c90028 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -1194,7 +1194,11 @@ int RPiCameraData::loadIPA()\n> \n> \tIPASettings settings(ipa_->configurationFile(sensor_->model() + \".json\"));\n> \n> -\treturn ipa_->init(settings);\n> +\tint ret;\n> +\tbool metadataSupport;\n> +\tipa_->init(settings, \"sensor name\", &ret, &metadataSupport);\n> +\tLOG(RPI, Debug) << \"metadata support \" << (metadataSupport ? \"yes\" : \"no\");\n> +\treturn ret;\n> }\n> \n> int RPiCameraData::configureIPA(const CameraConfiguration *config)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 86D69BD1F1\n\tfor ;\n\tThu, 4 Mar 2021 09:00:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 462E368A92;\n\tThu, 4 Mar 2021 10:00:18 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9B19368A91\n\tfor ;\n\tThu, 4 Mar 2021 10:00:16 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0BDE527A;\n\tThu, 4 Mar 2021 10:00:15 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"E3Govuop\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614848416;\n\tbh=taV48+VeeCdxMP1ebb5w9Vju9DQf9Q5dmPambG5XXaY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=E3GovuopNXpGx+um+FxLq3iu9F9HzBTEfHr3i/7B5IKVP5Tcj5Y9kzyXD+/BeBjyW\n\tJYiqSoUV+lM17Urb1vObwnxyBAJvoTyT84yyX3iFc0ZWHROgJMxJR9yvzqe4ZPxkaO\n\tSGniVNQTAf5pwA5g3gcLcZgYyEKikOFaYyWXJUiQ=","Date":"Thu, 4 Mar 2021 10:59:46 +0200","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"","References":"<20210304084743.11721-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210304084743.11721-1-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v1 2/2] DEMO: raspberrypi: Use custom\n\tparameters to init()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15476,"web_url":"https://patchwork.libcamera.org/comment/15476/","msgid":"<20210304090255.GE2049@pyrite.rasen.tech>","date":"2021-03-04T09:02:55","subject":"Re: [libcamera-devel] [PATCH v1 2/2] DEMO: raspberrypi: Use custom\n\tparameters to init()","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Thu, Mar 04, 2021 at 10:59:46AM +0200, Laurent Pinchart wrote:\n> Hi Paul,\n> \n> Thank you for the patch.\n> \n> On Thu, Mar 04, 2021 at 05:47:43PM +0900, Paul Elder wrote:\n> > This is just a demo to show custom parameters to init() with the\n> > raspberrypi IPA interface.\n> > \n> > Signed-off-by: Paul Elder \n> > ---\n> > include/libcamera/ipa/raspberrypi.mojom | 3 ++-\n> > src/ipa/raspberrypi/raspberrypi.cpp | 12 +++++++++---\n> > src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 6 +++++-\n> > 3 files changed, 16 insertions(+), 5 deletions(-)\n> > \n> > diff --git a/include/libcamera/ipa/raspberrypi.mojom b/include/libcamera/ipa/raspberrypi.mojom\n> > index f733a2cd..b8944227 100644\n> > --- a/include/libcamera/ipa/raspberrypi.mojom\n> > +++ b/include/libcamera/ipa/raspberrypi.mojom\n> > @@ -51,7 +51,8 @@ struct StartControls {\n> > };\n> > \n> > interface IPARPiInterface {\n> > -\tinit(IPASettings settings) => (int32 ret);\n> > +\tinit(IPASettings settings, string sensorName)\n> > +\t\t=> (int32 ret, bool metadataSupport);\n> > \tstart(StartControls controls) => (StartControls result);\n> > \tstop();\n> > \n> > diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> > index 6348d071..6a9aba6f 100644\n> > --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> > +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> > @@ -79,7 +79,8 @@ public:\n> > \t\t\tmunmap(lsTable_, ipa::RPi::MaxLsGridSize);\n> > \t}\n> > \n> > -\tint init(const IPASettings &settings) override;\n> > +\tvoid init(const IPASettings &settings, const std::string &sensorName,\n> > +\t\t int *ret, bool *metadataSupport) override;\n> \n> Would it make sense to handle the case where the first output parameter\n> is an int32 to return it directly from the function ?\n\ntbh, I think it would...\n\n> \tint init(const IPASettings &settings, const std::string &sensorName,\n> \t\t bool *metadataSupport) override;\n> \n> Would it be doable without too much effort on the IPC generator side ?\n\nWithout \"too much\" effort, sure :)\n\nI'll put it higher up on my todo list.\n\n\nPaul\n\n> > \tvoid start(const ipa::RPi::StartControls &data,\n> > \t\t ipa::RPi::StartControls *result) override;\n> > \tvoid stop() override {}\n> > @@ -164,10 +165,15 @@ private:\n> > \tdouble maxFrameDuration_;\n> > };\n> > \n> > -int IPARPi::init(const IPASettings &settings)\n> > +void IPARPi::init(const IPASettings &settings, const std::string &sensorName,\n> > +\t\t int *ret, bool *metadataSupport)\n> > {\n> > +\tLOG(IPARPI, Debug) << \"sensor name is \" << sensorName;\n> > +\n> > \ttuningFile_ = settings.configurationFile;\n> > -\treturn 0;\n> > +\n> > +\t*metadataSupport = true;\n> > +\t*ret = 0;\n> > }\n> > \n> > void IPARPi::start(const ipa::RPi::StartControls &data,\n> > diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > index db91f1b5..a1c90028 100644\n> > --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > @@ -1194,7 +1194,11 @@ int RPiCameraData::loadIPA()\n> > \n> > \tIPASettings settings(ipa_->configurationFile(sensor_->model() + \".json\"));\n> > \n> > -\treturn ipa_->init(settings);\n> > +\tint ret;\n> > +\tbool metadataSupport;\n> > +\tipa_->init(settings, \"sensor name\", &ret, &metadataSupport);\n> > +\tLOG(RPI, Debug) << \"metadata support \" << (metadataSupport ? \"yes\" : \"no\");\n> > +\treturn ret;\n> > }\n> > \n> > int RPiCameraData::configureIPA(const CameraConfiguration *config)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 68D0BBD80C\n\tfor ;\n\tThu, 4 Mar 2021 09:03:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D1CF068A99;\n\tThu, 4 Mar 2021 10:03:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 37E2168A91\n\tfor ;\n\tThu, 4 Mar 2021 10:03:03 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9F6E227A;\n\tThu, 4 Mar 2021 10:03:01 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"riu+CBle\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614848582;\n\tbh=b5kgyutrN0XjzAWPwrNo4HBLwG2+y+sedSvk2+b+Jio=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=riu+CBle5AQgFJknjzFj1Ed/sZXX8/wcLhcGrlTj91AE6L7H9JnVAFpm/CnmO/kL1\n\thYY9T67b0gnqrq2LCemcMK4ktzKh/yIAZa6Q0+4QFTyJ47SQBC+UaPAlooKZtZpqnJ\n\tjC+BgmbEcLFsp3/ut4tsOodYXleuIIgx1NLEKTAw=","Date":"Thu, 4 Mar 2021 18:02:55 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20210304090255.GE2049@pyrite.rasen.tech>","References":"<20210304084743.11721-1-paul.elder@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v1 2/2] DEMO: raspberrypi: Use custom\n\tparameters to init()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]