[{"id":15470,"web_url":"https://patchwork.libcamera.org/comment/15470/","msgid":"<20210304084821.GB2049@pyrite.rasen.tech>","date":"2021-03-04T08:48:21","subject":"Re: [libcamera-devel] [PATCH v1 1/2] utils: ipc: Support custom\n\tparameters to init()","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Naush,\n\nSorry I forgot to CC you.\n\nPaul\n\nOn Thu, Mar 04, 2021 at 05:47:02PM +0900, Paul Elder wrote:\n> Add support to the mojom-based code generator for custom parameters to\n> init(). Remove the parameter type and count validation as well.\n> \n> Signed-off-by: Paul Elder \n> ---\n> .../libcamera_templates/module_ipa_proxy.cpp.tmpl | 15 ++++++++++++---\n> .../libcamera_templates/proxy_functions.tmpl | 13 -------------\n> utils/ipc/generators/mojom_libcamera_generator.py | 10 +---------\n> 3 files changed, 13 insertions(+), 25 deletions(-)\n> \n> diff --git a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> index 5e0d3976..8ba1a5cf 100644\n> --- a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> +++ b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> @@ -144,10 +144,19 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n> \n> {{proxy_funcs.func_sig(proxy_name, method, \"Thread\")}}\n> {\n> -{%- if method.mojom_name == \"init\" %}\n> -\t{{proxy_funcs.init_thread_body()}}\n> -{%- elif method.mojom_name == \"stop\" %}\n> +{%- if method.mojom_name == \"stop\" %}\n> \t{{proxy_funcs.stop_thread_body()}}\n> +{%- elif method.mojom_name == \"init\" %}\n> +\t{{ method|method_return_value + \" _ret = \" if method|method_return_value != \"void\" -}}\n> +\tipa_->{{method.mojom_name}}(\n> +\t{%- for param in method|method_param_names -%}\n> +\t\t{{param}}{{- \", \" if not loop.last}}\n> +\t{%- endfor -%}\n> +);\n> +\n> +\tproxy_.moveToThread(&thread_);\n> +\n> +\treturn {{ \"_ret\" if method|method_return_value != \"void\" }};\n> {%- elif method.mojom_name == \"start\" %}\n> \trunning_ = true;\n> \tthread_.start();\n> diff --git a/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl b/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n> index 40611feb..f2d86b67 100644\n> --- a/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n> +++ b/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n> @@ -19,19 +19,6 @@\n> ){{\" override\" if override}}\n> {%- endmacro -%}\n> \n> -{#\n> - # \\brief Generate function body for IPA init() function for thread\n> - #}\n> -{%- macro init_thread_body() -%}\n> -\tint ret = ipa_->init(settings);\n> -\tif (ret)\n> -\t\treturn ret;\n> -\n> -\tproxy_.moveToThread(&thread_);\n> -\n> -\treturn 0;\n> -{%- endmacro -%}\n> -\n> {#\n> # \\brief Generate function body for IPA stop() function for thread\n> #}\n> diff --git a/utils/ipc/generators/mojom_libcamera_generator.py b/utils/ipc/generators/mojom_libcamera_generator.py\n> index 438e41c6..af123ef2 100644\n> --- a/utils/ipc/generators/mojom_libcamera_generator.py\n> +++ b/utils/ipc/generators/mojom_libcamera_generator.py\n> @@ -345,15 +345,7 @@ def ValidateInterfaces(interfaces):\n> f_start = f_start[0]\n> f_stop = f_stop[0]\n> \n> - # Validate parameters to init()\n> - ValidateSingleLength(f_init.parameters, 'input parameter to init()')\n> - ValidateSingleLength(f_init.response_parameters, 'output parameter from init()')\n> - if f_init.parameters[0].kind.mojom_name != 'IPASettings':\n> - raise Exception('init() must have single IPASettings input parameter')\n> - if f_init.response_parameters[0].kind.spec != 'i32':\n> - raise Exception('init() must have single int32 output parameter')\n> -\n> - # No need to validate start() as it is customizable\n> + # No need to validate init() and start() as they are customizable\n> \n> # Validate parameters to stop()\n> ValidateZeroLength(f_stop.parameters, 'input parameter to stop()')\n> -- \n> 2.27.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 286C0BD80C\n\tfor ;\n\tThu, 4 Mar 2021 08:48:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CFAB8602EC;\n\tThu, 4 Mar 2021 09:48:29 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DEF14602EC\n\tfor ;\n\tThu, 4 Mar 2021 09:48:27 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 97CFE6F3;\n\tThu, 4 Mar 2021 09:48:26 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZEuMDaIY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614847707;\n\tbh=iE3BUb9npw2PwF9hcOJ6ANzmYwAhjGh4VEdvUqVu/1k=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZEuMDaIYud3+x78CsadPV/ECiDaOYitZKvbV4knsxN4Nz2MZf4cE4+Ubk9rLYG9W3\n\tahkm+z6dTzd000+DFgpK8lu1YScWNOyos+4c8s0qGjC+5vWjWBMfaLojcVPV/vPQKk\n\tKJUP+Kk6tpc25FKtbd83XpbBpEgbYt4ocp+vUA7c=","Date":"Thu, 4 Mar 2021 17:48:21 +0900","From":"paul.elder@ideasonboard.com","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20210304084821.GB2049@pyrite.rasen.tech>","References":"<20210304084703.11542-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210304084703.11542-1-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v1 1/2] utils: ipc: Support custom\n\tparameters to init()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15473,"web_url":"https://patchwork.libcamera.org/comment/15473/","msgid":"","date":"2021-03-04T08:56:47","subject":"Re: [libcamera-devel] [PATCH v1 1/2] utils: ipc: Support custom\n\tparameters to init()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Thu, Mar 04, 2021 at 05:47:02PM +0900, Paul Elder wrote:\n> Add support to the mojom-based code generator for custom parameters to\n> init(). Remove the parameter type and count validation as well.\n> \n> Signed-off-by: Paul Elder \n> ---\n> .../libcamera_templates/module_ipa_proxy.cpp.tmpl | 15 ++++++++++++---\n> .../libcamera_templates/proxy_functions.tmpl | 13 -------------\n> utils/ipc/generators/mojom_libcamera_generator.py | 10 +---------\n> 3 files changed, 13 insertions(+), 25 deletions(-)\n> \n> diff --git a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> index 5e0d3976..8ba1a5cf 100644\n> --- a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> +++ b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> @@ -144,10 +144,19 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n> \n> {{proxy_funcs.func_sig(proxy_name, method, \"Thread\")}}\n> {\n> -{%- if method.mojom_name == \"init\" %}\n> -\t{{proxy_funcs.init_thread_body()}}\n> -{%- elif method.mojom_name == \"stop\" %}\n> +{%- if method.mojom_name == \"stop\" %}\n> \t{{proxy_funcs.stop_thread_body()}}\n> +{%- elif method.mojom_name == \"init\" %}\n> +\t{{ method|method_return_value + \" _ret = \" if method|method_return_value != \"void\" -}}\n> +\tipa_->{{method.mojom_name}}(\n> +\t{%- for param in method|method_param_names -%}\n> +\t\t{{param}}{{- \", \" if not loop.last}}\n> +\t{%- endfor -%}\n> +);\n> +\n> +\tproxy_.moveToThread(&thread_);\n> +\n> +\treturn {{ \"_ret\" if method|method_return_value != \"void\" }};\n> {%- elif method.mojom_name == \"start\" %}\n> \trunning_ = true;\n> \tthread_.start();\n> diff --git a/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl b/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n> index 40611feb..f2d86b67 100644\n> --- a/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n> +++ b/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n> @@ -19,19 +19,6 @@\n> ){{\" override\" if override}}\n> {%- endmacro -%}\n> \n> -{#\n> - # \\brief Generate function body for IPA init() function for thread\n> - #}\n> -{%- macro init_thread_body() -%}\n> -\tint ret = ipa_->init(settings);\n> -\tif (ret)\n> -\t\treturn ret;\n> -\n> -\tproxy_.moveToThread(&thread_);\n> -\n> -\treturn 0;\n> -{%- endmacro -%}\n> -\n> {#\n> # \\brief Generate function body for IPA stop() function for thread\n> #}\n> diff --git a/utils/ipc/generators/mojom_libcamera_generator.py b/utils/ipc/generators/mojom_libcamera_generator.py\n> index 438e41c6..af123ef2 100644\n> --- a/utils/ipc/generators/mojom_libcamera_generator.py\n> +++ b/utils/ipc/generators/mojom_libcamera_generator.py\n> @@ -345,15 +345,7 @@ def ValidateInterfaces(interfaces):\n\nShould you drop f_init from right above ?\n\nReviewed-by: Laurent Pinchart \n\n> f_start = f_start[0]\n> f_stop = f_stop[0]\n> \n> - # Validate parameters to init()\n> - ValidateSingleLength(f_init.parameters, 'input parameter to init()')\n> - ValidateSingleLength(f_init.response_parameters, 'output parameter from init()')\n> - if f_init.parameters[0].kind.mojom_name != 'IPASettings':\n> - raise Exception('init() must have single IPASettings input parameter')\n> - if f_init.response_parameters[0].kind.spec != 'i32':\n> - raise Exception('init() must have single int32 output parameter')\n> -\n> - # No need to validate start() as it is customizable\n> + # No need to validate init() and start() as they are customizable\n> \n> # Validate parameters to stop()\n> ValidateZeroLength(f_stop.parameters, 'input parameter to stop()')","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 63119BD1F1\n\tfor ;\n\tThu, 4 Mar 2021 08:57:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1D84668A98;\n\tThu, 4 Mar 2021 09:57:20 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8CE3E602EC\n\tfor ;\n\tThu, 4 Mar 2021 09:57:18 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2960827A;\n\tThu, 4 Mar 2021 09:57:17 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JxyEc5Ew\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614848237;\n\tbh=gw6kQTI2rehUvBytfAe6iAaO2qraa/DeZK3UW4n+uWk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=JxyEc5EwsE5VXU7TcXsPpiZLU7RwIRBJrJOyOTrdpGx+Ys/XlVO00bFksB2KL1lEB\n\tXXRTd76IuR+QLpCjXPSPnQFYe/1jWSqtM+Q+jQecXnzFS5gWbgdsPCfH6zkJ5Yb7HA\n\td966NT3c1O5/qPhzeZaS+WYehfdU353XQmX9xu5w=","Date":"Thu, 4 Mar 2021 10:56:47 +0200","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"","References":"<20210304084703.11542-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210304084703.11542-1-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v1 1/2] utils: ipc: Support custom\n\tparameters to init()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15474,"web_url":"https://patchwork.libcamera.org/comment/15474/","msgid":"<20210304085916.GD2049@pyrite.rasen.tech>","date":"2021-03-04T08:59:16","subject":"Re: [libcamera-devel] [PATCH v1 1/2] utils: ipc: Support custom\n\tparameters to init()","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Thu, Mar 04, 2021 at 10:56:47AM +0200, Laurent Pinchart wrote:\n> Hi Paul,\n> \n> Thank you for the patch.\n> \n> On Thu, Mar 04, 2021 at 05:47:02PM +0900, Paul Elder wrote:\n> > Add support to the mojom-based code generator for custom parameters to\n> > init(). Remove the parameter type and count validation as well.\n> > \n> > Signed-off-by: Paul Elder \n> > ---\n> > .../libcamera_templates/module_ipa_proxy.cpp.tmpl | 15 ++++++++++++---\n> > .../libcamera_templates/proxy_functions.tmpl | 13 -------------\n> > utils/ipc/generators/mojom_libcamera_generator.py | 10 +---------\n> > 3 files changed, 13 insertions(+), 25 deletions(-)\n> > \n> > diff --git a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> > index 5e0d3976..8ba1a5cf 100644\n> > --- a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> > +++ b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> > @@ -144,10 +144,19 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n> > \n> > {{proxy_funcs.func_sig(proxy_name, method, \"Thread\")}}\n> > {\n> > -{%- if method.mojom_name == \"init\" %}\n> > -\t{{proxy_funcs.init_thread_body()}}\n> > -{%- elif method.mojom_name == \"stop\" %}\n> > +{%- if method.mojom_name == \"stop\" %}\n> > \t{{proxy_funcs.stop_thread_body()}}\n> > +{%- elif method.mojom_name == \"init\" %}\n> > +\t{{ method|method_return_value + \" _ret = \" if method|method_return_value != \"void\" -}}\n> > +\tipa_->{{method.mojom_name}}(\n> > +\t{%- for param in method|method_param_names -%}\n> > +\t\t{{param}}{{- \", \" if not loop.last}}\n> > +\t{%- endfor -%}\n> > +);\n> > +\n> > +\tproxy_.moveToThread(&thread_);\n> > +\n> > +\treturn {{ \"_ret\" if method|method_return_value != \"void\" }};\n> > {%- elif method.mojom_name == \"start\" %}\n> > \trunning_ = true;\n> > \tthread_.start();\n> > diff --git a/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl b/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n> > index 40611feb..f2d86b67 100644\n> > --- a/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n> > +++ b/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n> > @@ -19,19 +19,6 @@\n> > ){{\" override\" if override}}\n> > {%- endmacro -%}\n> > \n> > -{#\n> > - # \\brief Generate function body for IPA init() function for thread\n> > - #}\n> > -{%- macro init_thread_body() -%}\n> > -\tint ret = ipa_->init(settings);\n> > -\tif (ret)\n> > -\t\treturn ret;\n> > -\n> > -\tproxy_.moveToThread(&thread_);\n> > -\n> > -\treturn 0;\n> > -{%- endmacro -%}\n> > -\n> > {#\n> > # \\brief Generate function body for IPA stop() function for thread\n> > #}\n> > diff --git a/utils/ipc/generators/mojom_libcamera_generator.py b/utils/ipc/generators/mojom_libcamera_generator.py\n> > index 438e41c6..af123ef2 100644\n> > --- a/utils/ipc/generators/mojom_libcamera_generator.py\n> > +++ b/utils/ipc/generators/mojom_libcamera_generator.py\n> > @@ -345,15 +345,7 @@ def ValidateInterfaces(interfaces):\n> \n> Should you drop f_init from right above ?\n\nOh yes you're right, both f_init and f_start should be removed. We need\nthe earlier one to validate presence, but not the reassignment.\n\n> Reviewed-by: Laurent Pinchart \n\n\nThanks,\n\nPaul\n\n> \n> > f_start = f_start[0]\n> > f_stop = f_stop[0]\n> > \n> > - # Validate parameters to init()\n> > - ValidateSingleLength(f_init.parameters, 'input parameter to init()')\n> > - ValidateSingleLength(f_init.response_parameters, 'output parameter from init()')\n> > - if f_init.parameters[0].kind.mojom_name != 'IPASettings':\n> > - raise Exception('init() must have single IPASettings input parameter')\n> > - if f_init.response_parameters[0].kind.spec != 'i32':\n> > - raise Exception('init() must have single int32 output parameter')\n> > -\n> > - # No need to validate start() as it is customizable\n> > + # No need to validate init() and start() as they are customizable\n> > \n> > # Validate parameters to stop()\n> > ValidateZeroLength(f_stop.parameters, 'input parameter to stop()')\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3BAC4BD1F1\n\tfor ;\n\tThu, 4 Mar 2021 08:59:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A717F68A98;\n\tThu, 4 Mar 2021 09:59:25 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1A99D602EC\n\tfor ;\n\tThu, 4 Mar 2021 09:59:24 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9317327A;\n\tThu, 4 Mar 2021 09:59:22 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QWIB4w1i\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614848363;\n\tbh=6FzTRo87iTFCRuEIRWfLwabwbk1NcsPlhIGZeg2+zqc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QWIB4w1iBsw+MERy/Gg0p8Joc2LwdwCAL2zc6YzyGogDXNl125lQzFIAAe6tXRfPc\n\tAC+DFRpSSRfdCOY8Oh9mvqJbEnncuwDA0GAPa/LLJREhhm1zahE+PlaKuB2MRHElfH\n\tLSPqPKQ51cbNicU48MfCEXb+LJ404tudHuM/0q/4=","Date":"Thu, 4 Mar 2021 17:59:16 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20210304085916.GD2049@pyrite.rasen.tech>","References":"<20210304084703.11542-1-paul.elder@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v1 1/2] utils: ipc: Support custom\n\tparameters to init()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]