[{"id":15559,"web_url":"https://patchwork.libcamera.org/comment/15559/","msgid":"<20210309095016.GB90611@pyrite.rasen.tech>","date":"2021-03-09T09:50:16","subject":"Re: [libcamera-devel] [PATCH v4 3/7] libcamera: delayed_controls:\n\tRemove unneeded write when starting up","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Naush,\n\nOn Thu, Mar 04, 2021 at 08:17:24AM +0000, Naushir Patuck wrote:\n> On DelayedControls::reset(), the values retrieved from the sensor device\n> were added to the queues with the updated flag set to true. This would\n> cause the helper to write out the value to the device again on the first\n> DelayedControls::applyControls() call. This is unnecessary, as the\n> controls written are identical to what is stored in the device driver.\n> \n> Fix this by explicitly setting the update flag to false in\n> DelayedControls::reset() when adding the controls to the queue.\n> \n> Additionally, use the Info() constructor when adding items to the queue\n> for consistency.\n> \n> Signed-off-by: Naushir Patuck \n> Fixes: 3d4b7b005911 (\"libcamera: delayed_controls: Add helper for controls that apply with a delay\")\n> Tested-by: David Plowman \n\nReviewed-by: Paul Elder \n\n> ---\n> include/libcamera/internal/delayed_controls.h | 4 ++--\n> src/libcamera/delayed_controls.cpp | 9 ++++++---\n> 2 files changed, 8 insertions(+), 5 deletions(-)\n> \n> diff --git a/include/libcamera/internal/delayed_controls.h b/include/libcamera/internal/delayed_controls.h\n> index 564d9f2e2440..2a6a912bde10 100644\n> --- a/include/libcamera/internal/delayed_controls.h\n> +++ b/include/libcamera/internal/delayed_controls.h\n> @@ -43,8 +43,8 @@ private:\n> \t\t{\n> \t\t}\n> \n> -\t\tInfo(const ControlValue &v)\n> -\t\t\t: ControlValue(v), updated(true)\n> +\t\tInfo(const ControlValue &v, bool updated_ = true)\n> +\t\t\t: ControlValue(v), updated(updated_)\n> \t\t{\n> \t\t}\n> \n> diff --git a/src/libcamera/delayed_controls.cpp b/src/libcamera/delayed_controls.cpp\n> index 3ed1dfebd035..f6d761d1cc41 100644\n> --- a/src/libcamera/delayed_controls.cpp\n> +++ b/src/libcamera/delayed_controls.cpp\n> @@ -111,7 +111,11 @@ void DelayedControls::reset()\n> \tvalues_.clear();\n> \tfor (const auto &ctrl : controls) {\n> \t\tconst ControlId *id = device_->controls().idmap().at(ctrl.first);\n> -\t\tvalues_[id][0] = Info(ctrl.second);\n> +\t\t/*\n> +\t\t * Do not mark this control value as updated, it does not need\n> +\t\t * to be written to to device on startup.\n> +\t\t */\n> +\t\tvalues_[id][0] = Info(ctrl.second, false);\n> \t}\n> }\n> \n> @@ -150,8 +154,7 @@ bool DelayedControls::push(const ControlList &controls)\n> \n> \t\tInfo &info = values_[id][queueCount_];\n> \n> -\t\tinfo = control.second;\n> -\t\tinfo.updated = true;\n> +\t\tinfo = Info(control.second);\n> \n> \t\tLOG(DelayedControls, Debug)\n> \t\t\t<< \"Queuing \" << id->name()\n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D30C4BD1F1\n\tfor ;\n\tTue, 9 Mar 2021 09:50:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8F85E68A9F;\n\tTue, 9 Mar 2021 10:50:24 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B94916051F\n\tfor ;\n\tTue, 9 Mar 2021 10:50:23 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6B107E9;\n\tTue, 9 Mar 2021 10:50:22 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oCReRcfK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615283423;\n\tbh=wp58ZrJGz0ZVwBDElTiQDIqf/vEGToIW5jelBdWfzWg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=oCReRcfK2GpoarLOylo/soO4qG/gofLg1nMRtMmK9rlaIfa4D++qU8BHb4NiUcFeh\n\t2M+nIPkGDgi77s6WMJ9DXd3OJFiXHTLKutNqWfj/JqcJfLeMoBk3H8Mja0YY7Wud9y\n\tmQxZRtS7zsOB9p1v1WRI+C3D87AMX3hagC23siQo=","Date":"Tue, 9 Mar 2021 18:50:16 +0900","From":"paul.elder@ideasonboard.com","To":"Naushir Patuck ","Message-ID":"<20210309095016.GB90611@pyrite.rasen.tech>","References":"<20210304081728.1058394-1-naush@raspberrypi.com>\n\t<20210304081728.1058394-4-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210304081728.1058394-4-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v4 3/7] libcamera: delayed_controls:\n\tRemove unneeded write when starting up","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15562,"web_url":"https://patchwork.libcamera.org/comment/15562/","msgid":"<534533f1-8435-bdef-0615-633970ba5f33@gmail.com>","date":"2021-03-09T09:55:54","subject":"Re: [libcamera-devel] [PATCH v4 3/7] libcamera: delayed_controls:\n\tRemove unneeded write when starting up","submitter":{"id":74,"url":"https://patchwork.libcamera.org/api/people/74/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@gmail.com"},"content":"On 09/03/2021 10:50, paul.elder@ideasonboard.com wrote:\n> Hi Naush,\n> \n> On Thu, Mar 04, 2021 at 08:17:24AM +0000, Naushir Patuck wrote:\n>> On DelayedControls::reset(), the values retrieved from the sensor device\n>> were added to the queues with the updated flag set to true. This would\n>> cause the helper to write out the value to the device again on the first\n>> DelayedControls::applyControls() call. This is unnecessary, as the\n>> controls written are identical to what is stored in the device driver.\n>>\n>> Fix this by explicitly setting the update flag to false in\n>> DelayedControls::reset() when adding the controls to the queue.\n>>\n>> Additionally, use the Info() constructor when adding items to the queue\n>> for consistency.\n>>\n>> Signed-off-by: Naushir Patuck \n>> Fixes: 3d4b7b005911 (\"libcamera: delayed_controls: Add helper for controls that apply with a delay\")\n>> Tested-by: David Plowman \n> \n> Reviewed-by: Paul Elder \nTested-by: Jean-Michel Hautbois \n> \n>> ---\n>> include/libcamera/internal/delayed_controls.h | 4 ++--\n>> src/libcamera/delayed_controls.cpp | 9 ++++++---\n>> 2 files changed, 8 insertions(+), 5 deletions(-)\n>>\n>> diff --git a/include/libcamera/internal/delayed_controls.h b/include/libcamera/internal/delayed_controls.h\n>> index 564d9f2e2440..2a6a912bde10 100644\n>> --- a/include/libcamera/internal/delayed_controls.h\n>> +++ b/include/libcamera/internal/delayed_controls.h\n>> @@ -43,8 +43,8 @@ private:\n>> \t\t{\n>> \t\t}\n>> \n>> -\t\tInfo(const ControlValue &v)\n>> -\t\t\t: ControlValue(v), updated(true)\n>> +\t\tInfo(const ControlValue &v, bool updated_ = true)\n>> +\t\t\t: ControlValue(v), updated(updated_)\n>> \t\t{\n>> \t\t}\n>> \n>> diff --git a/src/libcamera/delayed_controls.cpp b/src/libcamera/delayed_controls.cpp\n>> index 3ed1dfebd035..f6d761d1cc41 100644\n>> --- a/src/libcamera/delayed_controls.cpp\n>> +++ b/src/libcamera/delayed_controls.cpp\n>> @@ -111,7 +111,11 @@ void DelayedControls::reset()\n>> \tvalues_.clear();\n>> \tfor (const auto &ctrl : controls) {\n>> \t\tconst ControlId *id = device_->controls().idmap().at(ctrl.first);\n>> -\t\tvalues_[id][0] = Info(ctrl.second);\n>> +\t\t/*\n>> +\t\t * Do not mark this control value as updated, it does not need\n>> +\t\t * to be written to to device on startup.\n>> +\t\t */\n>> +\t\tvalues_[id][0] = Info(ctrl.second, false);\n>> \t}\n>> }\n>> \n>> @@ -150,8 +154,7 @@ bool DelayedControls::push(const ControlList &controls)\n>> \n>> \t\tInfo &info = values_[id][queueCount_];\n>> \n>> -\t\tinfo = control.second;\n>> -\t\tinfo.updated = true;\n>> +\t\tinfo = Info(control.second);\n>> \n>> \t\tLOG(DelayedControls, Debug)\n>> \t\t\t<< \"Queuing \" << id->name()\n>> -- \n>> 2.25.1\n>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C44D5BD80C\n\tfor ;\n\tTue, 9 Mar 2021 09:55:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7F91268A9F;\n\tTue, 9 Mar 2021 10:55:58 +0100 (CET)","from mail-wr1-x436.google.com (mail-wr1-x436.google.com\n\t[IPv6:2a00:1450:4864:20::436])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D6EAE6051F\n\tfor ;\n\tTue, 9 Mar 2021 10:55:56 +0100 (CET)","by mail-wr1-x436.google.com with SMTP id v15so14501299wrx.4\n\tfor ;\n\tTue, 09 Mar 2021 01:55:56 -0800 (PST)","from ?IPv6:2a01:e0a:169:7140:eb55:7706:22b:1e57?\n\t([2a01:e0a:169:7140:eb55:7706:22b:1e57])\n\tby smtp.gmail.com with ESMTPSA id\n\tr11sm24332850wrm.26.2021.03.09.01.55.55\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tTue, 09 Mar 2021 01:55:55 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"MaGWid4L\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=Hj9agmo1OuO0lZeBQzf64mdu9n2WVIf3S8jOFdBRvLA=;\n\tb=MaGWid4L2IVpdUinckzTvFlo9SPSHgsITrtqnslQJwV1Q7dm6QVZwfwlL7BabSehtz\n\ttPYQ0dbW78B4yP89LoYGOcVrX2McCmsJmIWOePCxqR17hPH1kGMFHre+54TxkIbB3lFP\n\t1iPVf97hT962kHtfQNFEVNUJj+Q1HDhVZzGrkaedkvPJvlhfGtDHTceXpsaZ5tS/rCBT\n\t2lotpLe7DQMZrbA6b66i1zL8TAxL/eMCbGniY4Um4Wm0qNal5DE8lrTQMAZTt6lwoSx5\n\tpQR9cl8fuo19dzTPMniBfliu07uwnmwYGF1ty/AJQZGTgFogqdi+fmAcFHJ1pKckoYJL\n\tzx/A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=Hj9agmo1OuO0lZeBQzf64mdu9n2WVIf3S8jOFdBRvLA=;\n\tb=LPabtWTov4kBWh2lyG3DDchh7bVd+40ArIB6t9tV+9co4JH7shuRRtgaia5HNA6/o0\n\tFRWG9gZWgXhyn9WbKR2nbf+EI8ENIn+yAYIPPS/DzbZWT6ofEuI6xLq13lHy1YvOS3cn\n\tIU4hCPSHhD/Tng0VT8DZ96j7GydRtQujrnu7VTG8rAaQJOz6R6GtddJiS/kn6C647i0H\n\th0MUoumfdfqhvsHIptvJ+ZkJpNNUkoUYjgqPdySkW6hFz3TXbiqgmwh1km8ll37PHUwa\n\tpjWT0TmzgAHaFiOF+YT2guayXiSqOBSmqZ5TD+4s2UzgruoV7HfaXlk/RWR9lbxuXalL\n\tTetg==","X-Gm-Message-State":"AOAM5327bDx3JmdrZMExiV8IPkF6DvcrwVenXds2PCqhpwTZn/lGWgiv\n\tm3+H79PqVw6avNtGBWq0OsxFGQ5tEEDumQ==","X-Google-Smtp-Source":"ABdhPJypSp3Y5lx6T7Rr95u66ArcoJEFvbp9N/YLg34LK/3fnwPDP3kdUWaHc4kt0DdwABmtqqDr+A==","X-Received":"by 2002:a5d:4c84:: with SMTP id z4mr3725917wrs.158.1615283755939;\n\tTue, 09 Mar 2021 01:55:55 -0800 (PST)","To":"paul.elder@ideasonboard.com, Naushir Patuck ","References":"<20210304081728.1058394-1-naush@raspberrypi.com>\n\t<20210304081728.1058394-4-naush@raspberrypi.com>\n\t<20210309095016.GB90611@pyrite.rasen.tech>","From":"Jean-Michel Hautbois ","Message-ID":"<534533f1-8435-bdef-0615-633970ba5f33@gmail.com>","Date":"Tue, 9 Mar 2021 10:55:54 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.7.1","MIME-Version":"1.0","In-Reply-To":"<20210309095016.GB90611@pyrite.rasen.tech>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v4 3/7] libcamera: delayed_controls:\n\tRemove unneeded write when starting up","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15614,"web_url":"https://patchwork.libcamera.org/comment/15614/","msgid":"<3d84d820-2c87-5f3f-de6a-9cd95310c5e2@ideasonboard.com>","date":"2021-03-12T13:27:58","subject":"Re: [libcamera-devel] [PATCH v4 3/7] libcamera: delayed_controls:\n\tRemove unneeded write when starting up","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\n\nOn 04/03/2021 08:17, Naushir Patuck wrote:\n> On DelayedControls::reset(), the values retrieved from the sensor device\n> were added to the queues with the updated flag set to true. This would\n> cause the helper to write out the value to the device again on the first\n> DelayedControls::applyControls() call. This is unnecessary, as the\n> controls written are identical to what is stored in the device driver.\n> \n> Fix this by explicitly setting the update flag to false in\n> DelayedControls::reset() when adding the controls to the queue.\n> \n> Additionally, use the Info() constructor when adding items to the queue\n> for consistency.\n> \n> Signed-off-by: Naushir Patuck \n> Fixes: 3d4b7b005911 (\"libcamera: delayed_controls: Add helper for controls that apply with a delay\")\n> Tested-by: David Plowman \n\nReviewed-by: Kieran Bingham \n\n> ---\n> include/libcamera/internal/delayed_controls.h | 4 ++--\n> src/libcamera/delayed_controls.cpp | 9 ++++++---\n> 2 files changed, 8 insertions(+), 5 deletions(-)\n> \n> diff --git a/include/libcamera/internal/delayed_controls.h b/include/libcamera/internal/delayed_controls.h\n> index 564d9f2e2440..2a6a912bde10 100644\n> --- a/include/libcamera/internal/delayed_controls.h\n> +++ b/include/libcamera/internal/delayed_controls.h\n> @@ -43,8 +43,8 @@ private:\n> \t\t{\n> \t\t}\n> \n> -\t\tInfo(const ControlValue &v)\n> -\t\t\t: ControlValue(v), updated(true)\n> +\t\tInfo(const ControlValue &v, bool updated_ = true)\n> +\t\t\t: ControlValue(v), updated(updated_)\n> \t\t{\n> \t\t}\n> \n> diff --git a/src/libcamera/delayed_controls.cpp b/src/libcamera/delayed_controls.cpp\n> index 3ed1dfebd035..f6d761d1cc41 100644\n> --- a/src/libcamera/delayed_controls.cpp\n> +++ b/src/libcamera/delayed_controls.cpp\n> @@ -111,7 +111,11 @@ void DelayedControls::reset()\n> \tvalues_.clear();\n> \tfor (const auto &ctrl : controls) {\n> \t\tconst ControlId *id = device_->controls().idmap().at(ctrl.first);\n> -\t\tvalues_[id][0] = Info(ctrl.second);\n> +\t\t/*\n> +\t\t * Do not mark this control value as updated, it does not need\n> +\t\t * to be written to to device on startup.\n> +\t\t */\n> +\t\tvalues_[id][0] = Info(ctrl.second, false);\n> \t}\n> }\n> \n> @@ -150,8 +154,7 @@ bool DelayedControls::push(const ControlList &controls)\n> \n> \t\tInfo &info = values_[id][queueCount_];\n> \n> -\t\tinfo = control.second;\n> -\t\tinfo.updated = true;\n> +\t\tinfo = Info(control.second);\n> \n> \t\tLOG(DelayedControls, Debug)\n> \t\t\t<< \"Queuing \" << id->name()\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A907CBD1F1\n\tfor ;\n\tFri, 12 Mar 2021 13:28:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F0A8768C68;\n\tFri, 12 Mar 2021 14:28:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 280F168AA1\n\tfor ;\n\tFri, 12 Mar 2021 14:28:01 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AC84FA2A;\n\tFri, 12 Mar 2021 14:28:00 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kvgQt2Gw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615555680;\n\tbh=1t7CmgaNOBtiS4LJUClK3eBm0BtKmSm0FfNvgEFGfJs=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=kvgQt2GwKjPx6qT+L5zmJRJyXjCMM82Pcri+HFIYZBIFP4sRat8jLijYUPjb6b5HN\n\tulLZoSQmC/0dJp3JE486J+KV+WeCAnSVFukVMNM1GM4RQcjAZ850uK8f+jKgBewlHk\n\tguEjfF3hlcBqZodImlmm6mAnYbh6EhAxfhKWoNcQ=","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210304081728.1058394-1-naush@raspberrypi.com>\n\t<20210304081728.1058394-4-naush@raspberrypi.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<3d84d820-2c87-5f3f-de6a-9cd95310c5e2@ideasonboard.com>","Date":"Fri, 12 Mar 2021 13:27:58 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210304081728.1058394-4-naush@raspberrypi.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v4 3/7] libcamera: delayed_controls:\n\tRemove unneeded write when starting up","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]