{"id":11459,"url":"https://patchwork.libcamera.org/api/patches/11459/?format=json","web_url":"https://patchwork.libcamera.org/patch/11459/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210302150501.15191-1-laurent.pinchart@ideasonboard.com>","date":"2021-03-02T15:05:00","name":"[libcamera-devel,1/2] utils: ipc: templates: Drop unused variable","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"1334e632ea908435cbdc36406144c549178508ba","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11459/mbox/","series":[{"id":1741,"url":"https://patchwork.libcamera.org/api/series/1741/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1741","date":"2021-03-02T15:05:00","name":"[libcamera-devel,1/2] utils: ipc: templates: Drop unused variable","version":1,"mbox":"https://patchwork.libcamera.org/series/1741/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11459/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11459/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 61747BD1F1\n\tfor ;\n\tTue, 2 Mar 2021 15:05:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CD54068A9A;\n\tTue, 2 Mar 2021 16:05:35 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7C10168A7E\n\tfor ;\n\tTue, 2 Mar 2021 16:05:34 +0100 (CET)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DA08545D;\n\tTue, 2 Mar 2021 16:05:33 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WzpjXtut\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614697534;\n\tbh=h0Tfad6BDwqwYPgf+8/fureccdPbka/8mpPSYXhVpUM=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=WzpjXtutQ8QyGZ6mj7K5FscOl1Fwb+pYNSlfCedw2+Grbc6ESy3/A8h4+oYMg3rOi\n\tps5CDqwVJURzyBInbPUaLUMym8Gfsgk2ZlIATh5kUvaoRA0vB8NuCCQcLdCkFYVNq6\n\tayruz1/fkdn5GgGHgsz/j0myFfvLfMLaAZzQJ7qk=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 2 Mar 2021 17:05:00 +0200","Message-Id":"<20210302150501.15191-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.28.0","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 1/2] utils: ipc: templates: Drop unused\n\tvariable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The has_input variable is unused, drop it.\n\nSigned-off-by: Laurent Pinchart \n---\n .../ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl | 1 -\n 1 file changed, 1 deletion(-)","diff":"diff --git a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\nindex ba34a361f811..d451fab35e83 100644\n--- a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n+++ b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n@@ -174,7 +174,6 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n \n {{proxy_funcs.func_sig(proxy_name, method, \"IPC\")}}\n {\n-{%- set has_input = true if method|method_param_inputs|length > 0 %}\n {%- set has_output = true if method|method_param_outputs|length > 0 or method|method_return_value != \"void\" %}\n {%- set cmd = cmd_enum_name + \"::\" + method.mojom_name|cap %}\n \tIPCMessage::Header _header = { static_cast({{cmd}}), seq_++ };\n","prefixes":["libcamera-devel","1/2"]}