{"id":11457,"url":"https://patchwork.libcamera.org/api/patches/11457/?format=json","web_url":"https://patchwork.libcamera.org/patch/11457/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210302141844.126634-11-jacopo@jmondi.org>","date":"2021-03-02T14:18:43","name":"[libcamera-devel,v4,10/11] android: mm: Provide helper macro for PIMPL","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"42630a8a607772d12c0ea27f44c76fa093261fe3","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11457/mbox/","series":[{"id":1740,"url":"https://patchwork.libcamera.org/api/series/1740/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1740","date":"2021-03-02T14:18:33","name":"android: Supports memory backends","version":4,"mbox":"https://patchwork.libcamera.org/series/1740/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11457/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11457/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 35D45BD808\n\tfor ;\n\tTue, 2 Mar 2021 14:18:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 123F268A9A;\n\tTue, 2 Mar 2021 15:18:40 +0100 (CET)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E334C68AA4\n\tfor ;\n\tTue, 2 Mar 2021 15:18:37 +0100 (CET)","from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 6082F200010;\n\tTue, 2 Mar 2021 14:18:36 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 2 Mar 2021 15:18:43 +0100","Message-Id":"<20210302141844.126634-11-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.30.0","In-Reply-To":"<20210302141844.126634-1-jacopo@jmondi.org>","References":"<20210302141844.126634-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 10/11] android: mm: Provide helper\n\tmacro for PIMPL","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Han-lin Chen ,\n\tDaniel Hung-yu Wu ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Each memory backend has to declare a CameraBuffer class implementation\nthat bridges the API calls to each CameraBuffer::Private implementation.\n\nAs the code is likely the same for most (if not all) backends, provide\na convenience macro that expands to the CameraBuffer class declaration.\n\nReviewed-by: Laurent Pinchart \nSigned-off-by: Jacopo Mondi \n---\n src/android/camera_buffer.h | 33 ++++++++++++++++++++\n src/android/mm/generic_camera_buffer.cpp | 39 +-----------------------\n 2 files changed, 34 insertions(+), 38 deletions(-)","diff":"diff --git a/src/android/camera_buffer.h b/src/android/camera_buffer.h\nindex 784fbd50e50b..7e8970b49f49 100644\n--- a/src/android/camera_buffer.h\n+++ b/src/android/camera_buffer.h\n@@ -30,4 +30,37 @@ public:\n \tsize_t jpegBufferSize(size_t maxJpegBufferSize) const;\n };\n \n+#define PUBLIC_CAMERA_BUFFER_IMPLEMENTATION\t\t\t\t\\\n+CameraBuffer::CameraBuffer(buffer_handle_t camera3Buffer, int flags)\t\\\n+\t: Extensible(new Private(this, camera3Buffer, flags))\t\t\\\n+{\t\t\t\t\t\t\t\t\t\\\n+}\t\t\t\t\t\t\t\t\t\\\n+CameraBuffer::~CameraBuffer()\t\t\t\t\t\t\\\n+{\t\t\t\t\t\t\t\t\t\\\n+}\t\t\t\t\t\t\t\t\t\\\n+bool CameraBuffer::isValid() const\t\t\t\t\t\\\n+{\t\t\t\t\t\t\t\t\t\\\n+\tconst Private *const d = LIBCAMERA_D_PTR();\t\t\t\\\n+\treturn d->isValid();\t\t\t\t\t\t\\\n+}\t\t\t\t\t\t\t\t\t\\\n+unsigned int CameraBuffer::numPlanes() const\t\t\t\t\\\n+{\t\t\t\t\t\t\t\t\t\\\n+\tconst Private *const d = LIBCAMERA_D_PTR();\t\t\t\\\n+\treturn d->numPlanes();\t\t\t\t\t\t\\\n+}\t\t\t\t\t\t\t\t\t\\\n+Span CameraBuffer::plane(unsigned int plane) const\t\\\n+{\t\t\t\t\t\t\t\t\t\\\n+\tconst Private *const d = LIBCAMERA_D_PTR();\t\t\t\\\n+\treturn const_cast(d)->plane(plane);\t\t\t\\\n+}\t\t\t\t\t\t\t\t\t\\\n+Span CameraBuffer::plane(unsigned int plane)\t\t\t\\\n+{\t\t\t\t\t\t\t\t\t\\\n+\tPrivate *const d = LIBCAMERA_D_PTR();\t\t\t\t\\\n+\treturn d->plane(plane);\t\t\t\t\t\t\\\n+}\t\t\t\t\t\t\t\t\t\\\n+size_t CameraBuffer::jpegBufferSize(size_t maxJpegBufferSize) const\t\\\n+{\t\t\t\t\t\t\t\t\t\\\n+\tconst Private *const d = LIBCAMERA_D_PTR();\t\t\t\\\n+\treturn d->jpegBufferSize(maxJpegBufferSize);\t\t\t\\\n+}\n #endif /* __ANDROID_CAMERA_BUFFER_H__ */\ndiff --git a/src/android/mm/generic_camera_buffer.cpp b/src/android/mm/generic_camera_buffer.cpp\nindex 98e63dfa0577..929e078ad4c9 100644\n--- a/src/android/mm/generic_camera_buffer.cpp\n+++ b/src/android/mm/generic_camera_buffer.cpp\n@@ -85,41 +85,4 @@ size_t CameraBuffer::Private::jpegBufferSize(size_t maxJpegBufferSize) const\n \t\t\t\t maxJpegBufferSize);\n }\n \n-CameraBuffer::CameraBuffer(buffer_handle_t camera3Buffer, int flags)\n-\t: Extensible(new Private(this, camera3Buffer, flags))\n-{\n-}\n-\n-CameraBuffer::~CameraBuffer()\n-{\n-}\n-\n-bool CameraBuffer::isValid() const\n-{\n-\tconst Private *const d = LIBCAMERA_D_PTR();\n-\treturn d->isValid();\n-}\n-\n-unsigned int CameraBuffer::numPlanes() const\n-{\n-\tconst Private *const d = LIBCAMERA_D_PTR();\n-\treturn d->numPlanes();\n-}\n-\n-Span CameraBuffer::plane(unsigned int plane) const\n-{\n-\tconst Private *const d = LIBCAMERA_D_PTR();\n-\treturn const_cast(d)->plane(plane);\n-}\n-\n-Span CameraBuffer::plane(unsigned int plane)\n-{\n-\tPrivate *const d = LIBCAMERA_D_PTR();\n-\treturn d->plane(plane);\n-}\n-\n-size_t CameraBuffer::jpegBufferSize(size_t maxJpegBufferSize) const\n-{\n-\tconst Private *const d = LIBCAMERA_D_PTR();\n-\treturn d->jpegBufferSize(maxJpegBufferSize);\n-}\n+PUBLIC_CAMERA_BUFFER_IMPLEMENTATION\n","prefixes":["libcamera-devel","v4","10/11"]}