[{"id":15424,"web_url":"https://patchwork.libcamera.org/comment/15424/","msgid":"","date":"2021-03-02T15:07:51","subject":"Re: [libcamera-devel] [PATCH v4 09/11] android: jpeg: Use\n\tCameraBuffer::jpegBufferSize()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Mar 02, 2021 at 03:18:42PM +0100, Jacopo Mondi wrote:\n> Use the newly introduced function to retrieve the size of\n> the JPEG encoding destination buffer, in order to calculate where\n> the JPEG_BLOB_ID should be placed.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/jpeg/post_processor_jpeg.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp\n> index 83244ce6769e..3bf16996a147 100644\n> --- a/src/android/jpeg/post_processor_jpeg.cpp\n> +++ b/src/android/jpeg/post_processor_jpeg.cpp\n> @@ -183,7 +183,7 @@ int PostProcessorJpeg::process(const FrameBuffer &source,\n> \n> \t/* Fill in the JPEG blob header. */\n> \tuint8_t *resultPtr = destination->plane(0).data()\n> -\t\t\t + destination->plane(0).size()\n> +\t\t\t + destination->jpegBufferSize(cameraDevice_->maxJpegBufferSize())\n> \t\t\t - sizeof(struct camera3_jpeg_blob);\n> \tauto *blob = reinterpret_cast(resultPtr);\n> \tblob->jpeg_blob_id = CAMERA3_JPEG_BLOB_ID;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3D43ABD808\n\tfor ;\n\tTue, 2 Mar 2021 15:08:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0BB4568A9A;\n\tTue, 2 Mar 2021 16:08:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6514F68A7E\n\tfor ;\n\tTue, 2 Mar 2021 16:08:20 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EC50045D;\n\tTue, 2 Mar 2021 16:08:19 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZAN8yHGn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614697700;\n\tbh=zmOc8t27yJuyUxtVKqMlc2l4HWM/7XVslL6+5pNCDsQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZAN8yHGnP3CFXCd9gaQApBETv5bviMqTgudUaJH1hT1GO2hQ2d5GuaoaVd4KDc2fl\n\tWvoSTRjtKdgZBQv++O2wqsPPSQL9m75nfr+JsIbU6/f1LWeoxP7XvA/BwgQ2wJDR9T\n\tJhXWadJrg4du0/guQLVdb3pYpOXmHU+hJl7NTKq8=","Date":"Tue, 2 Mar 2021 17:07:51 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210302141844.126634-1-jacopo@jmondi.org>\n\t<20210302141844.126634-10-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210302141844.126634-10-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v4 09/11] android: jpeg: Use\n\tCameraBuffer::jpegBufferSize()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Han-lin Chen ,\n\tlibcamera-devel@lists.libcamera.org, Daniel Hung-yu Wu ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]