[{"id":1547,"web_url":"https://patchwork.libcamera.org/comment/1547/","msgid":"<20190430185919.GT16573@bigcity.dyn.berto.se>","date":"2019-04-30T18:59:19","subject":"Re: [libcamera-devel] [PATCH 5/5] (q)cam: Unify naming of\n\tconfigurations in applications","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-04-30 21:37:46 +0300, Laurent Pinchart wrote:\n> Name all instances of CameraConfiguration \"config\", and all instances of\n> StreamConfiguration \"cfg\" accross the cam and qcam applications.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/qcam/main_window.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\n> index 6e92f6a1124d..ee06d751672b 100644\n> --- a/src/qcam/main_window.cpp\n> +++ b/src/qcam/main_window.cpp\n> @@ -105,9 +105,9 @@ int MainWindow::startCapture()\n> \t\treturn ret;\n> \t}\n> \n> -\tconst StreamConfiguration &sconf = config_[stream];\n> -\tret = viewfinder_->setFormat(sconf.pixelFormat, sconf.size.width,\n> -\t\t\t\t sconf.size.height);\n> +\tconst StreamConfiguration &cfg = config_[stream];\n> +\tret = viewfinder_->setFormat(cfg.pixelFormat, cfg.size.width,\n> +\t\t\t\t cfg.size.height);\n> \tif (ret < 0) {\n> \t\tstd::cout << \"Failed to set viewfinder format\" << std::endl;\n> \t\treturn ret;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x134.google.com (mail-lf1-x134.google.com\n\t[IPv6:2a00:1450:4864:20::134])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 21E1A60E5B\n\tfor ;\n\tTue, 30 Apr 2019 20:59:21 +0200 (CEST)","by mail-lf1-x134.google.com with SMTP id j20so11719706lfh.2\n\tfor ;\n\tTue, 30 Apr 2019 11:59:21 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tt17sm620206ljg.70.2019.04.30.11.59.19\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 30 Apr 2019 11:59:20 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=6jK+XI9HwN4NLHbr3v/rbFUnwkgdaTNkQDXLhJYKYMc=;\n\tb=Tv+ITqQUQhjRZkidXu2hsvWCVuEJyBREu4w5/palGUCtmmxBrsFbMsStJGVgmKWEjy\n\tPAz+EUavabdt1eHx9QcHEJS+SE/h3yyBvt3D1NlxN6I5hFzvnpVJUnqnBCdFUXcbPP7u\n\tBdki+cjkL+z+X0qdFN/HNT1ic5Mv9ebYD4aArMwai1+teJvPacDFyPJZaQ/6y014/NmR\n\tRr0wVA/XsnDMIaTj6Fze8BRJWmSq8cH9f47XiT8493yCseoGXZScQ1RNlbCT41L0skd2\n\tJUHRG46QPmlRGtGpUER41TVQbgJ0HuKBBohdGwIJx9tQlfsVriXzUgR8ehN5I5rqTBYK\n\t9fJw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=6jK+XI9HwN4NLHbr3v/rbFUnwkgdaTNkQDXLhJYKYMc=;\n\tb=fW5YI5zxkS16AlHcLGhIi6WvMpb9EehXTyANn4tA9sTumyYAGijro6RRaVSdXLpeLb\n\tf87K4HQEr/G6V7WbbutWWsKrbNBal3aFTWPYFzZTQmzLmtSo/tRL17RuT2prDuQaXG0l\n\tKGMop2HFqDrMoYSbz4b7gMnuOGpi+efwY71dgTLpSDm9NJz4S2Nejq0q1okAOep+5X8n\n\tO/Tu+wYo57XHpc0jG74VcQPQzo9KNvzphi3jTtkqMhQhx589Zo0NBHr2fKqhcDm4kR3n\n\td+m9D1bpj7UmOeISjk5rvmqx5Zi34mBvU9aKO7jETYZ24itZKBTM+11LMcnwB6Lm/QNV\n\tT8CQ==","X-Gm-Message-State":"APjAAAXFCRSCff1DpHWKIlgymkP6yFQbCrslZnn85L2UO6+RBbh68skI\n\tnXD1Br5dWth/1+goeV/hSMPyGw==","X-Google-Smtp-Source":"APXvYqzTpWScFpx5u7G0XwlKu7NoPg8rJZYs5+nOFZF1dEv4sZlS6mp75SfyP0GM6sjx46t6wIBPow==","X-Received":"by 2002:ac2:4a89:: with SMTP id l9mr8933753lfp.60.1556650760601; \n\tTue, 30 Apr 2019 11:59:20 -0700 (PDT)","Date":"Tue, 30 Apr 2019 20:59:19 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190430185919.GT16573@bigcity.dyn.berto.se>","References":"<20190430183746.28518-1-laurent.pinchart@ideasonboard.com>\n\t<20190430183746.28518-6-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190430183746.28518-6-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.11.3 (2019-02-01)","Subject":"Re: [libcamera-devel] [PATCH 5/5] (q)cam: Unify naming of\n\tconfigurations in applications","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 30 Apr 2019 18:59:21 -0000"}}]