[{"id":15417,"web_url":"https://patchwork.libcamera.org/comment/15417/","msgid":"","date":"2021-03-02T12:29:32","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: pipeline_handler:\n\tUpdate request usage comment","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Tue, Mar 02, 2021 at 12:23:41PM +0000, Kieran Bingham wrote:\n> When a pipeline handler completes a request, the request itself is not\n> deleted by libcamera, and the application regains control over the\n> object. It may choose to delete the Request, or re-use it.\n> \n> Clarify this in the comment by removing the declaration that the Request\n> is deleted, but state that it is no longer managed by the pipeline\n> handler and must not be accessed further after this function returns.\n> \n> Signed-off-by: Kieran Bingham \n\nThank you for the patch.\n\n> ---\n> src/libcamera/pipeline_handler.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index aff83af2e90e..0255d9476de0 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -432,8 +432,8 @@ bool PipelineHandler::completeBuffer(Request *request, FrameBuffer *buffer)\n> * \\param[in] request The request that has completed\n> *\n> * The pipeline handler shall call this method to notify the \\a camera that the\n> - * request has completed. The request is deleted and shall not be accessed once\n> - * this method returns.\n> + * request has completed. The request is no longer managed by the pipeline\n> + * handler and shall not be accessed once this method returns.\n> *\n> * This method ensures that requests will be returned to the application in\n> * submission order, the pipeline handler may call it on any complete request","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E9EF8BD1F1\n\tfor ;\n\tTue, 2 Mar 2021 12:30:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B709368A9A;\n\tTue, 2 Mar 2021 13:30:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0BFF568A91\n\tfor ;\n\tTue, 2 Mar 2021 13:30:01 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9B8A045D;\n\tTue, 2 Mar 2021 13:30:00 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hVfhJvAy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614688200;\n\tbh=CiUY1Fk1Q55uoRut1gGjuxImQQg1uov6AI1cFBbxM4E=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hVfhJvAyyFWL54OtX+uyeTXGGL16Nofo3WL954Fg9o0viRHboDeipRllW4NkBVd/Y\n\tp7gXugI8NLusEAVktr4Ekd1wy+BEs3UHo4+R5xCNyBzd8VLSPiHYdbkoN7RBAUl6QU\n\tRA19wZyUJlc8Y4nKjGnukzZCWY7h1FsqOFjPKwVo=","Date":"Tue, 2 Mar 2021 14:29:32 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210302122341.83985-1-kieran.bingham@ideasonboard.com>\n\t<20210302122341.83985-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210302122341.83985-3-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: pipeline_handler:\n\tUpdate request usage comment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15418,"web_url":"https://patchwork.libcamera.org/comment/15418/","msgid":"<17734609-20b2-f99c-d10d-b907a6aea907@ideasonboard.com>","date":"2021-03-02T12:41:40","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: pipeline_handler:\n\tUpdate request usage comment","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 02/03/2021 12:29, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n\nYou're welcome.\n\n\n> On Tue, Mar 02, 2021 at 12:23:41PM +0000, Kieran Bingham wrote:\n>> When a pipeline handler completes a request, the request itself is not\n>> deleted by libcamera, and the application regains control over the\n>> object. It may choose to delete the Request, or re-use it.\n>>\n>> Clarify this in the comment by removing the declaration that the Request\n>> is deleted, but state that it is no longer managed by the pipeline\n>> handler and must not be accessed further after this function returns.\n>>\n>> Signed-off-by: Kieran Bingham \n> \n> Thank you for the patch.\n\nYou're welcome.\n\nAnything else to add?\n\n\n\n>> ---\n>> src/libcamera/pipeline_handler.cpp | 4 ++--\n>> 1 file changed, 2 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n>> index aff83af2e90e..0255d9476de0 100644\n>> --- a/src/libcamera/pipeline_handler.cpp\n>> +++ b/src/libcamera/pipeline_handler.cpp\n>> @@ -432,8 +432,8 @@ bool PipelineHandler::completeBuffer(Request *request, FrameBuffer *buffer)\n>> * \\param[in] request The request that has completed\n>> *\n>> * The pipeline handler shall call this method to notify the \\a camera that the\n>> - * request has completed. The request is deleted and shall not be accessed once\n>> - * this method returns.\n>> + * request has completed. The request is no longer managed by the pipeline\n>> + * handler and shall not be accessed once this method returns.\n>> *\n>> * This method ensures that requests will be returned to the application in\n>> * submission order, the pipeline handler may call it on any complete request\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7BE2CBD808\n\tfor ;\n\tTue, 2 Mar 2021 12:41:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DED2068A9F;\n\tTue, 2 Mar 2021 13:41:43 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4B7FE68A91\n\tfor ;\n\tTue, 2 Mar 2021 13:41:43 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B8E0B45D;\n\tTue, 2 Mar 2021 13:41:42 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Vss2IEH0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614688902;\n\tbh=URc6YTl2iKJ3lIvWLoD+EmfqGu31KcUSTsPgOpTBmoc=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=Vss2IEH0+FQKN9o9n8lGM9iWLA5w8/yOOMNaAnoDxLifbNXqXGih3e6htSheo6dw2\n\tTdiSr96frivo5EkZNBAnh6Zts21Qs9Rs1SABQkyQ5Y+NghMzUq2JNKY4c7JEm8uH9v\n\tz4OeMiO2+hXXIoKnYj1WCQ8QHJ2g9YYxKGEmuZkk=","To":"Laurent Pinchart ","References":"<20210302122341.83985-1-kieran.bingham@ideasonboard.com>\n\t<20210302122341.83985-3-kieran.bingham@ideasonboard.com>\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<17734609-20b2-f99c-d10d-b907a6aea907@ideasonboard.com>","Date":"Tue, 2 Mar 2021 12:41:40 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: pipeline_handler:\n\tUpdate request usage comment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15420,"web_url":"https://patchwork.libcamera.org/comment/15420/","msgid":"<86a9bf11-76a6-b64d-678d-2b5bc87707c9@uajain.com>","date":"2021-03-02T12:44:52","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: pipeline_handler:\n\tUpdate request usage comment","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/","name":"Umang Jain","email":"email@uajain.com"},"content":"Hi Kieran\n\nOn 3/2/21 5:53 PM, Kieran Bingham wrote:\n> When a pipeline handler completes a request, the request itself is not\n> deleted by libcamera, and the application regains control over the\n> object. It may choose to delete the Request, or re-use it.\n>\n> Clarify this in the comment by removing the declaration that the Request\n> is deleted, but state that it is no longer managed by the pipeline\n> handler and must not be accessed further after this function returns.\n>\n> Signed-off-by: Kieran Bingham \nReviewed-by: Umang Jain \n> ---\n> src/libcamera/pipeline_handler.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index aff83af2e90e..0255d9476de0 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -432,8 +432,8 @@ bool PipelineHandler::completeBuffer(Request *request, FrameBuffer *buffer)\n> * \\param[in] request The request that has completed\n> *\n> * The pipeline handler shall call this method to notify the \\a camera that the\n> - * request has completed. The request is deleted and shall not be accessed once\n> - * this method returns.\n> + * request has completed. The request is no longer managed by the pipeline\n> + * handler and shall not be accessed once this method returns.\n> *\n> * This method ensures that requests will be returned to the application in\n> * submission order, the pipeline handler may call it on any complete request","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3B5B4BD808\n\tfor ;\n\tTue, 2 Mar 2021 12:44:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 090EE68A98;\n\tTue, 2 Mar 2021 13:44:58 +0100 (CET)","from mail.uajain.com (static.126.159.217.95.clients.your-server.de\n\t[95.217.159.126])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 484A268A93\n\tfor ;\n\tTue, 2 Mar 2021 13:44:56 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"hRycAEni\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=uajain.com; s=mail;\n\tt=1614689095; bh=VwyYzr7THwR3g2J/g4wjMwOzcrDU6AA7JEejdk774p4=;\n\th=Subject:To:References:From:In-Reply-To;\n\tb=hRycAEnigS/TZ78XoUfb9nUwEJGnjD4CeaTz2RPUKJy4VOnQezvRXxRqzMfWw4SCO\n\tBtO69GOPMaQseqYbbXM9m/8ig0JLymf3vrk+yu1GhC8HGGkUZchUG4V76cur/wzgGv\n\ttQyHGOwFI5qm3JeMjN8jEHyN3w4UX4e0r49absbm3gUzY87eRZDcXUmiElOPg6Bs98\n\t1CSHBeLW89xKziXccOfjL2IFNFXom1gQWoIr98ZCKY3Jq4pIINuANMgj1OVE4+b2pD\n\tmrqwGOoDrWBr2y5c0AaPQHu7y47Dm7fB0ZjQA5AbxobeT0weCs8JtlhR7kvxChiNOE\n\trI+qgxt4RkRaQ==","To":"libcamera-devel@lists.libcamera.org","References":"<20210302122341.83985-1-kieran.bingham@ideasonboard.com>\n\t<20210302122341.83985-3-kieran.bingham@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<86a9bf11-76a6-b64d-678d-2b5bc87707c9@uajain.com>","Date":"Tue, 2 Mar 2021 18:14:52 +0530","Mime-Version":"1.0","In-Reply-To":"<20210302122341.83985-3-kieran.bingham@ideasonboard.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: pipeline_handler:\n\tUpdate request usage comment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15422,"web_url":"https://patchwork.libcamera.org/comment/15422/","msgid":"","date":"2021-03-02T14:04:47","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: pipeline_handler:\n\tUpdate request usage comment","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Tue, Mar 02, 2021 at 12:41:40PM +0000, Kieran Bingham wrote:\n> On 02/03/2021 12:29, Laurent Pinchart wrote:\n> > On Tue, Mar 02, 2021 at 12:23:41PM +0000, Kieran Bingham wrote:\n> >> When a pipeline handler completes a request, the request itself is not\n> >> deleted by libcamera, and the application regains control over the\n> >> object. It may choose to delete the Request, or re-use it.\n> >>\n> >> Clarify this in the comment by removing the declaration that the Request\n> >> is deleted, but state that it is no longer managed by the pipeline\n> >> handler and must not be accessed further after this function returns.\n> >>\n> >> Signed-off-by: Kieran Bingham \n> > \n> > Thank you for the patch.\n> \n> You're welcome.\n> \n> Anything else to add?\n\nMaybe... After a nap :-)\n\nReviewed-by: Laurent Pinchart \n\n> >> ---\n> >> src/libcamera/pipeline_handler.cpp | 4 ++--\n> >> 1 file changed, 2 insertions(+), 2 deletions(-)\n> >>\n> >> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> >> index aff83af2e90e..0255d9476de0 100644\n> >> --- a/src/libcamera/pipeline_handler.cpp\n> >> +++ b/src/libcamera/pipeline_handler.cpp\n> >> @@ -432,8 +432,8 @@ bool PipelineHandler::completeBuffer(Request *request, FrameBuffer *buffer)\n> >> * \\param[in] request The request that has completed\n> >> *\n> >> * The pipeline handler shall call this method to notify the \\a camera that the\n> >> - * request has completed. The request is deleted and shall not be accessed once\n> >> - * this method returns.\n> >> + * request has completed. The request is no longer managed by the pipeline\n> >> + * handler and shall not be accessed once this method returns.\n> >> *\n> >> * This method ensures that requests will be returned to the application in\n> >> * submission order, the pipeline handler may call it on any complete request","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DBCCEBD1F1\n\tfor ;\n\tTue, 2 Mar 2021 14:05:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6335568A96;\n\tTue, 2 Mar 2021 15:05:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C438A68A93\n\tfor ;\n\tTue, 2 Mar 2021 15:05:15 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 38D0E45D;\n\tTue, 2 Mar 2021 15:05:15 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LsZld+EO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614693915;\n\tbh=9+yR1OWlHkD6oP/Bt7hpuOUuVDHycBjmJ3/VHdu/gWw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=LsZld+EOJ54G0gxAGNNCBc2YjHmBI8+PmlR0E8vmDfOCZpegB9RORPpnLp7BubQqS\n\t2tLELMVVAd0WQEVdMcTQmsCo3jm3GaQmTGspJIA44RPvdcZA/xj8QHB4x0fUKudJVY\n\tyz/xmrHi6xTtQe/on3pwEDQswWJPYiP0eulUTCT0=","Date":"Tue, 2 Mar 2021 16:04:47 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210302122341.83985-1-kieran.bingham@ideasonboard.com>\n\t<20210302122341.83985-3-kieran.bingham@ideasonboard.com>\n\t\n\t<17734609-20b2-f99c-d10d-b907a6aea907@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<17734609-20b2-f99c-d10d-b907a6aea907@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: pipeline_handler:\n\tUpdate request usage comment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15498,"web_url":"https://patchwork.libcamera.org/comment/15498/","msgid":"","date":"2021-03-06T23:01:46","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: pipeline_handler:\n\tUpdate request usage comment","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nOn 2021-03-02 12:23:41 +0000, Kieran Bingham wrote:\n> When a pipeline handler completes a request, the request itself is not\n> deleted by libcamera, and the application regains control over the\n> object. It may choose to delete the Request, or re-use it.\n> \n> Clarify this in the comment by removing the declaration that the Request\n> is deleted, but state that it is no longer managed by the pipeline\n> handler and must not be accessed further after this function returns.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline_handler.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index aff83af2e90e..0255d9476de0 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -432,8 +432,8 @@ bool PipelineHandler::completeBuffer(Request *request, FrameBuffer *buffer)\n> * \\param[in] request The request that has completed\n> *\n> * The pipeline handler shall call this method to notify the \\a camera that the\n> - * request has completed. The request is deleted and shall not be accessed once\n> - * this method returns.\n> + * request has completed. The request is no longer managed by the pipeline\n> + * handler and shall not be accessed once this method returns.\n> *\n> * This method ensures that requests will be returned to the application in\n> * submission order, the pipeline handler may call it on any complete request\n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2945ABD1F1\n\tfor ;\n\tSat, 6 Mar 2021 23:01:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D739368A99;\n\tSun, 7 Mar 2021 00:01:49 +0100 (CET)","from mail-lf1-x136.google.com (mail-lf1-x136.google.com\n\t[IPv6:2a00:1450:4864:20::136])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4A3D5602E8\n\tfor ;\n\tSun, 7 Mar 2021 00:01:48 +0100 (CET)","by mail-lf1-x136.google.com with SMTP id k9so12910723lfo.12\n\tfor ;\n\tSat, 06 Mar 2021 15:01:48 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\ty10sm825023ljn.103.2021.03.06.15.01.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 06 Mar 2021 15:01:47 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"pbtiJamF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=ZgnJU1+oSG589g9yPrUj2QYC1j7kfdm3/vpt7JIehBs=;\n\tb=pbtiJamFiCr/n9XyYGnlpZikRC5MXAdUFAFQuHo9/8C1HPor8IIJvgoYFGEHuxZ+EF\n\t7wFdn4aB0EKeo8QjIz1Y7fjXuX9W/u712nAKlM0ckA49I1hIESaJNX4RWRar3hkVKyin\n\taPDV27HySNECir3yw5+tlDMm9p5yLDS3gETvrfasJ2KuI4fZ0Vqfq9zUJgSqp1ZDXMNh\n\twrBGQ0RsWWAFeUygM9NL2sdsckL9CpglvxyYu5coNIYnSYUpvpmLaNDYdph+QGkyNtB/\n\ttle+J2VUi9aZjC0VEa0eJIwt78a7AR3twkXxg5YzSI72KLgUUGGgStAoXweTNi/4Z3DP\n\t+ndQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=ZgnJU1+oSG589g9yPrUj2QYC1j7kfdm3/vpt7JIehBs=;\n\tb=aZsgiqyGtIsEi3R+BlJZXwGBKqy7owq7go9GzwLFdw+cOMzloMOS9My5B3FBxyNftZ\n\t0sod6PaAt7BMyI3Fzh5kXJTDjtSVlQhtaoaFPQOAPj5T09xvncWX6AvP0fYBVP4fo1ig\n\tfNWcat7+d7JriUK4GQFWVEthsSSaz+hYBrT7qA8c275pdxl6gpwf47sPNc1Zv3dmhwGb\n\tlk9zIzGlptsVyeV5joRo3avi+FzxAgiMqlOSb8IMX3l3CwLV/CXzk65v3lz5OWWvAxFD\n\tDHrNpvzfWXZGluAuLFEN1hRXfAbJqG2Wt0zoKxrt3kJKUUH2KGLaR7RecxfqfrTTKZfL\n\tuSvw==","X-Gm-Message-State":"AOAM530Qd/UcGDN+PIW0x4GnnSgx6yglKVqP24XjFF5nv0g52SaVUu6n\n\tX+EtEqZs/30VlUpk1RslT/uAeA==","X-Google-Smtp-Source":"ABdhPJz2dKxjFiA9IiqPdSyfInzknj9rTq7cIIQVMFoadnRKIPWZ+c80vU32e2Rf9Lit3lb0iTmU5Q==","X-Received":"by 2002:a05:6512:2026:: with SMTP id\n\ts6mr9612588lfs.43.1615071707793; \n\tSat, 06 Mar 2021 15:01:47 -0800 (PST)","Date":"Sun, 7 Mar 2021 00:01:46 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Message-ID":"","References":"<20210302122341.83985-1-kieran.bingham@ideasonboard.com>\n\t<20210302122341.83985-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210302122341.83985-3-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: pipeline_handler:\n\tUpdate request usage comment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]