[{"id":15367,"web_url":"https://patchwork.libcamera.org/comment/15367/","msgid":"","date":"2021-03-01T23:07:29","subject":"Re: [libcamera-devel] [PATCH 01/10] meson: options: Add option to\n\tselect the Android platform","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Mon, Mar 01, 2021 at 04:01:02PM +0100, Jacopo Mondi wrote:\n> The Android Camera3 HAL implementation requires platform\n> specific extensions, such as the selection of the memory backend\n> to use and additional constraints depending on the target device.\n> \n> Define a combo option to select which platform to target and\n> define the currently existing implementation as 'generic'.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> meson_options.txt | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n> diff --git a/meson_options.txt b/meson_options.txt\n> index 53f2675e99e2..d840543b01f5 100644\n> --- a/meson_options.txt\n> +++ b/meson_options.txt\n> @@ -5,6 +5,12 @@ option('android',\n> value : 'disabled',\n> description : 'Compile libcamera with Android Camera3 HAL interface')\n> \n> +option('android_platform',\n> + type : 'combo',\n> + choices : ['generic'],\n> + value : 'generic',\n> + description : 'Select the Android platform to compile for')\n> +\n> option('documentation',\n> type : 'feature',\n> description : 'Generate the project documentation')","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8C7F8BD1F1\n\tfor ;\n\tMon, 1 Mar 2021 23:08:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 158ED68A86;\n\tTue, 2 Mar 2021 00:08:00 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D0A2568A45\n\tfor ;\n\tTue, 2 Mar 2021 00:07:57 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3619A45D;\n\tTue, 2 Mar 2021 00:07:57 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"A9bvGUVo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614640077;\n\tbh=svBtgvVLHzg+NNxnGpTizMHf+xGJE5IwZ4wlc5LKI20=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=A9bvGUVomsyXj/tWcoH5bqxTy5rn6IbjGjCaIXX8s2yBwF6g2IIMigIm7PzjDV2Fu\n\tgg6s/VSshkqmpNwuXy/q7b4KvnzAUIiXszLy2YJVjyYW0FTL04fMFIiXENNrbwjNog\n\taed2gB/I1zHuBASfqEogTgdfIg4Oft/k1w3UGAL4=","Date":"Tue, 2 Mar 2021 01:07:29 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210301150111.61791-1-jacopo@jmondi.org>\n\t<20210301150111.61791-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210301150111.61791-2-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 01/10] meson: options: Add option to\n\tselect the Android platform","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Han-lin Chen ,\n\tlibcamera-devel@lists.libcamera.org, Daniel Hung-yu Wu ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15398,"web_url":"https://patchwork.libcamera.org/comment/15398/","msgid":"<20210302095438.GG35047@pyrite.rasen.tech>","date":"2021-03-02T09:54:38","subject":"Re: [libcamera-devel] [PATCH 01/10] meson: options: Add option to\n\tselect the Android platform","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Mon, Mar 01, 2021 at 04:01:02PM +0100, Jacopo Mondi wrote:\n> The Android Camera3 HAL implementation requires platform\n> specific extensions, such as the selection of the memory backend\n> to use and additional constraints depending on the target device.\n> \n> Define a combo option to select which platform to target and\n> define the currently existing implementation as 'generic'.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Paul Elder \n\n> ---\n> meson_options.txt | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n> diff --git a/meson_options.txt b/meson_options.txt\n> index 53f2675e99e2..d840543b01f5 100644\n> --- a/meson_options.txt\n> +++ b/meson_options.txt\n> @@ -5,6 +5,12 @@ option('android',\n> value : 'disabled',\n> description : 'Compile libcamera with Android Camera3 HAL interface')\n> \n> +option('android_platform',\n> + type : 'combo',\n> + choices : ['generic'],\n> + value : 'generic',\n> + description : 'Select the Android platform to compile for')\n> +\n> option('documentation',\n> type : 'feature',\n> description : 'Generate the project documentation')\n> -- \n> 2.30.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A5D73BD1F1\n\tfor ;\n\tTue, 2 Mar 2021 09:54:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3626468A95;\n\tTue, 2 Mar 2021 10:54:47 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4DFA160106\n\tfor ;\n\tTue, 2 Mar 2021 10:54:46 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3AE6445D;\n\tTue, 2 Mar 2021 10:54:43 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"W+76SkTM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614678885;\n\tbh=0wb9pnns8r3pw7OsQaQOkfUeFDbrKGACFviQiaQCPDI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=W+76SkTMtqkKXlEMbKQPRSeJJksw7E0ZfQcsMliqdJn7rF7muI9CCmGnB+G4vREZ5\n\tdx/8TKc7XgfTqqMamX2wMuQcQFiP2Cv6+QX32OhBfD2RFMkCuj/8jxP5mbZ+4S/dyK\n\tYaW6k+aDVwanW1gn8FmySTJUqdSO74+VYe07Xlfc=","Date":"Tue, 2 Mar 2021 18:54:38 +0900","From":"paul.elder@ideasonboard.com","To":"Jacopo Mondi ","Message-ID":"<20210302095438.GG35047@pyrite.rasen.tech>","References":"<20210301150111.61791-1-jacopo@jmondi.org>\n\t<20210301150111.61791-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210301150111.61791-2-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 01/10] meson: options: Add option to\n\tselect the Android platform","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Han-lin Chen ,\n\tlibcamera-devel@lists.libcamera.org, Daniel Hung-yu Wu ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]