[{"id":1543,"web_url":"https://patchwork.libcamera.org/comment/1543/","msgid":"<20190430185140.GP16573@bigcity.dyn.berto.se>","date":"2019-04-30T18:51:40","subject":"Re: [libcamera-devel] [PATCH 1/5] libcamera: pipeline_handler:\n\tRemove duplicated log from uvc and vimc","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-04-30 21:37:42 +0300, Laurent Pinchart wrote:\n> The uvcvideo and vimc pipeline handlers print the requested resolution\n> in their configureStreams() operation. This duplicates a generic log\n> statement in the Camera::configureStreams() method, remove it.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/uvcvideo.cpp | 3 ---\n> src/libcamera/pipeline/vimc.cpp | 3 ---\n> 2 files changed, 6 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo.cpp\n> index 2f9b5e0fdc08..fd1d6df177d9 100644\n> --- a/src/libcamera/pipeline/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo.cpp\n> @@ -109,9 +109,6 @@ int PipelineHandlerUVC::configureStreams(Camera *camera,\n> \tconst StreamConfiguration *cfg = &config[&data->stream_];\n> \tint ret;\n> \n> -\tLOG(UVC, Debug) << \"Configure the camera for resolution \"\n> -\t\t\t<< cfg->width << \"x\" << cfg->height;\n> -\n> \tV4L2DeviceFormat format = {};\n> \tformat.width = cfg->width;\n> \tformat.height = cfg->height;\n> diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\n> index f70b4d3c6bab..f95140661b2a 100644\n> --- a/src/libcamera/pipeline/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc.cpp\n> @@ -109,9 +109,6 @@ int PipelineHandlerVimc::configureStreams(Camera *camera,\n> \tconst StreamConfiguration *cfg = &config[&data->stream_];\n> \tint ret;\n> \n> -\tLOG(VIMC, Debug) << \"Configure the camera for resolution \"\n> -\t\t\t << cfg->width << \"x\" << cfg->height;\n> -\n> \tV4L2DeviceFormat format = {};\n> \tformat.width = cfg->width;\n> \tformat.height = cfg->height;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com\n\t[IPv6:2a00:1450:4864:20::22f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 578CC60E5B\n\tfor ;\n\tTue, 30 Apr 2019 20:51:42 +0200 (CEST)","by mail-lj1-x22f.google.com with SMTP id k8so13771830lja.8\n\tfor ;\n\tTue, 30 Apr 2019 11:51:42 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tv14sm5037037ljj.44.2019.04.30.11.51.40\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 30 Apr 2019 11:51:40 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=g9+kpeyNaoBrf2X84ALxfHQINRtgovsY6bxMueD8S1Q=;\n\tb=RVE2R7DTb4+kS6tH7PcMdAEZ/nmsXlWoj9Jhx4hnxdFalvvI3ARm5K5QZKJNm3gapH\n\teb0PE7ViY2Wg+5itMZ8Ei20HjWX36RR/bqJjMCaESETJs4avSYTxaZ0HaY64H128Zsx+\n\tgU8DiJZqdjPPmszteQ40d3l5/u4UPr/Zw4RxZabVq6hMA1DVhU3M+wNQivlJVqkEejM1\n\tuB8sz1rmEdtUITi6vvdKD98npc3c+79b1FWIlzpvo6FPWhBUVmzukLM3EkayY+ZEiBPY\n\taCWw6k9/69dQQJk15rzSXGznAsHeb3ZDqIak9xf5Cf0EqXAENl/jCXdTRYAkFq26Nagh\n\t3hFg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=g9+kpeyNaoBrf2X84ALxfHQINRtgovsY6bxMueD8S1Q=;\n\tb=sv50uEqGEuLIxn6dbovU7VzHESr/HcpKomm2HCY9SguLeBwaBc5JPfunxDFl87QhOH\n\tS/DJHfzKso2O98tO/6SAxxXA2Uy1fwKd1AqZSlsH6cbFF9FspNjg/HaKNlgdaju+8+y5\n\tGl01HiI/HTW/N7HmGibZzZyV77gI9q/KdmMNMLC7dm1zkzEDDvlnmFIvnbaBw78o6UfR\n\tnkRhPr9NF53uPBdGrU1xmGzAbegZ1WIUcLPBjFBaTzNDyXyxF0+caF29PFgOGKLw8Ifu\n\tDh3bO6pxfvnx4gaF8lfthxydSzqPLpV5003MuzG1aycvWWoewXLyZWhB4ntGiu3pqtva\n\tJA9Q==","X-Gm-Message-State":"APjAAAUR0gnV98N+X526gbPf/7/X47Uqwm6Fe2yjJKFkPobHbkywlfgJ\n\tfpVTk4HNnsjP4l98yBSQHl22iA3/cFw=","X-Google-Smtp-Source":"APXvYqwyDc2PTUkKgqTZ6HdbP9sQz8irmkEmKkJ7MBKYs9hdjF1vPPqqG1Cqqv80+oqV4yearQz9Ww==","X-Received":"by 2002:a2e:9155:: with SMTP id\n\tq21mr23973679ljg.178.1556650301588; \n\tTue, 30 Apr 2019 11:51:41 -0700 (PDT)","Date":"Tue, 30 Apr 2019 20:51:40 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190430185140.GP16573@bigcity.dyn.berto.se>","References":"<20190430183746.28518-1-laurent.pinchart@ideasonboard.com>\n\t<20190430183746.28518-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190430183746.28518-2-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.11.3 (2019-02-01)","Subject":"Re: [libcamera-devel] [PATCH 1/5] libcamera: pipeline_handler:\n\tRemove duplicated log from uvc and vimc","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 30 Apr 2019 18:51:42 -0000"}}]