[{"id":15338,"web_url":"https://patchwork.libcamera.org/comment/15338/","msgid":"","date":"2021-02-28T18:50:34","subject":"Re: [libcamera-devel] [PATCH 10/12] meson: options: Introduce\n\t'cros_cbm' memory backend","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Fri, Feb 26, 2021 at 02:29:30PM +0100, Jacopo Mondi wrote:\n> Add to the list of supported memory backends the 'cros_cbm' option.\n> \n> Signed-off-by: Jacopo Mondi \n\nYou can squash this with 11/12, or we'll have a bisection point where\ncros_cbm could be selected and compilation would fail.\n\n> ---\n> meson_options.txt | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/meson_options.txt b/meson_options.txt\n> index 34063172f4ba..c43def09fe80 100644\n> --- a/meson_options.txt\n> +++ b/meson_options.txt\n> @@ -12,7 +12,7 @@ option('cros',\n> \n> option('android_memory_backend',\n> type : 'combo',\n> - choices : ['android_generic'],\n> + choices : ['android_generic', 'cros_cbm'],\n> value : 'android_generic',\n> description : 'Select the memory backend in use for the Android Camera3 HAL')\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 31BF9BD1F1\n\tfor ;\n\tSun, 28 Feb 2021 18:51:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B8E3D68A7C;\n\tSun, 28 Feb 2021 19:51:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 60EA868A45\n\tfor ;\n\tSun, 28 Feb 2021 19:51:03 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C81DD80F;\n\tSun, 28 Feb 2021 19:51:02 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EYs4SQG7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614538263;\n\tbh=v7ZYphiIdOmiZ1c2cwfb4gkFrAs2XHzmcT+UR0P5dpk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EYs4SQG7I9cuTP2rph19Bc9R63BzjwojlZfRVhmicc0dSY6d22wl9pDZCMn0d6JFS\n\tgX+zPw2qZeN3Cg89mwkr7aNnActaPaF06Qg2rjVu3HDB59rDqsCyN0tDDyMZ+4/IyQ\n\tBIPcPpAIVTaiVth4XkgYE5r0Hs9iKbHoXFd7rGXU=","Date":"Sun, 28 Feb 2021 20:50:34 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210226132932.165484-1-jacopo@jmondi.org>\n\t<20210226132932.165484-11-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210226132932.165484-11-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 10/12] meson: options: Introduce\n\t'cros_cbm' memory backend","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]