[{"id":15330,"web_url":"https://patchwork.libcamera.org/comment/15330/","msgid":"","date":"2021-02-28T18:15:44","subject":"Re: [libcamera-devel] [PATCH 01/12] meson: options: Add an option\n\tto select Android memory backend","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Fri, Feb 26, 2021 at 02:29:21PM +0100, Jacopo Mondi wrote:\n> The Android Camera3 HAL implementation interfaces with platform\n> specific implementations of the memory management infrastructure.\n> \n> On regular Android systems it is usually a vendor specific\n> implementation of the gralloc framework, on Chromium OS memory\n> is managed through the system-specific libcbm implementation and\n> so far the only supported backend was a generic implementation that\n> relies on the Linux kernel primitives to access memory buffer.\n> \n> Define a combo option to select which memory backend to use and\n> define the currently existing implementation as 'android_generic'.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> meson_options.txt | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n> diff --git a/meson_options.txt b/meson_options.txt\n> index 22efb3235c19..34063172f4ba 100644\n> --- a/meson_options.txt\n> +++ b/meson_options.txt\n> @@ -10,6 +10,12 @@ option('cros',\n> value : 'false',\n> description : 'Compile libcamera with the cros Camera3 HAL interface (depends on android option)')\n> \n> +option('android_memory_backend',\n> + type : 'combo',\n> + choices : ['android_generic'],\n> + value : 'android_generic',\n> + description : 'Select the memory backend in use for the Android Camera3 HAL')\n\nSame comment as on \"[PATCH 1/3] meson: Add cros build option\", could we\nmerge android_memory_backend and cros into a single android_platform\noption ?\n\n> +\n> option('documentation',\n> type : 'feature',\n> description : 'Generate the project documentation')","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B327EBD1F1\n\tfor ;\n\tSun, 28 Feb 2021 18:16:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3516368A45;\n\tSun, 28 Feb 2021 19:16:15 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E6BB968A45\n\tfor ;\n\tSun, 28 Feb 2021 19:16:13 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4960480F;\n\tSun, 28 Feb 2021 19:16:13 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uGT1AEGY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614536173;\n\tbh=KJteFiRxcYQPKvGa8qutKufqZFcvRjw8fG6/7U95nIw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=uGT1AEGYlItnQzu3tq23m8laIczreiejKc1DMgEDPe3B/W5BE5Na06ty2ipXSuBzu\n\tK4JuOQ8YbUSgnj15SHah8/56qySKsBkD921FOprn9tzeJqyAnjObqWejJvRmipn4Ww\n\tmLfhoinfWUmpFRtczLwafIf6mG76ysfOAeFwRqks=","Date":"Sun, 28 Feb 2021 20:15:44 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210226132932.165484-1-jacopo@jmondi.org>\n\t<20210226132932.165484-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210226132932.165484-2-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 01/12] meson: options: Add an option\n\tto select Android memory backend","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]