[{"id":15428,"web_url":"https://patchwork.libcamera.org/comment/15428/","msgid":"","date":"2021-03-02T19:52:53","subject":"Re: [libcamera-devel] [PATCH v2 1/3] libcamera: media_device: add\n\thwRevision method","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Dafna,\n\nThank you for the patch.\n\nOn Thu, Feb 25, 2021 at 06:12:03PM +0100, Dafna Hirschfeld wrote:\n> Add a method 'hwRevision' to return the\n> info.hw_version reported by the driver.\n\nThe code looks fine, but documentation for the new function is missing.\nDidn't doxygen warn you ?\n\n> Signed-off-by: Dafna Hirschfeld \n> Reviewed-by: Paul Elder \n> ---\n> include/libcamera/internal/media_device.h | 2 ++\n> src/libcamera/media_device.cpp | 1 +\n> 2 files changed, 3 insertions(+)\n> \n> diff --git a/include/libcamera/internal/media_device.h b/include/libcamera/internal/media_device.h\n> index d0459cde..c3292508 100644\n> --- a/include/libcamera/internal/media_device.h\n> +++ b/include/libcamera/internal/media_device.h\n> @@ -41,6 +41,7 @@ public:\n> \tconst std::string deviceNode() const { return deviceNode_; }\n> \tconst std::string model() const { return model_; }\n> \tunsigned int version() const { return version_; }\n> +\tunsigned int hwRevision() const { return hwRevision_; }\n> \n> \tconst std::vector &entities() const { return entities_; }\n> \tMediaEntity *getEntityByName(const std::string &name) const;\n> @@ -79,6 +80,7 @@ private:\n> \tstd::string deviceNode_;\n> \tstd::string model_;\n> \tunsigned int version_;\n> +\tunsigned int hwRevision_;\n> \n> \tint fd_;\n> \tbool valid_;\n> diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\n> index de18d572..ec964948 100644\n> --- a/src/libcamera/media_device.cpp\n> +++ b/src/libcamera/media_device.cpp\n> @@ -231,6 +231,7 @@ int MediaDevice::populate()\n> \tdriver_ = info.driver;\n> \tmodel_ = info.model;\n> \tversion_ = info.media_version;\n> +\thwRevision_ = info.hw_revision;\n> \n> \t/*\n> \t * Keep calling G_TOPOLOGY until the version number stays stable.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DF453BD808\n\tfor ;\n\tTue, 2 Mar 2021 19:53:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6915668A98;\n\tTue, 2 Mar 2021 20:53:24 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 776F060106\n\tfor ;\n\tTue, 2 Mar 2021 20:53:22 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D6D9845D;\n\tTue, 2 Mar 2021 20:53:21 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VHzHGMjr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614714802;\n\tbh=BfSItGTco/hVvjUhNRohWZWsZDJAT1tX8M4Wft/Ubkc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=VHzHGMjrvu73fymXbduGY85KOzBdonMIVkUV3ZRZhtm0B33BtAhQwzTlz1FLPse4H\n\tRh1L8dJcaa1s7JkASMf+acxIA2ZB5YtU3QVEJQDyF4flpKyVl3ZLW4dPhkwkckODL7\n\tjC0PtsoqjDkSJfnhhcGm3hLzkCvVpS1tCsz7ohPs=","Date":"Tue, 2 Mar 2021 21:52:53 +0200","From":"Laurent Pinchart ","To":"Dafna Hirschfeld ","Message-ID":"","References":"<20210225171205.23341-1-dafna.hirschfeld@collabora.com>\n\t<20210225171205.23341-2-dafna.hirschfeld@collabora.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210225171205.23341-2-dafna.hirschfeld@collabora.com>","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] libcamera: media_device: add\n\thwRevision method","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org, kernel@collabora.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15487,"web_url":"https://patchwork.libcamera.org/comment/15487/","msgid":"<29a77773-111c-9db5-2dd9-5ea79ea76924@collabora.com>","date":"2021-03-05T09:30:11","subject":"Re: [libcamera-devel] [PATCH v2 1/3] libcamera: media_device: add\n\thwRevision method","submitter":{"id":46,"url":"https://patchwork.libcamera.org/api/people/46/","name":"Dafna Hirschfeld","email":"dafna.hirschfeld@collabora.com"},"content":"On 02.03.21 20:52, Laurent Pinchart wrote:\n> Hi Dafna,\n> \n> Thank you for the patch.\n> \n> On Thu, Feb 25, 2021 at 06:12:03PM +0100, Dafna Hirschfeld wrote:\n>> Add a method 'hwRevision' to return the\n>> info.hw_version reported by the driver.\n> \n> The code looks fine, but documentation for the new function is missing.\n> Didn't doxygen warn you ?\n\nOh, it did indeed, missed that\n\nThanks,\nDafna\n\n> \n>> Signed-off-by: Dafna Hirschfeld \n>> Reviewed-by: Paul Elder \n>> ---\n>> include/libcamera/internal/media_device.h | 2 ++\n>> src/libcamera/media_device.cpp | 1 +\n>> 2 files changed, 3 insertions(+)\n>>\n>> diff --git a/include/libcamera/internal/media_device.h b/include/libcamera/internal/media_device.h\n>> index d0459cde..c3292508 100644\n>> --- a/include/libcamera/internal/media_device.h\n>> +++ b/include/libcamera/internal/media_device.h\n>> @@ -41,6 +41,7 @@ public:\n>> \tconst std::string deviceNode() const { return deviceNode_; }\n>> \tconst std::string model() const { return model_; }\n>> \tunsigned int version() const { return version_; }\n>> +\tunsigned int hwRevision() const { return hwRevision_; }\n>> \n>> \tconst std::vector &entities() const { return entities_; }\n>> \tMediaEntity *getEntityByName(const std::string &name) const;\n>> @@ -79,6 +80,7 @@ private:\n>> \tstd::string deviceNode_;\n>> \tstd::string model_;\n>> \tunsigned int version_;\n>> +\tunsigned int hwRevision_;\n>> \n>> \tint fd_;\n>> \tbool valid_;\n>> diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\n>> index de18d572..ec964948 100644\n>> --- a/src/libcamera/media_device.cpp\n>> +++ b/src/libcamera/media_device.cpp\n>> @@ -231,6 +231,7 @@ int MediaDevice::populate()\n>> \tdriver_ = info.driver;\n>> \tmodel_ = info.model;\n>> \tversion_ = info.media_version;\n>> +\thwRevision_ = info.hw_revision;\n>> \n>> \t/*\n>> \t * Keep calling G_TOPOLOGY until the version number stays stable.\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 40FDABD80C\n\tfor ;\n\tFri, 5 Mar 2021 09:30:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C33EE68A92;\n\tFri, 5 Mar 2021 10:30:25 +0100 (CET)","from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3BB1E602E8\n\tfor ;\n\tFri, 5 Mar 2021 10:30:24 +0100 (CET)","from [IPv6:2003:c7:cf38:3800:8df:3f9b:2ff1:d151]\n\t(p200300c7cf38380008df3f9b2ff1d151.dip0.t-ipconnect.de\n\t[IPv6:2003:c7:cf38:3800:8df:3f9b:2ff1:d151])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits))\n\t(No client certificate requested) (Authenticated sender: dafna)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id B64D91F46894;\n\tFri, 5 Mar 2021 09:30:23 +0000 (GMT)"],"To":"Laurent Pinchart ","References":"<20210225171205.23341-1-dafna.hirschfeld@collabora.com>\n\t<20210225171205.23341-2-dafna.hirschfeld@collabora.com>\n\t","From":"Dafna Hirschfeld ","Message-ID":"<29a77773-111c-9db5-2dd9-5ea79ea76924@collabora.com>","Date":"Fri, 5 Mar 2021 10:30:11 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v2 1/3] libcamera: media_device: add\n\thwRevision method","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org, kernel@collabora.com","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]