[{"id":15324,"web_url":"https://patchwork.libcamera.org/comment/15324/","msgid":"","date":"2021-02-26T08:05:33","subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: raspberrypi: AWB: Ignore\n\tinvalid statistics zones correctly","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nThank you for your patch.\n\nOn Thu, 25 Feb 2021 at 17:01, David Plowman \nwrote:\n\n> Regions of the image where the statistics are not trusted should not\n> be put in the zones_ list.\n>\n> This also means that the AWB may fail to run initially, so\n> async_results_ needs to be initialised to some kind of default.\n>\n> Finally, the RGB zone structures can be zero-initialised safely now,\n> the previous value of -1 would seem unusual.\n>\n> Signed-off-by: David Plowman \n>\n\nReviewed-by: Naushir Patuck \n\n\n> ---\n> src/ipa/raspberrypi/controller/rpi/awb.cpp | 3 ++-\n> src/ipa/raspberrypi/controller/rpi/awb.hpp | 2 +-\n> 2 files changed, 3 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> b/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> index 791a7039..1c917e4f 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> @@ -169,6 +169,7 @@ void Awb::Initialise()\n> sync_results_.gain_b = 1.0;\n> }\n> prev_sync_results_ = sync_results_;\n> + async_results_ = sync_results_;\n> }\n>\n> unsigned int Awb::GetConvergenceFrames() const\n> @@ -345,9 +346,9 @@ static void generate_stats(std::vector\n> &zones,\n> if (zone.G >= min_G) {\n> zone.R = stats[i].r_sum / counted;\n> zone.B = stats[i].b_sum / counted;\n> + zones.push_back(zone);\n> }\n> }\n> - zones.push_back(zone);\n> }\n> }\n>\n> diff --git a/src/ipa/raspberrypi/controller/rpi/awb.hpp\n> b/src/ipa/raspberrypi/controller/rpi/awb.hpp\n> index 2fe59c37..8af1f27c 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/awb.hpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/awb.hpp\n> @@ -90,7 +90,7 @@ public:\n> void Prepare(Metadata *image_metadata) override;\n> void Process(StatisticsPtr &stats, Metadata *image_metadata)\n> override;\n> struct RGB {\n> - RGB(double _R = -1.0, double _G = -1.0, double _B = -1.0)\n> + RGB(double _R = 0, double _G = 0, double _B = 0)\n> : R(_R), G(_G), B(_B)\n> {\n> }\n> --\n> 2.20.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F32D0BD1F1\n\tfor ;\n\tFri, 26 Feb 2021 08:05:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C180B68A60;\n\tFri, 26 Feb 2021 09:05:52 +0100 (CET)","from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com\n\t[IPv6:2a00:1450:4864:20::22c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B5372689DD\n\tfor ;\n\tFri, 26 Feb 2021 09:05:50 +0100 (CET)","by mail-lj1-x22c.google.com with SMTP id h4so9419305ljl.0\n\tfor ;\n\tFri, 26 Feb 2021 00:05:50 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"a0JNZOB3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=yomcHtNg/QlmT+B8LwQxt4oS8gD0NVsLFfr/OJpGTNc=;\n\tb=a0JNZOB3QG5NZ9kUsYDWpuS0T5RGt2//sCqXXjSre7/CJKrZYm3xeUsft/weeiK2Mq\n\t+Sva7NRCgnZNNbXcVJ3FwPMDDCk1QyVUo4iJa/ALJDd1Xp7vZfXzPWc7Ca44DtB9DbSz\n\tY5wv8ES9roHYROo9Gzsj/ceIHjEtRo+mU/yTal8Pzu5m8I08UpXNWdEeVVDEqMEGzGpV\n\trPqbadwCeKl/kFZsECYjdwGVaNaIPNt659hesMEiT9SxSSq3VN8dMOIcQ7JyaYDVBXFY\n\tMBkqQNw5VFinpEIxTrC31czOnfOuKlSS4iGoQRvKZF67qdOPtxubxQpe6inhjBqTPhAH\n\tVhYQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=yomcHtNg/QlmT+B8LwQxt4oS8gD0NVsLFfr/OJpGTNc=;\n\tb=YaQweDOap56tM3v834Ab4l21ZAKdaXD0tj2mAP3yDsRGVAkvl9EBl6BahlVE3lHATs\n\t9aZtkd18bFD5QUvCKomt1fyXvPpK2dYysMn7cmm9qN9wgNb7g+RLW5d8MfOsq5z+PRj0\n\tQoBWvEkWfzW53TgSWkdsh+3+OEP39E/A/iskKuAKkEcmEWRmVQ5ErdbCsBKX92qhHQEH\n\t+1J4fDVPeWD0cGjl6LYql3LMi913hZLu2YIKjfklLTFXlU1MnuqUsAXpWuRFjs89Cn/k\n\tqvRShUh+reZYUGBV24wYFWuuYmH5jkb0YmoqeNWTuuf3AwQ/Gu0OAowMefOBrY1o/bMO\n\tIuaw==","X-Gm-Message-State":"AOAM530Whf9qZ/WPuuGNha82cRIeTZXaGGYC5EGGMy9n+tzmWnXWcsIU\n\toziuyL/4xIx/+04wiDnw8LYkFGnGTzjQxRDlryH2HvFQMdvcfue7","X-Google-Smtp-Source":"ABdhPJzZkphYF0wD6B1ZHwiKieUnUTra4S++o8kVqls/jsJaKiaPfyo4xXGHq1hieDPGzHn+Ga+6bNNet5Ipe1Y5/Q4=","X-Received":"by 2002:a2e:534a:: with SMTP id\n\tt10mr1029979ljd.499.1614326750274; \n\tFri, 26 Feb 2021 00:05:50 -0800 (PST)","MIME-Version":"1.0","References":"<20210225170141.5184-1-david.plowman@raspberrypi.com>\n\t<20210225170141.5184-3-david.plowman@raspberrypi.com>","In-Reply-To":"<20210225170141.5184-3-david.plowman@raspberrypi.com>","From":"Naushir Patuck ","Date":"Fri, 26 Feb 2021 08:05:33 +0000","Message-ID":"","To":"David Plowman ","Subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: raspberrypi: AWB: Ignore\n\tinvalid statistics zones correctly","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============5598960056031435210==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15326,"web_url":"https://patchwork.libcamera.org/comment/15326/","msgid":"<18681697-5e8a-63ae-4675-46e89d0c9085@ideasonboard.com>","date":"2021-02-26T10:06:53","subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: raspberrypi: AWB: Ignore\n\tinvalid statistics zones correctly","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi David,\n\nOn 25/02/2021 17:01, David Plowman wrote:\n> Regions of the image where the statistics are not trusted should not\n> be put in the zones_ list.\n> \n> This also means that the AWB may fail to run initially, so\n> async_results_ needs to be initialised to some kind of default.\n> \n> Finally, the RGB zone structures can be zero-initialised safely now,\n> the previous value of -1 would seem unusual.\n> \n> Signed-off-by: David Plowman \n\nSounds and looks reasonable to me. I'll run through the compile checks\nand integrate.\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/raspberrypi/controller/rpi/awb.cpp | 3 ++-\n> src/ipa/raspberrypi/controller/rpi/awb.hpp | 2 +-\n> 2 files changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/controller/rpi/awb.cpp b/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> index 791a7039..1c917e4f 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> @@ -169,6 +169,7 @@ void Awb::Initialise()\n> \t\t\tsync_results_.gain_b = 1.0;\n> \t}\n> \tprev_sync_results_ = sync_results_;\n> +\tasync_results_ = sync_results_;\n> }\n> \n> unsigned int Awb::GetConvergenceFrames() const\n> @@ -345,9 +346,9 @@ static void generate_stats(std::vector &zones,\n> \t\t\tif (zone.G >= min_G) {\n> \t\t\t\tzone.R = stats[i].r_sum / counted;\n> \t\t\t\tzone.B = stats[i].b_sum / counted;\n> +\t\t\t\tzones.push_back(zone);\n> \t\t\t}\n> \t\t}\n> -\t\tzones.push_back(zone);\n> \t}\n> }\n> \n> diff --git a/src/ipa/raspberrypi/controller/rpi/awb.hpp b/src/ipa/raspberrypi/controller/rpi/awb.hpp\n> index 2fe59c37..8af1f27c 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/awb.hpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/awb.hpp\n> @@ -90,7 +90,7 @@ public:\n> \tvoid Prepare(Metadata *image_metadata) override;\n> \tvoid Process(StatisticsPtr &stats, Metadata *image_metadata) override;\n> \tstruct RGB {\n> -\t\tRGB(double _R = -1.0, double _G = -1.0, double _B = -1.0)\n> +\t\tRGB(double _R = 0, double _G = 0, double _B = 0)\n> \t\t\t: R(_R), G(_G), B(_B)\n> \t\t{\n> \t\t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 944AEBD1F1\n\tfor ;\n\tFri, 26 Feb 2021 10:06:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0368F68A61;\n\tFri, 26 Feb 2021 11:06:58 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 108E9689DD\n\tfor ;\n\tFri, 26 Feb 2021 11:06:57 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 793C7580;\n\tFri, 26 Feb 2021 11:06:56 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DiGJ/dwr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614334016;\n\tbh=pxkYAYbE1msZObIvwAW0Uz9TrBjPifaN9fa0Usrdq70=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=DiGJ/dwrvWLfnzSRYZacDfABc3ztFpcNgjFuPA/v3kFIEr6JLHfhFvL1/gXUqD3mN\n\tligMfKY3uOgoRjOuUywOCBxs5n547IEW/L3bTpojdKNiBlMr/Jdyjv1uV5BZSicbws\n\tb/AYLM02M9DYpdX7/Y0F7F7NXpD54DRk44oTO3zo=","To":"David Plowman ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210225170141.5184-1-david.plowman@raspberrypi.com>\n\t<20210225170141.5184-3-david.plowman@raspberrypi.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<18681697-5e8a-63ae-4675-46e89d0c9085@ideasonboard.com>","Date":"Fri, 26 Feb 2021 10:06:53 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210225170141.5184-3-david.plowman@raspberrypi.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: raspberrypi: AWB: Ignore\n\tinvalid statistics zones correctly","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]