[{"id":15323,"web_url":"https://patchwork.libcamera.org/comment/15323/","msgid":"","date":"2021-02-26T08:05:08","subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: raspberrypi: AWB: Remove\n\tunused code","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nThank you for your patch.\n\nOn Thu, 25 Feb 2021 at 17:01, David Plowman \nwrote:\n\n> Some more code from pre-libcamera versions is removed. There is no\n> functional change.\n>\n> Signed-off-by: David Plowman \n>\n\nReviewed-by: Naushir Patuck \n\n\n> ---\n> src/ipa/raspberrypi/controller/rpi/awb.cpp | 4 +---\n> src/ipa/raspberrypi/controller/rpi/awb.hpp | 7 +------\n> 2 files changed, 2 insertions(+), 9 deletions(-)\n>\n> diff --git a/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> b/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> index bb637f10..791a7039 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> @@ -21,8 +21,6 @@ LOG_DEFINE_CATEGORY(RPiAwb)\n> #define AWB_STATS_SIZE_X DEFAULT_AWB_REGIONS_X\n> #define AWB_STATS_SIZE_Y DEFAULT_AWB_REGIONS_Y\n>\n> -const double Awb::RGB::INVALID = -1.0;\n> -\n> // todo - the locking in this algorithm needs some tidying up as has been\n> done\n> // elsewhere (ALSC and AGC).\n>\n> @@ -340,7 +338,7 @@ static void generate_stats(std::vector\n> &zones,\n> double min_G)\n> {\n> for (int i = 0; i < AWB_STATS_SIZE_X * AWB_STATS_SIZE_Y; i++) {\n> - Awb::RGB zone; // this is \"invalid\", unless R gets\n> overwritten later\n> + Awb::RGB zone;\n> double counted = stats[i].counted;\n> if (counted >= min_pixels) {\n> zone.G = stats[i].g_sum / counted;\n> diff --git a/src/ipa/raspberrypi/controller/rpi/awb.hpp\n> b/src/ipa/raspberrypi/controller/rpi/awb.hpp\n> index 45ba9e25..2fe59c37 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/awb.hpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/awb.hpp\n> @@ -90,21 +90,16 @@ public:\n> void Prepare(Metadata *image_metadata) override;\n> void Process(StatisticsPtr &stats, Metadata *image_metadata)\n> override;\n> struct RGB {\n> - RGB(double _R = INVALID, double _G = INVALID,\n> - double _B = INVALID)\n> + RGB(double _R = -1.0, double _G = -1.0, double _B = -1.0)\n> : R(_R), G(_G), B(_B)\n> {\n> }\n> double R, G, B;\n> - static const double INVALID;\n> - bool Valid() const { return G != INVALID; }\n> - bool Invalid() const { return G == INVALID; }\n> RGB &operator+=(RGB const &other)\n> {\n> R += other.R, G += other.G, B += other.B;\n> return *this;\n> }\n> - RGB Square() const { return RGB(R * R, G * G, B * B); }\n> };\n>\n> private:\n> --\n> 2.20.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 75737BD1F1\n\tfor ;\n\tFri, 26 Feb 2021 08:05:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D738468A60;\n\tFri, 26 Feb 2021 09:05:29 +0100 (CET)","from mail-lj1-x236.google.com (mail-lj1-x236.google.com\n\t[IPv6:2a00:1450:4864:20::236])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 80763689DD\n\tfor ;\n\tFri, 26 Feb 2021 09:05:27 +0100 (CET)","by mail-lj1-x236.google.com with SMTP id r25so8630485ljk.11\n\tfor ;\n\tFri, 26 Feb 2021 00:05:27 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"L9os9hHJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=msUes0SnFZAnLS9kXcRvdtEIu4dex56uvZS4KSjNv0Y=;\n\tb=L9os9hHJapWYS+Gsgf8uuRXunEiJTW6151ZRE+l8wumImIjo86CQjIT2+NXfEM0+e1\n\tXBL3sSFBLfKYJ7+NahAtqd02m+4uFDCbBdVIHvGnhYcxtTUOex59qtzsMpJo+drP6bfg\n\t7S2UVSa6CPV+Yx/207eCXtK+wi97M692H5DhugxCtI9MDg71pBsKp3Ux432GTmb7dPl5\n\tK4gd172fdz/CLX5/ds+5e8bpAE0g9x6YLudcral0+bvfQGWWViFua56EQX+PDIlann9w\n\tVe74MPjDsO5tz7GPr8sRvaXEHCj/Bvteze/diT42itRHT2i7dFmst9xqjRiJnn2Gjt60\n\t8BGQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=msUes0SnFZAnLS9kXcRvdtEIu4dex56uvZS4KSjNv0Y=;\n\tb=iWUL/od4OkX19I5zZoxHvCS8mgj3e+uqXhBWCi+ub4yoFZfxgjFi3bWep8xyo6TE8S\n\tSQMJPAM+3zfwulmcpMIv3fa/U1mp7zA9xuu+C6P2q5OWfRRK457Mrl0HIykhq3tq7LOA\n\tXMqhWjpFrAgsudbdkmo2H+z5gXREh36eMCL5Fx0JxHu0J9mZs+BiVaaIJi6U0m7SSjRj\n\tyJcIlRUKQoWh83r6yVx3ZIitFJBaXHYdgKZrT9+i4XjnS1G6lZxEN2Y5AeAAXs9N3vhw\n\tayHcKb6yEp1qcSGm24abNrKyOm++L2g/J6NlJCBByS5ZkxpM7XoAAIN17gnBtUYpbF7t\n\t3Ysg==","X-Gm-Message-State":"AOAM531l/GUo1tTMe9m33k0ZyBHvOy70gBwr2YjAhBD1y1wTyOnZCXOG\n\tY+q9I5zbjtTeDW7a23A8sUzk76r+XKjgL9NmqFqDpA==","X-Google-Smtp-Source":"ABdhPJwry75A/E5MCdKFM/nDM+EDFr1JFlLKinpNN7OZu8m7teX4CDksQ15OBQcun2c50omi324ZNB0veMOgXvs7Jng=","X-Received":"by 2002:a2e:a58f:: with SMTP id m15mr997362ljp.400.1614326726869;\n\tFri, 26 Feb 2021 00:05:26 -0800 (PST)","MIME-Version":"1.0","References":"<20210225170141.5184-1-david.plowman@raspberrypi.com>\n\t<20210225170141.5184-2-david.plowman@raspberrypi.com>","In-Reply-To":"<20210225170141.5184-2-david.plowman@raspberrypi.com>","From":"Naushir Patuck ","Date":"Fri, 26 Feb 2021 08:05:08 +0000","Message-ID":"","To":"David Plowman ","Subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: raspberrypi: AWB: Remove\n\tunused code","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============6038237560456727947==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15325,"web_url":"https://patchwork.libcamera.org/comment/15325/","msgid":"","date":"2021-02-26T09:50:16","subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: raspberrypi: AWB: Remove\n\tunused code","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi David,\n\nOn 25/02/2021 17:01, David Plowman wrote:\n> Some more code from pre-libcamera versions is removed. There is no\n> functional change.\n\nReviewed-by: Kieran Bingham \n\n> \n> Signed-off-by: David Plowman \n> ---\n> src/ipa/raspberrypi/controller/rpi/awb.cpp | 4 +---\n> src/ipa/raspberrypi/controller/rpi/awb.hpp | 7 +------\n> 2 files changed, 2 insertions(+), 9 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/controller/rpi/awb.cpp b/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> index bb637f10..791a7039 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> @@ -21,8 +21,6 @@ LOG_DEFINE_CATEGORY(RPiAwb)\n> #define AWB_STATS_SIZE_X DEFAULT_AWB_REGIONS_X\n> #define AWB_STATS_SIZE_Y DEFAULT_AWB_REGIONS_Y\n> \n> -const double Awb::RGB::INVALID = -1.0;\n> -\n> // todo - the locking in this algorithm needs some tidying up as has been done\n> // elsewhere (ALSC and AGC).\n> \n> @@ -340,7 +338,7 @@ static void generate_stats(std::vector &zones,\n> \t\t\t double min_G)\n> {\n> \tfor (int i = 0; i < AWB_STATS_SIZE_X * AWB_STATS_SIZE_Y; i++) {\n> -\t\tAwb::RGB zone; // this is \"invalid\", unless R gets overwritten later\n> +\t\tAwb::RGB zone;\n> \t\tdouble counted = stats[i].counted;\n> \t\tif (counted >= min_pixels) {\n> \t\t\tzone.G = stats[i].g_sum / counted;\n> diff --git a/src/ipa/raspberrypi/controller/rpi/awb.hpp b/src/ipa/raspberrypi/controller/rpi/awb.hpp\n> index 45ba9e25..2fe59c37 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/awb.hpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/awb.hpp\n> @@ -90,21 +90,16 @@ public:\n> \tvoid Prepare(Metadata *image_metadata) override;\n> \tvoid Process(StatisticsPtr &stats, Metadata *image_metadata) override;\n> \tstruct RGB {\n> -\t\tRGB(double _R = INVALID, double _G = INVALID,\n> -\t\t double _B = INVALID)\n> +\t\tRGB(double _R = -1.0, double _G = -1.0, double _B = -1.0)\n> \t\t\t: R(_R), G(_G), B(_B)\n> \t\t{\n> \t\t}\n> \t\tdouble R, G, B;\n> -\t\tstatic const double INVALID;\n> -\t\tbool Valid() const { return G != INVALID; }\n> -\t\tbool Invalid() const { return G == INVALID; }\n> \t\tRGB &operator+=(RGB const &other)\n> \t\t{\n> \t\t\tR += other.R, G += other.G, B += other.B;\n> \t\t\treturn *this;\n> \t\t}\n> -\t\tRGB Square() const { return RGB(R * R, G * G, B * B); }\n> \t};\n> \n> private:\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BDBA4BD808\n\tfor ;\n\tFri, 26 Feb 2021 09:50:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EF9DB68A60;\n\tFri, 26 Feb 2021 10:50:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 72C50689DD\n\tfor ;\n\tFri, 26 Feb 2021 10:50:21 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B0E0A580;\n\tFri, 26 Feb 2021 10:50:20 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HMyVeXvE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614333021;\n\tbh=NnGM78Tcsv3OdRUfkzsvRVZ+HViA5uHVuzWBqlPff9o=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=HMyVeXvEG47MbOrmor6XNoDvXEEndUjyppzQY4Z7fOTigTw1FdyexrgKK9SoVrpEP\n\twSYaz/nRSsUK9DizV53efO82puWevM6WW2c/qDyGlDzgZTjisrEw+xEiojpg6wG9V3\n\tHfTHFDSkXkIcftkWdBxpH/hg8qeZWeuS8ytr8lnw=","To":"David Plowman ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210225170141.5184-1-david.plowman@raspberrypi.com>\n\t<20210225170141.5184-2-david.plowman@raspberrypi.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Fri, 26 Feb 2021 09:50:16 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210225170141.5184-2-david.plowman@raspberrypi.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: raspberrypi: AWB: Remove\n\tunused code","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]