{"id":1138,"url":"https://patchwork.libcamera.org/api/patches/1138/?format=json","web_url":"https://patchwork.libcamera.org/patch/1138/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190429191729.29697-11-niklas.soderlund@ragnatech.se>","date":"2019-04-29T19:17:28","name":"[libcamera-devel,10/11] libcamera: pipeline_handler: Add functions to lock a whole pipeline","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"6d7d1f61d240773a97adc8aeef611f2ad435703c","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1138/mbox/","series":[{"id":284,"url":"https://patchwork.libcamera.org/api/series/284/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=284","date":"2019-04-29T19:17:18","name":"libcamerea: Add support for exclusive access to cameras between processes","version":1,"mbox":"https://patchwork.libcamera.org/series/284/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1138/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1138/checks/","tags":{},"headers":{"Return-Path":"","Received":["from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B474C60E74\n\tfor ;\n\tMon, 29 Apr 2019 21:17:55 +0200 (CEST)","from wyvern.station (unknown [37.182.44.227])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 7d035941-6ab3-11e9-8e2c-005056917f90;\n\tMon, 29 Apr 2019 21:17:54 +0200 (CEST)"],"X-Halon-ID":"7d035941-6ab3-11e9-8e2c-005056917f90","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 29 Apr 2019 21:17:28 +0200","Message-Id":"<20190429191729.29697-11-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190429191729.29697-1-niklas.soderlund@ragnatech.se>","References":"<20190429191729.29697-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 10/11] libcamera: pipeline_handler: Add\n\tfunctions to lock a whole pipeline","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 29 Apr 2019 19:17:56 -0000"},"content":"Add lock() and unlock() which backed by the MediaDevice implementation\ncan will lock all media devices claimed by a pipeline handler instance.\n\nSigned-off-by: Niklas Söderlund \n---\n src/libcamera/include/pipeline_handler.h | 3 ++\n src/libcamera/pipeline_handler.cpp | 38 ++++++++++++++++++++++++\n 2 files changed, 41 insertions(+)","diff":"diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h\nindex 4c13496246c2251c..019c8f4751a8c2b2 100644\n--- a/src/libcamera/include/pipeline_handler.h\n+++ b/src/libcamera/include/pipeline_handler.h\n@@ -57,6 +57,9 @@ public:\n \tMediaDevice *tryAcquire(DeviceEnumerator *enumerator,\n \t\t\t\tconst DeviceMatch &dm);\n \n+\tbool lock();\n+\tvoid unlock();\n+\n \tvirtual CameraConfiguration\n \tstreamConfiguration(Camera *camera, const std::vector &usages) = 0;\n \tvirtual int configureStreams(Camera *camera, const CameraConfiguration &config) = 0;\ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 702b398a50a18085..119d8980e6fbd75a 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -182,6 +182,44 @@ out:\n \treturn media.get();\n }\n \n+/**\n+ * \\brief Lock all media devices acquired by the pipeline\n+ *\n+ * This method shall not be called from a pipeline handler implementation\n+ * directly, as the Camera handles this on the behalf of the specified\n+ * implementation.\n+ *\n+ * \\return True if the devices could be locked, false otherwise\n+ * \\sa unlock()\n+ * \\sa MediaDevice::lock()\n+ */\n+bool PipelineHandler::lock()\n+{\n+\tfor (std::shared_ptr media : mediaDevices_) {\n+\t\tif (!media->lock()) {\n+\t\t\tunlock();\n+\t\t\treturn false;\n+\t\t}\n+\t}\n+\n+\treturn true;\n+}\n+\n+/**\n+ * \\brief Unlock all media devices acquired by the pipeline\n+ *\n+ * This method shall not be called from a pipeline handler implementation\n+ * directly, as the Camera handles this on the behalf of the specified\n+ * implementation.\n+ *\n+ * \\sa lock()\n+ */\n+void PipelineHandler::unlock()\n+{\n+\tfor (std::shared_ptr media : mediaDevices_)\n+\t\tmedia->unlock();\n+}\n+\n /**\n * \\fn PipelineHandler::streamConfiguration()\n * \\brief Retrieve a group of stream configurations for a specified camera\n","prefixes":["libcamera-devel","10/11"]}