[{"id":15316,"web_url":"https://patchwork.libcamera.org/comment/15316/","msgid":"<5a394324-14b9-6805-e631-c13e7e3f6458@ideasonboard.com>","date":"2021-02-25T14:49:15","subject":"Re: [libcamera-devel] [PATCH 1/3] meson: Add cros build option","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Paul,\n\nOn 25/02/2021 10:42, Paul Elder wrote:\n> Add a cros build option to prepare for adding the symbols required for\n> the new cros camera API.\n> \n> Signed-off-by: Paul Elder \n> ---\n> meson_options.txt | 5 +++++\n> src/android/meson.build | 5 +++++\n> 2 files changed, 10 insertions(+)\n> \n> diff --git a/meson_options.txt b/meson_options.txt\n> index 53f2675e..22efb323 100644\n> --- a/meson_options.txt\n> +++ b/meson_options.txt\n> @@ -5,6 +5,11 @@ option('android',\n> value : 'disabled',\n> description : 'Compile libcamera with Android Camera3 HAL interface')\n> \n> +option('cros',\n> + type : 'boolean',\n> + value : 'false',\n> + description : 'Compile libcamera with the cros Camera3 HAL interface (depends on android option)')\n> +\n> option('documentation',\n> type : 'feature',\n> description : 'Generate the project documentation')\n> diff --git a/src/android/meson.build b/src/android/meson.build\n> index 9719c42b..a13ce63b 100644\n> --- a/src/android/meson.build\n> +++ b/src/android/meson.build\n> @@ -37,6 +37,11 @@ if android_enabled\n> android_deps += [libyuv_dep]\n> endif\n> \n> +if get_option('cros') and not android_enabled\n> + warning('cros option enabled but android is not, cros option will be ignored')\n> +endif\n> +cros_enabled = get_option('cros') and android_enabled\n> +\n\nWhat about having cros enable the android option instead?\n\nThen ChromeOS platforms only have to select cros=true?\n\n> android_hal_sources = files([\n> 'camera3_hal.cpp',\n> 'camera_hal_manager.cpp',\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C262EBD808\n\tfor ;\n\tThu, 25 Feb 2021 14:49:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8E01D68A48;\n\tThu, 25 Feb 2021 15:49:19 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 857DB602EE\n\tfor ;\n\tThu, 25 Feb 2021 15:49:17 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 23BDE8AD;\n\tThu, 25 Feb 2021 15:49:17 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DFXHQ5um\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614264557;\n\tbh=6i6pPDGOaSyv1TD2sOxQtujuhcbipr7NB9Jvdcztoaw=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=DFXHQ5umIB6nozYWkvsDAQDwu9JpCRQ1NZYqtBjRANf5+flc3jUzd0fyomulrV34p\n\tloXeQbcNh1x4b3Visu/tNmc1aHYJSUg2d9k6Pyvz9ygd1luVzBgx5Kk+ragBN+O5Vt\n\tvowVlCgNxict5zf4I/JS+X0LEgb+TL+9OFF9kvgQ=","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210225104217.108792-1-paul.elder@ideasonboard.com>\n\t<20210225104217.108792-2-paul.elder@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<5a394324-14b9-6805-e631-c13e7e3f6458@ideasonboard.com>","Date":"Thu, 25 Feb 2021 14:49:15 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210225104217.108792-2-paul.elder@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 1/3] meson: Add cros build option","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15320,"web_url":"https://patchwork.libcamera.org/comment/15320/","msgid":"","date":"2021-02-25T18:16:04","subject":"Re: [libcamera-devel] [PATCH 1/3] meson: Add cros build option","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Thu, Feb 25, 2021 at 02:49:15PM +0000, Kieran Bingham wrote:\n> On 25/02/2021 10:42, Paul Elder wrote:\n> > Add a cros build option to prepare for adding the symbols required for\n> > the new cros camera API.\n> > \n> > Signed-off-by: Paul Elder \n> > ---\n> > meson_options.txt | 5 +++++\n> > src/android/meson.build | 5 +++++\n> > 2 files changed, 10 insertions(+)\n> > \n> > diff --git a/meson_options.txt b/meson_options.txt\n> > index 53f2675e..22efb323 100644\n> > --- a/meson_options.txt\n> > +++ b/meson_options.txt\n> > @@ -5,6 +5,11 @@ option('android',\n> > value : 'disabled',\n> > description : 'Compile libcamera with Android Camera3 HAL interface')\n> > \n> > +option('cros',\n> > + type : 'boolean',\n> > + value : 'false',\n> > + description : 'Compile libcamera with the cros Camera3 HAL interface (depends on android option)')\n> > +\n\nJacopo will soon introduce an android_memory_backend option. Would it\nmake sense to merge the two in an android_platform (bikeshedding on the\nname is possible) ?\n\n> > option('documentation',\n> > type : 'feature',\n> > description : 'Generate the project documentation')\n> > diff --git a/src/android/meson.build b/src/android/meson.build\n> > index 9719c42b..a13ce63b 100644\n> > --- a/src/android/meson.build\n> > +++ b/src/android/meson.build\n> > @@ -37,6 +37,11 @@ if android_enabled\n> > android_deps += [libyuv_dep]\n> > endif\n> > \n> > +if get_option('cros') and not android_enabled\n> > + warning('cros option enabled but android is not, cros option will be ignored')\n> > +endif\n> > +cros_enabled = get_option('cros') and android_enabled\n> > +\n> \n> What about having cros enable the android option instead?\n> \n> Then ChromeOS platforms only have to select cros=true?\n\nOr we could just silently ignore the cros (or android_platform) option\nwhen android isn't set, I don't think it would confuse anyone.\n\n> > android_hal_sources = files([\n> > 'camera3_hal.cpp',\n> > 'camera_hal_manager.cpp',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E9A5EBD1F1\n\tfor ;\n\tThu, 25 Feb 2021 18:16:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6CB2168A59;\n\tThu, 25 Feb 2021 19:16:34 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 374F668A51\n\tfor ;\n\tThu, 25 Feb 2021 19:16:33 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 17BF258E;\n\tThu, 25 Feb 2021 19:16:32 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"byFmsamb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614276992;\n\tbh=g3Bxh8qwU3dt4w8Rw48RYmUFPnaLSysjejfxCsgGAj4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=byFmsambmcZNzLKM/R1yb7OL5L8VX8xcgFVrRrA8jNT/9iVgx7YpFnzaD2H/fmBBO\n\tH9qNKQf10MzVnoAEE357DnOJeY8zR+tW2zisri1YMYMMFrKrQcSz9kgFd8il5ysV3W\n\try5U2I/A0mUWO+muXd73Vi3rdzXTJT45g5XynmzY=","Date":"Thu, 25 Feb 2021 20:16:04 +0200","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"","References":"<20210225104217.108792-1-paul.elder@ideasonboard.com>\n\t<20210225104217.108792-2-paul.elder@ideasonboard.com>\n\t<5a394324-14b9-6805-e631-c13e7e3f6458@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<5a394324-14b9-6805-e631-c13e7e3f6458@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/3] meson: Add cros build option","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15322,"web_url":"https://patchwork.libcamera.org/comment/15322/","msgid":"<20210226080125.jwv2qsqqhgm7oiv2@uno.localdomain>","date":"2021-02-26T08:01:25","subject":"Re: [libcamera-devel] [PATCH 1/3] meson: Add cros build option","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent, Paul,\n\nOn Thu, Feb 25, 2021 at 08:16:04PM +0200, Laurent Pinchart wrote:\n> Hi Paul,\n>\n> Thank you for the patch.\n>\n> On Thu, Feb 25, 2021 at 02:49:15PM +0000, Kieran Bingham wrote:\n> > On 25/02/2021 10:42, Paul Elder wrote:\n> > > Add a cros build option to prepare for adding the symbols required for\n> > > the new cros camera API.\n> > >\n> > > Signed-off-by: Paul Elder \n> > > ---\n> > > meson_options.txt | 5 +++++\n> > > src/android/meson.build | 5 +++++\n> > > 2 files changed, 10 insertions(+)\n> > >\n> > > diff --git a/meson_options.txt b/meson_options.txt\n> > > index 53f2675e..22efb323 100644\n> > > --- a/meson_options.txt\n> > > +++ b/meson_options.txt\n> > > @@ -5,6 +5,11 @@ option('android',\n> > > value : 'disabled',\n> > > description : 'Compile libcamera with Android Camera3 HAL interface')\n> > >\n> > > +option('cros',\n> > > + type : 'boolean',\n> > > + value : 'false',\n> > > + description : 'Compile libcamera with the cros Camera3 HAL interface (depends on android option)')\n> > > +\n>\n> Jacopo will soon introduce an android_memory_backend option. Would it\n> make sense to merge the two in an android_platform (bikeshedding on the\n> name is possible) ?\n>\n\nI would be glad if this would be possible and I think android_platform\nis a good compromise. Although I wonder if for the same 'platform' we\nmight have different 'memory backends' depending on, in example,\nversioning. However I think it's fine for the time being..\n\nIs this change is here to stay or not ? I still wonder if the fix is\ntemporary.\n\n> > > option('documentation',\n> > > type : 'feature',\n> > > description : 'Generate the project documentation')\n> > > diff --git a/src/android/meson.build b/src/android/meson.build\n> > > index 9719c42b..a13ce63b 100644\n> > > --- a/src/android/meson.build\n> > > +++ b/src/android/meson.build\n> > > @@ -37,6 +37,11 @@ if android_enabled\n> > > android_deps += [libyuv_dep]\n> > > endif\n> > >\n> > > +if get_option('cros') and not android_enabled\n> > > + warning('cros option enabled but android is not, cros option will be ignored')\n> > > +endif\n> > > +cros_enabled = get_option('cros') and android_enabled\n> > > +\n> >\n> > What about having cros enable the android option instead?\n> >\n> > Then ChromeOS platforms only have to select cros=true?\n>\n> Or we could just silently ignore the cros (or android_platform) option\n> when android isn't set, I don't think it would confuse anyone.\n>\n> > > android_hal_sources = files([\n> > > 'camera3_hal.cpp',\n> > > 'camera_hal_manager.cpp',\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A0358BD808\n\tfor ;\n\tFri, 26 Feb 2021 08:00:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 05AD368A5D;\n\tFri, 26 Feb 2021 09:00:59 +0100 (CET)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AEDAB689DD\n\tfor ;\n\tFri, 26 Feb 2021 09:00:57 +0100 (CET)","from uno.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id D84AA60011;\n\tFri, 26 Feb 2021 08:00:56 +0000 (UTC)"],"X-Originating-IP":"93.61.96.190","Date":"Fri, 26 Feb 2021 09:01:25 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20210226080125.jwv2qsqqhgm7oiv2@uno.localdomain>","References":"<20210225104217.108792-1-paul.elder@ideasonboard.com>\n\t<20210225104217.108792-2-paul.elder@ideasonboard.com>\n\t<5a394324-14b9-6805-e631-c13e7e3f6458@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 1/3] meson: Add cros build option","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15327,"web_url":"https://patchwork.libcamera.org/comment/15327/","msgid":"","date":"2021-02-26T12:32:19","subject":"Re: [libcamera-devel] [PATCH 1/3] meson: Add cros build option","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Fri, Feb 26, 2021 at 09:01:25AM +0100, Jacopo Mondi wrote:\n> On Thu, Feb 25, 2021 at 08:16:04PM +0200, Laurent Pinchart wrote:\n> > On Thu, Feb 25, 2021 at 02:49:15PM +0000, Kieran Bingham wrote:\n> > > On 25/02/2021 10:42, Paul Elder wrote:\n> > > > Add a cros build option to prepare for adding the symbols required for\n> > > > the new cros camera API.\n> > > >\n> > > > Signed-off-by: Paul Elder \n> > > > ---\n> > > > meson_options.txt | 5 +++++\n> > > > src/android/meson.build | 5 +++++\n> > > > 2 files changed, 10 insertions(+)\n> > > >\n> > > > diff --git a/meson_options.txt b/meson_options.txt\n> > > > index 53f2675e..22efb323 100644\n> > > > --- a/meson_options.txt\n> > > > +++ b/meson_options.txt\n> > > > @@ -5,6 +5,11 @@ option('android',\n> > > > value : 'disabled',\n> > > > description : 'Compile libcamera with Android Camera3 HAL interface')\n> > > >\n> > > > +option('cros',\n> > > > + type : 'boolean',\n> > > > + value : 'false',\n> > > > + description : 'Compile libcamera with the cros Camera3 HAL interface (depends on android option)')\n> > > > +\n> >\n> > Jacopo will soon introduce an android_memory_backend option. Would it\n> > make sense to merge the two in an android_platform (bikeshedding on the\n> > name is possible) ?\n> \n> I would be glad if this would be possible and I think android_platform\n> is a good compromise. Although I wonder if for the same 'platform' we\n> might have different 'memory backends' depending on, in example,\n> versioning. However I think it's fine for the time being..\n\nThat's true, maybe we'll have to deal with that, time will tell :-) For\nnow it should be fine.\n\n> Is this change is here to stay or not ? I still wonder if the fix is\n> temporary.\n\nIt's a temporary-to-be-long-term change I think. As far as I understand,\nmaking the CrOS-specific HAL API required was an oversight, and this\nwill be fixed. However, it is mandatory to use mojom interfaces, which\nwe don't, but may start using for a CrOS-specific JPEG encoder\npost-processor (with hardware acceleration) in the future. There's thus\nno need to overdesign this fix in the short term as it may get reverted,\nbut we may also need it longer term, so any improvement that won't cost\nus much time is welcome.\n\n> > > > option('documentation',\n> > > > type : 'feature',\n> > > > description : 'Generate the project documentation')\n> > > > diff --git a/src/android/meson.build b/src/android/meson.build\n> > > > index 9719c42b..a13ce63b 100644\n> > > > --- a/src/android/meson.build\n> > > > +++ b/src/android/meson.build\n> > > > @@ -37,6 +37,11 @@ if android_enabled\n> > > > android_deps += [libyuv_dep]\n> > > > endif\n> > > >\n> > > > +if get_option('cros') and not android_enabled\n> > > > + warning('cros option enabled but android is not, cros option will be ignored')\n> > > > +endif\n> > > > +cros_enabled = get_option('cros') and android_enabled\n> > > > +\n> > >\n> > > What about having cros enable the android option instead?\n> > >\n> > > Then ChromeOS platforms only have to select cros=true?\n> >\n> > Or we could just silently ignore the cros (or android_platform) option\n> > when android isn't set, I don't think it would confuse anyone.\n> >\n> > > > android_hal_sources = files([\n> > > > 'camera3_hal.cpp',\n> > > > 'camera_hal_manager.cpp',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 34FAABD808\n\tfor ;\n\tFri, 26 Feb 2021 12:32:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A65DD68A5F;\n\tFri, 26 Feb 2021 13:32:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0395D60106\n\tfor ;\n\tFri, 26 Feb 2021 13:32:47 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5676A580;\n\tFri, 26 Feb 2021 13:32:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FQ3aM8wf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614342766;\n\tbh=qiPVSTMYOPajylZVJg6nK4U+PRijdjkRbNIIYM67fbs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=FQ3aM8wfsBHvfaz3OiFSe/3iGGiKd4FChEM2IfnSQmtvsv+9rxYvOenVY7+QnlSnO\n\t4ubc0J6fXBTRr0EwfctStJJqOsm90N+gsTwThJD8a963dYTDKWRB0kECvFzqWbu4xs\n\tloUJ+OW14+HuipsLf3tF3f2t5mXDng956FLyUDdA=","Date":"Fri, 26 Feb 2021 14:32:19 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210225104217.108792-1-paul.elder@ideasonboard.com>\n\t<20210225104217.108792-2-paul.elder@ideasonboard.com>\n\t<5a394324-14b9-6805-e631-c13e7e3f6458@ideasonboard.com>\n\t\n\t<20210226080125.jwv2qsqqhgm7oiv2@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210226080125.jwv2qsqqhgm7oiv2@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH 1/3] meson: Add cros build option","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]