[{"id":15306,"web_url":"https://patchwork.libcamera.org/comment/15306/","msgid":"<20210224095845.4mh6e6jizvjfwt3x@uno.localdomain>","date":"2021-02-24T09:58:45","subject":"Re: [libcamera-devel] [PATCH v3 2/2] android: camera_device: Set\n\tthe camera location to Front if External","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Wed, Feb 24, 2021 at 06:48:32PM +0900, Paul Elder wrote:\n> Our android HAL implementation currently does not support external\n> cameras, so if the camera location property is external, set it to\n> front.\n>\n> This allows the following CTS test to pass:\n> - android.hardware.camera2.cts.CameraManagerTest#testCameraManagerGetDeviceIdList\n>\n> Signed-off-by: Paul Elder \n> Reviewed-by: Kieran Bingham \n> Reviewed-by: Niklas Söderlund \n> Reviewed-by: Laurent Pinchart \n>\n> ---\n> No change in v2\n> ---\n> src/android/camera_device.cpp | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 1e2a5b5f..16cb8c6d 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -405,7 +405,11 @@ int CameraDevice::initialize()\n> \t\t\tfacing_ = CAMERA_FACING_BACK;\n> \t\t\tbreak;\n> \t\tcase properties::CameraLocationExternal:\n> -\t\t\tfacing_ = CAMERA_FACING_EXTERNAL;\n> +\t\t\t/*\n> +\t\t\t * \\todo Set this to EXTERNAL once we support\n> +\t\t\t * HARDWARE_LEVEL_EXTERNAL\n> +\t\t\t */\n> +\t\t\tfacing_ = CAMERA_FACING_FRONT;\n\nI keep thinking that we're calling for troubles once we'll have to\nreally determinate if a camera is external for real. But since there\nhas been a too long discussion already:\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n> \t\t\tbreak;\n> \t\t}\n> \t}\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CC56ABD1F1\n\tfor ;\n\tWed, 24 Feb 2021 09:58:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A151E68A39;\n\tWed, 24 Feb 2021 10:58:18 +0100 (CET)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B52BF6040F\n\tfor ;\n\tWed, 24 Feb 2021 10:58:17 +0100 (CET)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 38EBB240004;\n\tWed, 24 Feb 2021 09:58:16 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Wed, 24 Feb 2021 10:58:45 +0100","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20210224095845.4mh6e6jizvjfwt3x@uno.localdomain>","References":"<20210224094833.24219-1-paul.elder@ideasonboard.com>\n\t<20210224094833.24219-3-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210224094833.24219-3-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 2/2] android: camera_device: Set\n\tthe camera location to Front if External","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]