[{"id":15300,"web_url":"https://patchwork.libcamera.org/comment/15300/","msgid":"","date":"2021-02-23T14:11:42","subject":"Re: [libcamera-devel] [PATCH] libcamera: ipu3: Initialize V|H flip\n\tsupport","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your patch.\n\nOn 2021-02-23 14:53:31 +0100, Jacopo Mondi wrote:\n> The flag that is used to record if the sensor driver supports the H/V flip\n> controls is initialized at camera creation time, but it was not\n> initialized by the IPU3Camera constructor, resulting in erroneous\n> values that might break capture for sensor that do not support flipping.\n> \n> Fix this by initializing the flag in the class constructor.\n> \n> Fixes: 6c4ce7de30c8 (\"libcamera: ipu3: Add rotation to ipu3 pipeline\")\n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index daace29f71ea..2838196a4b21 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -56,7 +56,7 @@ class IPU3CameraData : public CameraData\n> {\n> public:\n> \tIPU3CameraData(PipelineHandler *pipe)\n> -\t\t: CameraData(pipe), exposureTime_(0)\n> +\t\t: CameraData(pipe), exposureTime_(0), supportsFlips_(false)\n> \t{\n> \t}\n> \n> --\n> 2.30.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9B419BD1F1\n\tfor ;\n\tTue, 23 Feb 2021 14:11:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 27A3368A2D;\n\tTue, 23 Feb 2021 15:11:47 +0100 (CET)","from mail-lf1-x132.google.com (mail-lf1-x132.google.com\n\t[IPv6:2a00:1450:4864:20::132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1D472689DD\n\tfor ;\n\tTue, 23 Feb 2021 15:11:45 +0100 (CET)","by mail-lf1-x132.google.com with SMTP id d3so11334392lfg.10\n\tfor ;\n\tTue, 23 Feb 2021 06:11:45 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tt25sm2480297ljc.100.2021.02.23.06.11.43\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 23 Feb 2021 06:11:43 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"bMac/ip7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=zIpAX/6EdFwP8aoL6ETSmMyuPt7hWLp+DV/Opl51Puw=;\n\tb=bMac/ip7Ph87DBzdo3YxCHkB3ANAB73oQwDgk+3UCxD4xURiHrdB/cNtJFfypzlWYK\n\tT1qN2CGMO5ah64GY/ADeudJkB7DYqLkqsTLpFvtqluCYZpPjFtTKLFP5ZKqFl5VF+jPg\n\tXcDIJ6XWXxKBGEwBDxHQgu+94w2d2wusmAFXrBkc39t6VdvIhS10VZZutLh727Ljm57E\n\tUBRIrkpRAA+EEg3f+14lfx7mfDd3u3yIJMx/fyhOXhg+Xwa5O4AS5e359mG81w4gbH/o\n\tAGGimtZuxp7V9u7CqGT6u1x+sX9zVjmmoNLJeK5KXzW1EN4PS3lcP+8ERUSUOwtv+hiB\n\t77zA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=zIpAX/6EdFwP8aoL6ETSmMyuPt7hWLp+DV/Opl51Puw=;\n\tb=ISENbJQpUXOX9KFAgUwTmqtyJieXiOjC79aZr5vGnayt655vM776gHIDO0U4YBRsUu\n\tTB53TDMiY6GJ7uA0Qh/vSgSSheyjkP/jS0D+qbRzyJGXOzHfe6wIGTMigY9m0WJVbEtV\n\tgpgasPvyTXenF8NauDJBBv3hUXvoaaut6JvX8KfXksf+Chg9NmX1uaxMvGxg0n37CPUr\n\tgRu1sQlaA5O820qOw1ljVZ5KH1wjBX24iXzl9m1+N9oMECDjb7t0okGmVnompmsPjXrS\n\t4z3oJjcCtv+NR6wvk0ZgQvhPSShDgRYRJbPN2ol9jFa78x6JBjGngLuxdvZG/ZK0+3OM\n\tCL4g==","X-Gm-Message-State":"AOAM532s8ztbDGcwT/zafzPsduSQsNQMs3i2F+oGPQFJfikPN7846Er7\n\tQ9LAuygXlDjNORqIVJ8k2tVZoQ==","X-Google-Smtp-Source":"ABdhPJwb+w+FPuPAUPuodMTqV8iMoSGT/zm3dQG4HkRi2UUMuPVm9HI5tROpjDBzeSv2CP2sMOQfmA==","X-Received":"by 2002:a05:6512:21a3:: with SMTP id\n\tc3mr15914859lft.635.1614089504319; \n\tTue, 23 Feb 2021 06:11:44 -0800 (PST)","Date":"Tue, 23 Feb 2021 15:11:42 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210223135331.2711706-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210223135331.2711706-1-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: ipu3: Initialize V|H flip\n\tsupport","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15303,"web_url":"https://patchwork.libcamera.org/comment/15303/","msgid":"","date":"2021-02-23T15:51:26","subject":"Re: [libcamera-devel] [PATCH] libcamera: ipu3: Initialize V|H flip\n\tsupport","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Feb 23, 2021 at 02:53:31PM +0100, Jacopo Mondi wrote:\n> The flag that is used to record if the sensor driver supports the H/V flip\n> controls is initialized at camera creation time, but it was not\n> initialized by the IPU3Camera constructor, resulting in erroneous\n> values that might break capture for sensor that do not support flipping.\n> \n> Fix this by initializing the flag in the class constructor.\n> \n> Fixes: 6c4ce7de30c8 (\"libcamera: ipu3: Add rotation to ipu3 pipeline\")\n> Signed-off-by: Jacopo Mondi \n\nGood catch!\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index daace29f71ea..2838196a4b21 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -56,7 +56,7 @@ class IPU3CameraData : public CameraData\n> {\n> public:\n> \tIPU3CameraData(PipelineHandler *pipe)\n> -\t\t: CameraData(pipe), exposureTime_(0)\n> +\t\t: CameraData(pipe), exposureTime_(0), supportsFlips_(false)\n> \t{\n> \t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 63415BD808\n\tfor ;\n\tTue, 23 Feb 2021 15:51:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E0EB668A31;\n\tTue, 23 Feb 2021 16:51:54 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B1791689DD\n\tfor ;\n\tTue, 23 Feb 2021 16:51:53 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2872066;\n\tTue, 23 Feb 2021 16:51:53 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WW9JliR2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614095513;\n\tbh=cfNHjGFWiij0uMtQhsaUMpn8TBYbur56xp5T9ZNSSX0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WW9JliR2i3dZtf4R4JbKSfjnIY90XAVm7yX0GaBGjgOUd3kZsjQy35T23k4xj+gSb\n\tfQGJXDbpIdFtxoeLBGVuRvHdtAa2fS3znN83fJS6sen3GdTIXE9kMyz9gXgxjxJ3IW\n\tqaKCwoBCm4Lr8oaYL3qYgppUv6be7jvbbDkX5I3k=","Date":"Tue, 23 Feb 2021 17:51:26 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210223135331.2711706-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210223135331.2711706-1-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: ipu3: Initialize V|H flip\n\tsupport","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15304,"web_url":"https://patchwork.libcamera.org/comment/15304/","msgid":"<08be90db-ecd4-7be2-04dc-a6135a1a05c4@fabwu.ch>","date":"2021-02-23T19:42:17","subject":"Re: [libcamera-devel] [PATCH] libcamera: ipu3: Initialize V|H flip\n\tsupport","submitter":{"id":77,"url":"https://patchwork.libcamera.org/api/people/77/","name":"Fabian Wüthrich","email":"me@fabwu.ch"},"content":"Hi Jacopo\n\nI missed that one. Thanks for fixing it.\n\nTested-by: Fabian Wüthrich \n\nOn 23.02.21 14:53, Jacopo Mondi wrote:\n> The flag that is used to record if the sensor driver supports the H/V flip\n> controls is initialized at camera creation time, but it was not\n> initialized by the IPU3Camera constructor, resulting in erroneous\n> values that might break capture for sensor that do not support flipping.\n> \n> Fix this by initializing the flag in the class constructor.\n> \n> Fixes: 6c4ce7de30c8 (\"libcamera: ipu3: Add rotation to ipu3 pipeline\")\n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index daace29f71ea..2838196a4b21 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -56,7 +56,7 @@ class IPU3CameraData : public CameraData\n> {\n> public:\n> \tIPU3CameraData(PipelineHandler *pipe)\n> -\t\t: CameraData(pipe), exposureTime_(0)\n> +\t\t: CameraData(pipe), exposureTime_(0), supportsFlips_(false)\n> \t{\n> \t}\n> \n> --\n> 2.30.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E53B8BD808\n\tfor ;\n\tTue, 23 Feb 2021 19:42:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5E66268A33;\n\tTue, 23 Feb 2021 20:42:19 +0100 (CET)","from gusto4.metanet.ch (gusto4.metanet.ch [80.74.154.158])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C823D689DD\n\tfor ;\n\tTue, 23 Feb 2021 20:42:17 +0100 (CET)","from [192.168.1.132] (localhost [127.0.0.1]) by gusto4.metanet.ch\n\t(Postfix) with ESMTPSA id 3F6384F00DBE; \n\tTue, 23 Feb 2021 20:42:17 +0100 (CET)"],"Authentication-Results":["lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=fabwu.ch header.i=@fabwu.ch header.b=\"RUOxtSiA\";\n\tdkim-atps=neutral","gusto.metanet.ch;\n\tspf=pass (sender IP is 62.202.181.20) smtp.mailfrom=me@fabwu.ch\n\tsmtp.helo=[192.168.1.132]"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=fabwu.ch; s=default; \n\tt=1614109337; bh=3Wp1CzlDJzss6glEDd53VoHy6MrIuQ7qNoZiHXYywio=;\n\th=Subject:To:From;\n\tb=RUOxtSiA1x66QD8vYMg1b4jQpJ02MxyggDOxaT8qnSpu1DKxNW0v/OP30SOG5ynT1\n\tknGbbxq1A2n35TgmWhAr13CVXU0u4kxvcmHhDW1PuKHnJjGqJamAKgVkizKBh6DINT\n\t2I/2iW9bA2WPWON9zsxGP6Tz6gIGkFx4VuMGTY5E=","Received-SPF":"pass (gusto.metanet.ch: connection is authenticated)","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20210223135331.2711706-1-jacopo@jmondi.org>","From":"=?utf-8?q?Fabian_W=C3=BCthrich?= ","Message-ID":"<08be90db-ecd4-7be2-04dc-a6135a1a05c4@fabwu.ch>","Date":"Tue, 23 Feb 2021 20:42:17 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.7.1","MIME-Version":"1.0","In-Reply-To":"<20210223135331.2711706-1-jacopo@jmondi.org>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] libcamera: ipu3: Initialize V|H flip\n\tsupport","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]