[{"id":15544,"web_url":"https://patchwork.libcamera.org/comment/15544/","msgid":"","date":"2021-03-08T23:51:05","subject":"Re: [libcamera-devel] [PATCH v3 5/5] android: camera_device: Return\n\tAE FPS range","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Mon, Feb 22, 2021 at 11:52:22AM +0100, Jacopo Mondi wrote:\n> The result metadata reports an arbitrary {30, 30} FPS range for the\n> AE algorithm.\n> \n> The actual FPS range should be returned in the Request::metadata, but\n> as libcamera currently does not support that feature temporarily work\n> around the issue and return the FPS range requested by the camera\n> framework.\n> \n> While at it, create a 'settings' reference to descriptor->settings_\n> and use it in multiple locations.\n\nI think this paragraph should be dropped as you don't do so anymore (at\nleast not in this patch). Other than that, the patch looks good.\n\n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/android/camera_device.cpp | 11 ++++++++---\n> 1 file changed, 8 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index c0939eaf27ac..c2fe2787fa74 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -2093,9 +2093,14 @@ CameraDevice::getResultMetadata(Camera3RequestDescriptor *descriptor,\n> \tvalue = ANDROID_CONTROL_AE_MODE_ON;\n> \tresultMetadata->addEntry(ANDROID_CONTROL_AE_MODE, &value, 1);\n> \n> -\tstd::vector aeFpsTarget = { 30, 30 };\n> -\tresultMetadata->addEntry(ANDROID_CONTROL_AE_TARGET_FPS_RANGE,\n> -\t\t\t\t aeFpsTarget.data(), aeFpsTarget.size());\n> +\tif (settings.getEntry(ANDROID_CONTROL_AE_TARGET_FPS_RANGE, &entry))\n> +\t\t/*\n> +\t\t * \\todo Retrieve the AE FPS range from the libcamera metadata.\n> +\t\t * As libcamera does not support that control, as a temporary\n> +\t\t * workaround return what the framework asked.\n> +\t\t */\n> +\t\tresultMetadata->addEntry(ANDROID_CONTROL_AE_TARGET_FPS_RANGE,\n> +\t\t\t\t\t entry.data.i32, 2);\n> \n> \tvalue = ANDROID_CONTROL_AE_PRECAPTURE_TRIGGER_IDLE;\n> \tfound = settings.getEntry(ANDROID_CONTROL_AE_PRECAPTURE_TRIGGER, &entry);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0FF01BD80C\n\tfor ;\n\tMon, 8 Mar 2021 23:51:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6748E68AA3;\n\tTue, 9 Mar 2021 00:51:38 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B3897602E4\n\tfor ;\n\tTue, 9 Mar 2021 00:51:36 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 243FB99;\n\tTue, 9 Mar 2021 00:51:36 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uO33NoPV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615247496;\n\tbh=LnTJxLnbkfiiZeDCCSCHGVqqcELWceRK8ZT9oRQzaQg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=uO33NoPVUkq5kPvxv0LDV746ge3j2m/Qeck/xCZqFkZmFqCgbJO6r64WDAVDRsMda\n\ti2esEvH0WoQv02kUD5oYgaIbR2m+wy3LH3acTI9v2BafE2bFUMDpClPVhL2s6xljLO\n\thpT6GlnTmyxSvBqDcbZAQKcd/phR4sG0+0t6JvMs=","Date":"Tue, 9 Mar 2021 01:51:05 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210222105222.393677-1-jacopo@jmondi.org>\n\t<20210222105222.393677-6-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210222105222.393677-6-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v3 5/5] android: camera_device: Return\n\tAE FPS range","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]