[{"id":15284,"web_url":"https://patchwork.libcamera.org/comment/15284/","msgid":"<8de32451-1f25-841f-e435-6e015682917e@ideasonboard.com>","date":"2021-02-22T10:57:07","subject":"Re: [libcamera-devel] [PATCH] libcamera: raspberrypi: Drop\n\tstd::move() where misleading","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 22/02/2021 10:46, Laurent Pinchart wrote:\n> Usage of std::move() on a const lvalue will produce a const rvalue,\n> which the compiler will bind to the const lvalue reference of the\n> constructor or assignement operator. This results in the object being\n> copied, not moved. Drop std::move() in that case as it's misleading.\n> \n> Signed-off-by: Laurent Pinchart \n\nGiven how I've already been confused by this - it certainly makes sense\nto clear it up.\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 5bab313b5cc7..46b7c6dbba0a 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -1289,7 +1289,7 @@ void RPiCameraData::statsMetadataComplete(uint32_t bufferId, const ControlList &\n> \n> \t/* Fill the Request metadata buffer with what the IPA has provided */\n> \tRequest *request = requestQueue_.front();\n> -\trequest->metadata() = std::move(controls);\n> +\trequest->metadata() = controls;\n> \n> \t/*\n> \t * Also update the ScalerCrop in the metadata with what we actually\n> @@ -1338,7 +1338,7 @@ void RPiCameraData::embeddedComplete(uint32_t bufferId)\n> \n> void RPiCameraData::setIspControls(const ControlList &controls)\n> {\n> -\tControlList ctrls = std::move(controls);\n> +\tControlList ctrls = controls;\n> \n> \tif (ctrls.contains(V4L2_CID_USER_BCM2835_ISP_LENS_SHADING)) {\n> \t\tControlValue &value =\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D2CE8BD1F6\n\tfor ;\n\tMon, 22 Feb 2021 10:57:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4E8F068A15;\n\tMon, 22 Feb 2021 11:57:12 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CC56868A0C\n\tfor ;\n\tMon, 22 Feb 2021 11:57:10 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 40DC4344;\n\tMon, 22 Feb 2021 11:57:10 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZjejFc3h\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613991430;\n\tbh=iNjAG8ZruxxVOfNdTpDYIW7ebHJ6gL2sYWwMfXT+YAg=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=ZjejFc3h/EYa0+Ni00qjSmxDuuq982++0/klgcFg0IsR8Dya5MVDOiWYDZxRZT9p0\n\tYFuwZ1lmKzCLTQAoQG/Zm2s/f08WHygYQRqzCQJuD2tvurYdMtFaSdjUnOWPnBQIWR\n\tOp92nxVQQU2UG4mXwYCY4KxtxIzgL9ojsEZT2grI=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210222104624.17643-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<8de32451-1f25-841f-e435-6e015682917e@ideasonboard.com>","Date":"Mon, 22 Feb 2021 10:57:07 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210222104624.17643-1-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] libcamera: raspberrypi: Drop\n\tstd::move() where misleading","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15285,"web_url":"https://patchwork.libcamera.org/comment/15285/","msgid":"","date":"2021-02-22T10:59:18","subject":"Re: [libcamera-devel] [PATCH] libcamera: raspberrypi: Drop\n\tstd::move() where misleading","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\nThank you for the patch.\n\nOn Mon, 22 Feb 2021 at 10:46, Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> Usage of std::move() on a const lvalue will produce a const rvalue,\n> which the compiler will bind to the const lvalue reference of the\n> constructor or assignement operator. This results in the object being\n> copied, not moved. Drop std::move() in that case as it's misleading.\n>\n> Signed-off-by: Laurent Pinchart \n>\n\nReviewed-by: Naushir Patuck \n\n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 5bab313b5cc7..46b7c6dbba0a 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -1289,7 +1289,7 @@ void RPiCameraData::statsMetadataComplete(uint32_t\n> bufferId, const ControlList &\n>\n> /* Fill the Request metadata buffer with what the IPA has provided\n> */\n> Request *request = requestQueue_.front();\n> - request->metadata() = std::move(controls);\n> + request->metadata() = controls;\n>\n> /*\n> * Also update the ScalerCrop in the metadata with what we actually\n> @@ -1338,7 +1338,7 @@ void RPiCameraData::embeddedComplete(uint32_t\n> bufferId)\n>\n> void RPiCameraData::setIspControls(const ControlList &controls)\n> {\n> - ControlList ctrls = std::move(controls);\n> + ControlList ctrls = controls;\n>\n> if (ctrls.contains(V4L2_CID_USER_BCM2835_ISP_LENS_SHADING)) {\n> ControlValue &value =\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4EB5BBD1F1\n\tfor ;\n\tMon, 22 Feb 2021 10:59:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D663968A1C;\n\tMon, 22 Feb 2021 11:59:36 +0100 (CET)","from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com\n\t[IPv6:2a00:1450:4864:20::22a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 82B1068A0C\n\tfor ;\n\tMon, 22 Feb 2021 11:59:35 +0100 (CET)","by mail-lj1-x22a.google.com with SMTP id q14so56656216ljp.4\n\tfor ;\n\tMon, 22 Feb 2021 02:59:35 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"PRa2fXWH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=Idgu7GsWbnocWxf7RPWWgmJh1kMvXAdbvHZyLKN3iSU=;\n\tb=PRa2fXWH0g9ImjQI7CKfQU+1BGMD8vkYaF7x0DRUm2OpaBXyyZdwEOh4dvKVhkAtYo\n\tfeNC0pgl1OI1WlCtZkkRZ1WPE5gekk3dU80nmfiF4NoOpsgPjcUUF2sEWJFSU85VzOFk\n\t/QrjuBT5MpIox8xsMXDCqh4m0VWu199qoY6bhsLQ6sxX9T3mxoFQ8rmTgqpifw3HQgXA\n\tpH+icjSC8OtbpTImYXXShZodZwL1S6hdMb6NDugLsBTn/FQcTiqSxtTWDxkp1GpnYODy\n\t56xBoIDtK57Jjl7xnSVRdr/pcAvdrXKTKCtbw6uVPhSDmiNLX7rlGa98ia9cXvfZNFpO\n\tqUFQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=Idgu7GsWbnocWxf7RPWWgmJh1kMvXAdbvHZyLKN3iSU=;\n\tb=q2exfmj5+VKSwZIdEfB8qy5R2tVCxL31gXt60dXLPD+0nVUJBd23gwSLKFGXJ5a4o9\n\tgUqIR29SS22A2pFWXrJ1qqucdTgf7WmWiLXbubuH8VPIAnOUtb7t1gGXWdqwX+vMeHyA\n\tODyUBd61nfobByhO/aRWj9MEo9uf5aT6GtVaonEcK2DSWvWjrmQhWxOP5+7tQJD40rrn\n\t6r5AOwzK8uf5n0+9dSSc6P88syVBVkfew9vgOJGRGv3JWXdptJKDAFyctBT76MR04vSn\n\theNgyr2gML6zqpMeYr882gpiweCNjk8b66z+CkcyqVZBvovddVR4ywOu/DMKeXn/alPj\n\trHdQ==","X-Gm-Message-State":"AOAM532vJb8JIqvC657Etdqo83S7yJpQHdeCqaKlsWLz+bGekcBPrStX\n\tJDS1PYUtbceq4ZqVKxk9j/oPQUUOp9DC7J1yHtr9sIdiOuDElA==","X-Google-Smtp-Source":"ABdhPJxn0iUVXi4VTroKHmQLmpxrrLobMpctqQPXcKoa5JB4NY2BzzauVGH4h231yjHkWM3RnXHup2SMiN6PIIYwiEE=","X-Received":"by 2002:a19:48c2:: with SMTP id\n\tv185mr12807535lfa.375.1613991574741; \n\tMon, 22 Feb 2021 02:59:34 -0800 (PST)","MIME-Version":"1.0","References":"<20210222104624.17643-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20210222104624.17643-1-laurent.pinchart@ideasonboard.com>","From":"Naushir Patuck ","Date":"Mon, 22 Feb 2021 10:59:18 +0000","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH] libcamera: raspberrypi: Drop\n\tstd::move() where misleading","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============1707078855752148008==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]