[{"id":15277,"web_url":"https://patchwork.libcamera.org/comment/15277/","msgid":"","date":"2021-02-22T09:56:26","subject":"Re: [libcamera-devel] [PATCH] clang-format: Enable sorted includes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Mon, Feb 22, 2021 at 09:46:08AM +0000, Kieran Bingham wrote:\n> We aim to ensure that our includes are alphabetically sorted. Whilst\n> checkstyle.py also handles this, enable the clang-format explicitly to\n> define the code-style requirement, and allow clang-format to also\n> correct un-sorted header includes.\n> \n> Signed-off-by: Kieran Bingham \n> \n> ---\n> I can't see why this isn't enabled, unless clang-format is sorting in a\n> manner which is incompatible with the implementation in our\n> checkstyle.py ?\n> \n> Some initial testing shows that clang-format only sorts per block,\n> separated by newlines, which seems to match our implementation.\n\nI was considering enabling this along with corresponding include\nregexes, but I suppose it can go on its own too, if you guarantee it\nworks properly :-)\n\nReviewed-by: Laurent Pinchart \n\nWith appropriate regexes we could possibly drop the include formatter\nfrom checkstyle.py.\n\n> .clang-format | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/.clang-format b/.clang-format\n> index bef07cd84338..f5d9ba940eeb 100644\n> --- a/.clang-format\n> +++ b/.clang-format\n> @@ -97,7 +97,7 @@ PenaltyReturnTypeOnItsOwnLine: 60\n> \n> PointerAlignment: Right\n> ReflowComments: false\n> -SortIncludes: false\n> +SortIncludes: true\n> #SortUsingDeclarations: false # Unknown to clang-format-4.0\n> SpaceAfterCStyleCast: false\n> SpaceAfterTemplateKeyword: false","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9C051BD1F6\n\tfor ;\n\tMon, 22 Feb 2021 09:56:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 12DB368A00;\n\tMon, 22 Feb 2021 10:56:55 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D67E2602F3\n\tfor ;\n\tMon, 22 Feb 2021 10:56:53 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4D5CD344;\n\tMon, 22 Feb 2021 10:56:53 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Xviyp084\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613987813;\n\tbh=Jl3JeD+3gC7cFbpTBilHxZVFZ6aiagnHOKvHD9U8acU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Xviyp084Vlm2mBxAkRYbZ+HfNJdomOH1RDcSwAITLpAHJPC6a0RXQbh/lWNO6G1L2\n\tQ40CfYO9cU/oQ9twiXzg5Fv7XNH5j7bboZIAvg8SMGaBpzxoqPVVIK6L2Hs+ce6lAd\n\tpg6CVvhCLfXrkqLYLVmBh1NEDd/FOrpuldhtRZj0=","Date":"Mon, 22 Feb 2021 11:56:26 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210222032915.31452-1-laurent.pinchart@ideasonboard.com>\n\t<20210222094608.1541623-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210222094608.1541623-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] clang-format: Enable sorted includes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15506,"web_url":"https://patchwork.libcamera.org/comment/15506/","msgid":"<9a76a917-cd58-79cb-d72d-d7aa6d538bde@ideasonboard.com>","date":"2021-03-08T11:44:06","subject":"Re: [libcamera-devel] [PATCH] clang-format: Enable sorted includes","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 22/02/2021 09:56, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Mon, Feb 22, 2021 at 09:46:08AM +0000, Kieran Bingham wrote:\n>> We aim to ensure that our includes are alphabetically sorted. Whilst\n>> checkstyle.py also handles this, enable the clang-format explicitly to\n>> define the code-style requirement, and allow clang-format to also\n>> correct un-sorted header includes.\n>>\n>> Signed-off-by: Kieran Bingham \n>>\n>> ---\n>> I can't see why this isn't enabled, unless clang-format is sorting in a\n>> manner which is incompatible with the implementation in our\n>> checkstyle.py ?\n>>\n>> Some initial testing shows that clang-format only sorts per block,\n>> separated by newlines, which seems to match our implementation.\n> \n> I was considering enabling this along with corresponding include\n> regexes, but I suppose it can go on its own too, if you guarantee it\n> works properly :-)\n> \n> Reviewed-by: Laurent Pinchart \n> \n> With appropriate regexes we could possibly drop the include formatter\n> from checkstyle.py.\n\nThese look interesting but I haven't spent the time to figure out how\nthey really work yet.\n\nAn interesting thing to tackle in the future though, we just need to add\nit to some todo list ... ;-)\n\n--\nKieran\n\n\n> \n>> .clang-format | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/.clang-format b/.clang-format\n>> index bef07cd84338..f5d9ba940eeb 100644\n>> --- a/.clang-format\n>> +++ b/.clang-format\n>> @@ -97,7 +97,7 @@ PenaltyReturnTypeOnItsOwnLine: 60\n>> \n>> PointerAlignment: Right\n>> ReflowComments: false\n>> -SortIncludes: false\n>> +SortIncludes: true\n>> #SortUsingDeclarations: false # Unknown to clang-format-4.0\n>> SpaceAfterCStyleCast: false\n>> SpaceAfterTemplateKeyword: false\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A405EBD80C\n\tfor ;\n\tMon, 8 Mar 2021 11:44:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DF80F60520;\n\tMon, 8 Mar 2021 12:44:12 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D81A8602E6\n\tfor ;\n\tMon, 8 Mar 2021 12:44:10 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4BA0BAC1;\n\tMon, 8 Mar 2021 12:44:10 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jw6xHPC0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615203850;\n\tbh=sIAZ9a6VVPW3n0U2iEgJixUenHJlnwlDGck30zEKVaA=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=jw6xHPC0JgZjileutNlA4dB01T44RKyZlWC12bKPBrN4N/zULZaiBoQaWeu/Fj/Wf\n\tcdHtBCqm7lJOFT5tjTaU17TCeJ/HjN/vUk8KQLsFMnJT8raUTD+4Rn+qpGaHOr1F2H\n\tRXKSaizJBmPHW/RNB5DSpcY5GG9hW7QS0zF1bS0I=","To":"Laurent Pinchart ","References":"<20210222032915.31452-1-laurent.pinchart@ideasonboard.com>\n\t<20210222094608.1541623-1-kieran.bingham@ideasonboard.com>\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<9a76a917-cd58-79cb-d72d-d7aa6d538bde@ideasonboard.com>","Date":"Mon, 8 Mar 2021 11:44:06 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] clang-format: Enable sorted includes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]