[{"id":15273,"web_url":"https://patchwork.libcamera.org/comment/15273/","msgid":"","date":"2021-02-22T08:44:42","subject":"Re: [libcamera-devel] [PATCH v2 1/2] libcamera: camera_sensor:\n\tPrint warning when orientation is unknown","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Mon, Feb 22, 2021 at 05:01:11PM +0900, Paul Elder wrote:\n> Print a warning when the orientation of a sensor is unknown. The\n> location property is still defaulted to external.\n> \n> Signed-off-by: Paul Elder \n> Reviewed-by: Kieran Bingham \n> ---\n> Changes in v2:\n> - expand the warning message\n> ---\n> src/libcamera/camera_sensor.cpp | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index c9e8d49b..d7785f63 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -446,6 +446,12 @@ int CameraSensor::initProperties()\n> \t\t\tbreak;\n> \t\t}\n> \t} else {\n> +\t\tLOG(CameraSensor, Warning)\n> +\t\t\t<< \"Failed to retrieve the camera location, setting to External\";\n> +\t\tLOG(CameraSensor, Warning)\n> +\t\t\t<< \"The sensor kernel driver needs to be fixed\";\n> +\t\tLOG(CameraSensor, Warning)\n> +\t\t\t<< \"See Documentation/sensor_driver_requirements.rst in the libcamera sources for more information\";\n> \t\tpropertyValue = properties::CameraLocationExternal;\n> \t}\n> \tproperties_.set(properties::Location, propertyValue);\n\nAs an alternative approach, to tap into the existing infrastructure, how\nabout this ?\n\ndiff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex 0ea54a088a40..1987e84bfb9a 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -276,12 +276,13 @@ int CameraSensor::init()\n\n int CameraSensor::validateSensorDriver()\n {\n+\tint err = 0;\n+\n \t/*\n \t * Optional controls are used to register optional sensor properties. If\n \t * not present, some values will be defaulted.\n \t */\n \tstatic constexpr uint32_t optionalControls[] = {\n-\t\tV4L2_CID_CAMERA_ORIENTATION,\n \t\tV4L2_CID_CAMERA_SENSOR_ROTATION,\n \t};\n\n@@ -293,6 +294,24 @@ int CameraSensor::validateSensorDriver()\n \t\t\t\t<< \" not supported\";\n \t}\n\n+\t/*\n+\t * Recommended controls are similar to optional controls, but will\n+\t * become mandatory in the near future. Be loud if they're missing.\n+\t */\n+\tstatic constexpr uint32_t recommendedControls[] = {\n+\t\tV4L2_CID_CAMERA_ORIENTATION,\n+\t};\n+\n+\tconst ControlIdMap &controls = subdev_->controls().idmap();\n+\tfor (uint32_t ctrl : recommendedControls) {\n+\t\tif (!controls.count(ctrl)) {\n+\t\t\tLOG(CameraSensor, Warning)\n+\t\t\t\t<< \"Recommended V4L2 control \" << utils::hex(ctrl)\n+\t\t\t\t<< \" not supported\";\n+\t\t\terr = -EINVAL;\n+\t\t}\n+\t}\n+\n \t/*\n \t * Make sure the required selection targets are supported.\n \t *\n@@ -303,7 +322,6 @@ int CameraSensor::validateSensorDriver()\n \t * \\todo Make support for selection targets mandatory as soon as all\n \t * test platforms have been updated.\n \t */\n-\tint err = 0;\n \tRectangle rect;\n \tint ret = subdev_->getSelection(pad_, V4L2_SEL_TGT_CROP_BOUNDS, &rect);\n \tif (ret) {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3E46BBD1F1\n\tfor ;\n\tMon, 22 Feb 2021 08:45:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B7F9E689F6;\n\tMon, 22 Feb 2021 09:45:10 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B22DD602F3\n\tfor ;\n\tMon, 22 Feb 2021 09:45:09 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1B631344;\n\tMon, 22 Feb 2021 09:45:09 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hEgmHBkv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613983509;\n\tbh=Kl7Nyn/cit0bOgPzeEzv+2yfZOJ0+UOWzj4DaumXxpI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hEgmHBkvB7QIS2/XdjWMPgaeIkQX7M+VY+B23WAwMaw3B1jBjgGVzNvBPK4+6qcKb\n\taLyBZ6AYCNo5Yc9WW4vvUhHnqe8DcTDWgshUQFw2gxfJTRrD1iXXkrafhhtgUEZ+7W\n\tR5/RBMMn5aOf9rKN2pNPP6novW3JfDo3pmC+sHvM=","Date":"Mon, 22 Feb 2021 10:44:42 +0200","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"","References":"<20210222080112.72521-1-paul.elder@ideasonboard.com>\n\t<20210222080112.72521-2-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210222080112.72521-2-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 1/2] libcamera: camera_sensor:\n\tPrint warning when orientation is unknown","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]