{"id":11352,"url":"https://patchwork.libcamera.org/api/patches/11352/?format=json","web_url":"https://patchwork.libcamera.org/patch/11352/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210222080112.72521-2-paul.elder@ideasonboard.com>","date":"2021-02-22T08:01:11","name":"[libcamera-devel,v2,1/2] libcamera: camera_sensor: Print warning when orientation is unknown","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"228a78c98132d4af2a9f7964f5743541b858b38c","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11352/mbox/","series":[{"id":1714,"url":"https://patchwork.libcamera.org/api/series/1714/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1714","date":"2021-02-22T08:01:10","name":"Fix camera location","version":2,"mbox":"https://patchwork.libcamera.org/series/1714/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11352/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11352/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 13B81BD1F6\n\tfor ;\n\tMon, 22 Feb 2021 08:01:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B9A30689FD;\n\tMon, 22 Feb 2021 09:01:34 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A7BEC689F3\n\tfor ;\n\tMon, 22 Feb 2021 09:01:32 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9DFE3344;\n\tMon, 22 Feb 2021 09:01:30 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LDQQAGK7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613980892;\n\tbh=iKJu5FRh2pqTRYnDcPsrGUfyUdf/oFNxmm0dh0R2aWg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=LDQQAGK79UJbCnaACFvGSdGljwVQ5iV3Uu5BpX/WKcFcJF7JPMVHsiuL6Zo9YuNW/\n\tTHYYYpmDcget6xifFp50HZq5GlWzZyJR3zNqM4cNN62r7SC8hUyyQgEGAwhKao0WZi\n\t1TTvvhspAOO6HVUnawzwx/RNKMN115uWSwYTbp2c=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 22 Feb 2021 17:01:11 +0900","Message-Id":"<20210222080112.72521-2-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210222080112.72521-1-paul.elder@ideasonboard.com>","References":"<20210222080112.72521-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 1/2] libcamera: camera_sensor: Print\n\twarning when orientation is unknown","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Print a warning when the orientation of a sensor is unknown. The\nlocation property is still defaulted to external.\n\nSigned-off-by: Paul Elder \nReviewed-by: Kieran Bingham \n\n---\nChanges in v2:\n- expand the warning message\n---\n src/libcamera/camera_sensor.cpp | 6 ++++++\n 1 file changed, 6 insertions(+)","diff":"diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex c9e8d49b..d7785f63 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -446,6 +446,12 @@ int CameraSensor::initProperties()\n \t\t\tbreak;\n \t\t}\n \t} else {\n+\t\tLOG(CameraSensor, Warning)\n+\t\t\t<< \"Failed to retrieve the camera location, setting to External\";\n+\t\tLOG(CameraSensor, Warning)\n+\t\t\t<< \"The sensor kernel driver needs to be fixed\";\n+\t\tLOG(CameraSensor, Warning)\n+\t\t\t<< \"See Documentation/sensor_driver_requirements.rst in the libcamera sources for more information\";\n \t\tpropertyValue = properties::CameraLocationExternal;\n \t}\n \tproperties_.set(properties::Location, propertyValue);\n","prefixes":["libcamera-devel","v2","1/2"]}