[{"id":15747,"web_url":"https://patchwork.libcamera.org/comment/15747/","msgid":"<20210317162453.nzgmobncbutzb3bm@uno.localdomain>","date":"2021-03-17T16:24:53","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: change\n\tIF_CROP_MAX to 40","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Dave,\n\nOn Sat, Feb 20, 2021 at 11:06:08AM +0100, Dave Olsthoorn wrote:\n> The value of IF_CROP_MAX seems to be a typo. A resolution of 40x540 seems\n> unlikely and excludes camera's with a 640x480 resolution, like the OV7251\n> in several Microsoft Surface products, from working.\n>\n> This patch corrects the value to 40 since a minimal resolution of 40x40\n> seems more logical.\n\nI'm working on the ImgU pipe configuration and I would like to collect\nthis patch, but it's missing your Signed-off-by.\n\nIf you're ok I can add it and send the patch as part of a larger\nseries.\n\nThanks\n j\n\n> ---\n> src/libcamera/pipeline/ipu3/imgu.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\n> index d5cf05b0..fb995008 100644\n> --- a/src/libcamera/pipeline/ipu3/imgu.cpp\n> +++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n> @@ -42,7 +42,7 @@ static constexpr unsigned int BDS_ALIGN_W = 2;\n> static constexpr unsigned int BDS_ALIGN_H = 4;\n>\n> static constexpr unsigned int IF_CROP_MAX_W = 40;\n> -static constexpr unsigned int IF_CROP_MAX_H = 540;\n> +static constexpr unsigned int IF_CROP_MAX_H = 40;\n>\n> static constexpr float BDS_SF_MAX = 2.5;\n> static constexpr float BDS_SF_MIN = 1.0;\n> --\n> 2.29.2\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 04C1EC32E1\n\tfor ;\n\tWed, 17 Mar 2021 16:24:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4998268D60;\n\tWed, 17 Mar 2021 17:24:25 +0100 (CET)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AFEC06084F\n\tfor ;\n\tWed, 17 Mar 2021 17:24:23 +0100 (CET)","from uno.localdomain (mob-2-41-191-32.net.vodafone.it\n\t[2.41.191.32]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id B2419200007;\n\tWed, 17 Mar 2021 16:24:22 +0000 (UTC)"],"Date":"Wed, 17 Mar 2021 17:24:53 +0100","From":"Jacopo Mondi ","To":"Dave Olsthoorn ","Message-ID":"<20210317162453.nzgmobncbutzb3bm@uno.localdomain>","References":"<20210220100608.14267-1-dave@bewaar.me>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210220100608.14267-1-dave@bewaar.me>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: change\n\tIF_CROP_MAX to 40","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15749,"web_url":"https://patchwork.libcamera.org/comment/15749/","msgid":"<5bd2b7320fa057b9d386cd2148710616@bewaar.me>","date":"2021-03-17T17:58:33","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: change\n\tIF_CROP_MAX to 40","submitter":{"id":82,"url":"https://patchwork.libcamera.org/api/people/82/","name":"Dave Olsthoorn","email":"dave@bewaar.me"},"content":"Hi Jacopo,\n\nOn 2021-03-17 17:24, Jacopo Mondi wrote:\n> Hi Dave,\n> \n> On Sat, Feb 20, 2021 at 11:06:08AM +0100, Dave Olsthoorn wrote:\n>> The value of IF_CROP_MAX seems to be a typo. A resolution of 40x540 \n>> seems\n>> unlikely and excludes camera's with a 640x480 resolution, like the \n>> OV7251\n>> in several Microsoft Surface products, from working.\n>> \n>> This patch corrects the value to 40 since a minimal resolution of \n>> 40x40\n>> seems more logical.\n> \n> I'm working on the ImgU pipe configuration and I would like to collect\n> this patch, but it's missing your Signed-off-by.\n> \n> If you're ok I can add it and send the patch as part of a larger\n> series.\n> \nYou can add my Signed-off-by\n\nSigned-off-by: Dave Olsthoorn \n\n> Thanks\n> j\n> \n>> ---\n>> src/libcamera/pipeline/ipu3/imgu.cpp | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>> \n>> diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp \n>> b/src/libcamera/pipeline/ipu3/imgu.cpp\n>> index d5cf05b0..fb995008 100644\n>> --- a/src/libcamera/pipeline/ipu3/imgu.cpp\n>> +++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n>> @@ -42,7 +42,7 @@ static constexpr unsigned int BDS_ALIGN_W = 2;\n>> static constexpr unsigned int BDS_ALIGN_H = 4;\n>> \n>> static constexpr unsigned int IF_CROP_MAX_W = 40;\n>> -static constexpr unsigned int IF_CROP_MAX_H = 540;\n>> +static constexpr unsigned int IF_CROP_MAX_H = 40;\n>> \n>> static constexpr float BDS_SF_MAX = 2.5;\n>> static constexpr float BDS_SF_MIN = 1.0;\n>> --\n>> 2.29.2\n>> \n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel\n\nKind Regards,\nDave Olsthoorn","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5300EC32E1\n\tfor ;\n\tWed, 17 Mar 2021 17:58:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A361B68D60;\n\tWed, 17 Mar 2021 18:58:36 +0100 (CET)","from outbound2.mail.transip.nl (outbound2.mail.transip.nl\n\t[IPv6:2a01:7c8:7c8::73])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E48C46084F\n\tfor ;\n\tWed, 17 Mar 2021 18:58:34 +0100 (CET)","from submission2.mail.transip.nl (unknown [10.100.4.71])\n\tby outbound2.mail.transip.nl (Postfix) with ESMTP id 4F0yZL2Nm9zYd1x; \n\tWed, 17 Mar 2021 18:58:34 +0100 (CET)","from transip.email (unknown [10.103.8.118])\n\tby submission2.mail.transip.nl (Postfix) with ESMTPA id\n\t4F0yZK31dwz18GdH; Wed, 17 Mar 2021 18:58:33 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=bewaar.me header.i=@bewaar.me\n\theader.b=\"fR4MxJfz\"; dkim-atps=neutral","MIME-Version":"1.0","Date":"Wed, 17 Mar 2021 18:58:33 +0100","From":"dave@bewaar.me","To":"Jacopo Mondi ","In-Reply-To":"<20210317162453.nzgmobncbutzb3bm@uno.localdomain>","References":"<20210220100608.14267-1-dave@bewaar.me>\n\t<20210317162453.nzgmobncbutzb3bm@uno.localdomain>","Message-ID":"<5bd2b7320fa057b9d386cd2148710616@bewaar.me>","X-Sender":"dave@bewaar.me","User-Agent":"Webmail","X-Scanned-By":"ClueGetter at submission2.mail.transip.nl","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\ts=transip-a; d=bewaar.me; t=1616003913; h=from:subject:to:cc:\n\treferences:in-reply-to:date:mime-version:content-type;\n\tbh=Vz2eKWLo51wokl0u04oGxuVJaf0yq5WSBP0Z1yXgIhI=;\n\tb=fR4MxJfziKb/xnmN6u97qaa8UoXdppARmnqwLPCJ7vGwcGPMFuv/6Px47IX+HOM6kgDvgs\n\tSI8f9gW3qYiZLdqVai2z+Q5GJaW20nCHgyYN8zCeH14z8unwxGG2Oe52yCWORylO7ecAZk\n\tEZTs/hwZnLIPtiqT9tIRs2U/2p1cm6zjiXWCIvv//BaiGF5hUJx4oPdNrTt6R8v60ClbZS\n\tE377OZOfFi8vGJ+uS4kdNYgSJD4uoHD91nkiaWA296dAIQhMyf4ux6C1ZxJMKJjP7A5ewI\n\tYRyqh2WzPQH3TwpGSgJXdUjU0KbaWUinNMxXkYgLR5C2o5W8+W5fGGbyP90/7Q==","X-Report-Abuse-To":"abuse@transip.nl","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: change\n\tIF_CROP_MAX to 40","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]