[{"id":15235,"web_url":"https://patchwork.libcamera.org/comment/15235/","msgid":"<705b01ed-b1c6-607a-5ad5-a2f022ea9a60@ideasonboard.com>","date":"2021-02-19T11:05:14","subject":"Re: [libcamera-devel] [PATCH 2/2] android: camera_device: Set the\n\tcamera location to Front if External","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 19/02/2021 10:45, Paul Elder wrote:\n> Our android HAL implementation currently does not support external\n> cameras, so if the camera location property is external, set it to\n> front.\n> \n> This allows the following CTS test to pass:\n> - android.hardware.camera2.cts.CameraManagerTest#testCameraManagerGetDeviceIdList\n> \n> Signed-off-by: Paul Elder \n> ---\n> src/android/camera_device.cpp | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 1e2a5b5f..16cb8c6d 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -405,7 +405,11 @@ int CameraDevice::initialize()\n> \t\t\tfacing_ = CAMERA_FACING_BACK;\n> \t\t\tbreak;\n> \t\tcase properties::CameraLocationExternal:\n> -\t\t\tfacing_ = CAMERA_FACING_EXTERNAL;\n> +\t\t\t/*\n> +\t\t\t * \\todo Set this to EXTERNAL once we support\n> +\t\t\t * HARDWARE_LEVEL_EXTERNAL\n> +\t\t\t */\n> +\t\t\tfacing_ = CAMERA_FACING_FRONT;\n\nI would be tempted to add a warning log here too, as it's distinctly\nseparate from the setting of the properties::CameraLocationExternal,\nwhich can certainly be correctly set to External (on UVC) for example,\nbut which would come through here.\n\nI hadn't realised/been aware of this HARDWARE_LEVEL_EXTERNAL issues, I\nwonder if that was some how related to the difficulties we still had in\neven getting a Brio YUV UVC camera to work.\n\nI suspect it is, as perhaps with HARDWARE_LEVEL_EXTERNAL we can better\ndefine the actual capabilities /streams of the external device.\n\n\nAnyway, with or without the warning added, as this is a known workaround:\n\nReviewed-by: Kieran Bingham \n\n> \t\t\tbreak;\n> \t\t}\n> \t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 99074BD1F6\n\tfor ;\n\tFri, 19 Feb 2021 11:05:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0AA37637C9;\n\tFri, 19 Feb 2021 12:05:19 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E46E7602F5\n\tfor ;\n\tFri, 19 Feb 2021 12:05:17 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 47238344;\n\tFri, 19 Feb 2021 12:05:17 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"L/YzW66g\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613732717;\n\tbh=c+lBVI+5LENFfYQnRk0dGHt5/vhJUT5sT7p7Fmce8Vc=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=L/YzW66gxOSbT/wbKnikfdfVwWxXTdcJ0zzF77JyCk/h2htFO0e7WokmHpPpciGz4\n\tbTG4r8ri5NoTnI73QSc/JkOY1SejmN1CNJ4c6z+V1cleR2XwLFq5cZ7Iww5zmreAFC\n\tWJy4M5OdGK/DT3ZRcmU5AqeD0h+rDtQAD95gg1Ko=","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210219104544.53217-1-paul.elder@ideasonboard.com>\n\t<20210219104544.53217-3-paul.elder@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<705b01ed-b1c6-607a-5ad5-a2f022ea9a60@ideasonboard.com>","Date":"Fri, 19 Feb 2021 11:05:14 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210219104544.53217-3-paul.elder@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 2/2] android: camera_device: Set the\n\tcamera location to Front if External","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15243,"web_url":"https://patchwork.libcamera.org/comment/15243/","msgid":"","date":"2021-02-19T14:38:11","subject":"Re: [libcamera-devel] [PATCH 2/2] android: camera_device: Set the\n\tcamera location to Front if External","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Paul,\n\nThanks for your work.\n\nOn 2021-02-19 11:05:14 +0000, Kieran Bingham wrote:\n> On 19/02/2021 10:45, Paul Elder wrote:\n> > Our android HAL implementation currently does not support external\n> > cameras, so if the camera location property is external, set it to\n> > front.\n> > \n> > This allows the following CTS test to pass:\n> > - android.hardware.camera2.cts.CameraManagerTest#testCameraManagerGetDeviceIdList\n> > \n> > Signed-off-by: Paul Elder \n> > ---\n> > src/android/camera_device.cpp | 6 +++++-\n> > 1 file changed, 5 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index 1e2a5b5f..16cb8c6d 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -405,7 +405,11 @@ int CameraDevice::initialize()\n> > \t\t\tfacing_ = CAMERA_FACING_BACK;\n> > \t\t\tbreak;\n> > \t\tcase properties::CameraLocationExternal:\n> > -\t\t\tfacing_ = CAMERA_FACING_EXTERNAL;\n> > +\t\t\t/*\n> > +\t\t\t * \\todo Set this to EXTERNAL once we support\n> > +\t\t\t * HARDWARE_LEVEL_EXTERNAL\n> > +\t\t\t */\n> > +\t\t\tfacing_ = CAMERA_FACING_FRONT;\n> \n> I would be tempted to add a warning log here too, as it's distinctly\n> separate from the setting of the properties::CameraLocationExternal,\n> which can certainly be correctly set to External (on UVC) for example,\n> but which would come through here.\n> \n> I hadn't realised/been aware of this HARDWARE_LEVEL_EXTERNAL issues, I\n> wonder if that was some how related to the difficulties we still had in\n> even getting a Brio YUV UVC camera to work.\n> \n> I suspect it is, as perhaps with HARDWARE_LEVEL_EXTERNAL we can better\n> define the actual capabilities /streams of the external device.\n> \n> \n> Anyway, with or without the warning added, as this is a known workaround:\n\nWith a warning printout added,\n\nReviewed-by: Niklas Söderlund \n\n> \n> Reviewed-by: Kieran Bingham \n> \n> > \t\t\tbreak;\n> > \t\t}\n> > \t}\n> > \n> \n> -- \n> Regards\n> --\n> Kieran\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2E828BD1F1\n\tfor ;\n\tFri, 19 Feb 2021 14:38:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B7D2D689CD;\n\tFri, 19 Feb 2021 15:38:15 +0100 (CET)","from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com\n\t[IPv6:2a00:1450:4864:20::22c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 545A5602F5\n\tfor ;\n\tFri, 19 Feb 2021 15:38:14 +0100 (CET)","by mail-lj1-x22c.google.com with SMTP id r23so21720560ljh.1\n\tfor ;\n\tFri, 19 Feb 2021 06:38:14 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tn7sm940828lfu.123.2021.02.19.06.38.12\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 19 Feb 2021 06:38:12 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"HwV+AidV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=lISADhMuNX3pd3UrBYofGzRNaAAaf3kw+mi0HG1sT7A=;\n\tb=HwV+AidVRABCtkupqRu4NHIOqrQSjBiUWHl9kWUfIs4l8KCyQxG16eEift5yCnR2CR\n\tqO7oooCd/NnwvQDawdcQXB4KJG82r/k7noS4hEHnF30FJYKKWDoSFHH26ITCs/RwFxMw\n\tQ9L9cBc0iLzsfrlLth9G7BBhHzAL0sUySmvXlEMX088PVBB2offu2kl6jZpvSbdLZAZC\n\txPIRXjE82st0nUrOFGLV0oBAOXo8VdFuH2h7mpL0yynMhuV0lOrMy8nf9hBqnsNWShyO\n\ttkhmq4jYpUgEzNvQdbHPTUH3dx8aYaS5GeuHusSoSXRTeQXbF1QqWMsf6ilWKwtkZyom\n\tQ+Tg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=lISADhMuNX3pd3UrBYofGzRNaAAaf3kw+mi0HG1sT7A=;\n\tb=WC87n6vXZPW3CPcDGP2r9Hk8dXt4TBWYw5a2A7M/ge8PIK/owF+22J8prkFPJWKkaa\n\trnW5NIML8n4XzuHolr9kOomuChDBtHy5/J8qTCgLConxjCRYee2IhgIz3OLtsi+AsJV6\n\tjbfxjkUqNSwxYhD7SBFjcB0F3e6F6RqApxz6SNZiaiMUs+AEpo0dzHF1QGT/5bWLG5Ss\n\tEijDt6QHIzV1YfJnllKU6kuX3fgNMcfd4juzMUl5+XnvxWQtapEM7HfsikndlVFvQBlT\n\tykpzMlp53t/3phIrQ4yHs19jaxIDFInv/mDJKwzDIF5iIbod/o7IN8zFgqB4RqS6/eAn\n\tF2wg==","X-Gm-Message-State":"AOAM531kz4zR7AnJgvozW2VNboOoB+8DiPk8QN1k6eFFd4cP2JUMgf6D\n\t+RotoQEIxK6UO/Io9kP8T7C8WsSqxrc19BCX","X-Google-Smtp-Source":"ABdhPJx/l4xPquNY18GzSyXTzVGMmaxicndfpJBgQaOVu+v9TqDRxZCnXVWRyZZVSZkvI4rBylz8ow==","X-Received":"by 2002:a05:651c:315:: with SMTP id\n\ta21mr5819814ljp.407.1613745493648; \n\tFri, 19 Feb 2021 06:38:13 -0800 (PST)","Date":"Fri, 19 Feb 2021 15:38:11 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Paul Elder ","Message-ID":"","References":"<20210219104544.53217-1-paul.elder@ideasonboard.com>\n\t<20210219104544.53217-3-paul.elder@ideasonboard.com>\n\t<705b01ed-b1c6-607a-5ad5-a2f022ea9a60@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<705b01ed-b1c6-607a-5ad5-a2f022ea9a60@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] android: camera_device: Set the\n\tcamera location to Front if External","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15260,"web_url":"https://patchwork.libcamera.org/comment/15260/","msgid":"","date":"2021-02-21T19:21:05","subject":"Re: [libcamera-devel] [PATCH 2/2] android: camera_device: Set the\n\tcamera location to Front if External","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hello,\n\nOn Fri, Feb 19, 2021 at 11:05:14AM +0000, Kieran Bingham wrote:\n> On 19/02/2021 10:45, Paul Elder wrote:\n> > Our android HAL implementation currently does not support external\n> > cameras, so if the camera location property is external, set it to\n> > front.\n> > \n> > This allows the following CTS test to pass:\n> > - android.hardware.camera2.cts.CameraManagerTest#testCameraManagerGetDeviceIdList\n> > \n> > Signed-off-by: Paul Elder \n> > ---\n> > src/android/camera_device.cpp | 6 +++++-\n> > 1 file changed, 5 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index 1e2a5b5f..16cb8c6d 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -405,7 +405,11 @@ int CameraDevice::initialize()\n> > \t\t\tfacing_ = CAMERA_FACING_BACK;\n> > \t\t\tbreak;\n> > \t\tcase properties::CameraLocationExternal:\n> > -\t\t\tfacing_ = CAMERA_FACING_EXTERNAL;\n> > +\t\t\t/*\n> > +\t\t\t * \\todo Set this to EXTERNAL once we support\n> > +\t\t\t * HARDWARE_LEVEL_EXTERNAL\n> > +\t\t\t */\n> > +\t\t\tfacing_ = CAMERA_FACING_FRONT;\n> \n> I would be tempted to add a warning log here too, as it's distinctly\n> separate from the setting of the properties::CameraLocationExternal,\n> which can certainly be correctly set to External (on UVC) for example,\n> but which would come through here.\n\nIt's a todo item, and we have lots of them for which we don't print any\nwarning. I'm not sure to see why this one would be special.\n\nReviewed-by: Laurent Pinchart \n\n> I hadn't realised/been aware of this HARDWARE_LEVEL_EXTERNAL issues, I\n> wonder if that was some how related to the difficulties we still had in\n> even getting a Brio YUV UVC camera to work.\n> \n> I suspect it is, as perhaps with HARDWARE_LEVEL_EXTERNAL we can better\n> define the actual capabilities /streams of the external device.\n> \n> \n> Anyway, with or without the warning added, as this is a known workaround:\n> \n> Reviewed-by: Kieran Bingham \n> \n> > \t\t\tbreak;\n> > \t\t}\n> > \t}","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6343EBD1F1\n\tfor ;\n\tSun, 21 Feb 2021 19:21:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CC6E2689E7;\n\tSun, 21 Feb 2021 20:21:33 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A61BE689C2\n\tfor ;\n\tSun, 21 Feb 2021 20:21:32 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 089F8EF;\n\tSun, 21 Feb 2021 20:21:31 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OVwUev8p\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613935292;\n\tbh=3kK1rvxd2Q5Yj5/HMFqL7huEenj4wMZB8VmS54kkfoc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=OVwUev8pdBDACmFUYK0VO2RwLktT12tf6WH6GE0VXCO8+osC5QSUCZ1Kh9ng8yqvK\n\tuTsFRkIlT6sp1o0F/S+o+AiJA+1eaig//NrVmq0ZIXj5CGq34A1iso0zKgxoSgrzl8\n\tAp2Z3I3pdrDw19IB/b5c/a2ZeSGF4tT4DuqSMv6M=","Date":"Sun, 21 Feb 2021 21:21:05 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210219104544.53217-1-paul.elder@ideasonboard.com>\n\t<20210219104544.53217-3-paul.elder@ideasonboard.com>\n\t<705b01ed-b1c6-607a-5ad5-a2f022ea9a60@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<705b01ed-b1c6-607a-5ad5-a2f022ea9a60@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] android: camera_device: Set the\n\tcamera location to Front if External","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15276,"web_url":"https://patchwork.libcamera.org/comment/15276/","msgid":"<56881ee6-f04a-a0d8-3d92-b142d49dfc0e@ideasonboard.com>","date":"2021-02-22T09:27:25","subject":"Re: [libcamera-devel] [PATCH 2/2] android: camera_device: Set the\n\tcamera location to Front if External","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 21/02/2021 19:21, Laurent Pinchart wrote:\n> Hello,\n> \n> On Fri, Feb 19, 2021 at 11:05:14AM +0000, Kieran Bingham wrote:\n>> On 19/02/2021 10:45, Paul Elder wrote:\n>>> Our android HAL implementation currently does not support external\n>>> cameras, so if the camera location property is external, set it to\n>>> front.\n>>>\n>>> This allows the following CTS test to pass:\n>>> - android.hardware.camera2.cts.CameraManagerTest#testCameraManagerGetDeviceIdList\n>>>\n>>> Signed-off-by: Paul Elder \n>>> ---\n>>> src/android/camera_device.cpp | 6 +++++-\n>>> 1 file changed, 5 insertions(+), 1 deletion(-)\n>>>\n>>> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n>>> index 1e2a5b5f..16cb8c6d 100644\n>>> --- a/src/android/camera_device.cpp\n>>> +++ b/src/android/camera_device.cpp\n>>> @@ -405,7 +405,11 @@ int CameraDevice::initialize()\n>>> \t\t\tfacing_ = CAMERA_FACING_BACK;\n>>> \t\t\tbreak;\n>>> \t\tcase properties::CameraLocationExternal:\n>>> -\t\t\tfacing_ = CAMERA_FACING_EXTERNAL;\n>>> +\t\t\t/*\n>>> +\t\t\t * \\todo Set this to EXTERNAL once we support\n>>> +\t\t\t * HARDWARE_LEVEL_EXTERNAL\n>>> +\t\t\t */\n>>> +\t\t\tfacing_ = CAMERA_FACING_FRONT;\n>>\n>> I would be tempted to add a warning log here too, as it's distinctly\n>> separate from the setting of the properties::CameraLocationExternal,\n>> which can certainly be correctly set to External (on UVC) for example,\n>> but which would come through here.\n> \n> It's a todo item, and we have lots of them for which we don't print any\n> warning. I'm not sure to see why this one would be special.\n\nBecause this one impacts the actual expected output. An 'External'\ncamera is being renamed / replaced to being 'Front'.\n\nIf this was explicitly set (for example, an RPi, or UVC camera) we're\nchanging the reported location.\n\nConsider that the user *expected* this camera to be external, and yet\nwhen run through the HAL was always reported 'Front'. - It's that\n*change* which makes me think a warning is worth printing. It's not\nabout having a todo action, it's reporting that something unexpectedly\nchanged internally.\n\n\n> Reviewed-by: Laurent Pinchart \n> \n>> I hadn't realised/been aware of this HARDWARE_LEVEL_EXTERNAL issues, I\n>> wonder if that was some how related to the difficulties we still had in\n>> even getting a Brio YUV UVC camera to work.\n>>\n>> I suspect it is, as perhaps with HARDWARE_LEVEL_EXTERNAL we can better\n>> define the actual capabilities /streams of the external device.\n\n\nBut as I said:\n\n\n>> Anyway, with or without the warning added, as this is a known workaround:\n>>\n>> Reviewed-by: Kieran Bingham \n>>\n>>> \t\t\tbreak;\n>>> \t\t}\n>>> \t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8E6C6BD1F6\n\tfor ;\n\tMon, 22 Feb 2021 09:27:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CDC2668A00;\n\tMon, 22 Feb 2021 10:27:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 84300602F3\n\tfor ;\n\tMon, 22 Feb 2021 10:27:29 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DE0A8344;\n\tMon, 22 Feb 2021 10:27:28 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"k6tW6Hrg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613986049;\n\tbh=HNhcwS238cqipTKRmawiATJ1AIKBBieZJyfxczZ68wQ=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=k6tW6HrggYAt40Bv0jI/P0GOMPFi0cquyULixYOzWYEPrH5UT7kqw0UZjdYduYS7N\n\t6FCORz4KMhKBihyXv7VuVlL4u91+eAa97ifPLRO6gXZMxdm60aXc59Ipmjuoykv0bh\n\tOxd0MsgSoMpY53P9YTQBrnVAtAY5UYSLM3EOSoZU=","To":"Laurent Pinchart ","References":"<20210219104544.53217-1-paul.elder@ideasonboard.com>\n\t<20210219104544.53217-3-paul.elder@ideasonboard.com>\n\t<705b01ed-b1c6-607a-5ad5-a2f022ea9a60@ideasonboard.com>\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<56881ee6-f04a-a0d8-3d92-b142d49dfc0e@ideasonboard.com>","Date":"Mon, 22 Feb 2021 09:27:25 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 2/2] android: camera_device: Set the\n\tcamera location to Front if External","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]