{"id":11343,"url":"https://patchwork.libcamera.org/api/patches/11343/?format=json","web_url":"https://patchwork.libcamera.org/patch/11343/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210219104544.53217-3-paul.elder@ideasonboard.com>","date":"2021-02-19T10:45:44","name":"[libcamera-devel,2/2] android: camera_device: Set the camera location to Front if External","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"3c9721b9aac416f17b71c0a1160ba8f0722a5fa7","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11343/mbox/","series":[{"id":1709,"url":"https://patchwork.libcamera.org/api/series/1709/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1709","date":"2021-02-19T10:45:42","name":"Fix camera location","version":1,"mbox":"https://patchwork.libcamera.org/series/1709/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11343/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11343/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C9E6EBD1F6\n\tfor ;\n\tFri, 19 Feb 2021 10:46:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9746D689C8;\n\tFri, 19 Feb 2021 11:46:14 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 39C98637DC\n\tfor ;\n\tFri, 19 Feb 2021 11:46:13 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 68498344;\n\tFri, 19 Feb 2021 11:46:08 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KPeSlAI3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613731573;\n\tbh=W3r+WKNljymOheyfkikHTjWjg447QdPiswaNNTRkXfo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=KPeSlAI332dzvAVN8dn/De1vu1rxqGy5YUQVJ2+daq90zJulUFBhQuVQfKu6EXVZC\n\tKU2bofhvcv1gh5Zn9EhYGvfaDWArZZgcZXCGH/uDM8pfWqkdWaOMTftB4HDSHM3Ixu\n\tHWyoYHDdjhsjWjpJyFOUaUegqRcXMagJThOqz9oE=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 19 Feb 2021 19:45:44 +0900","Message-Id":"<20210219104544.53217-3-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210219104544.53217-1-paul.elder@ideasonboard.com>","References":"<20210219104544.53217-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 2/2] android: camera_device: Set the\n\tcamera location to Front if External","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Our android HAL implementation currently does not support external\ncameras, so if the camera location property is external, set it to\nfront.\n\nThis allows the following CTS test to pass:\n- android.hardware.camera2.cts.CameraManagerTest#testCameraManagerGetDeviceIdList\n\nSigned-off-by: Paul Elder \n---\n src/android/camera_device.cpp | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 1e2a5b5f..16cb8c6d 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -405,7 +405,11 @@ int CameraDevice::initialize()\n \t\t\tfacing_ = CAMERA_FACING_BACK;\n \t\t\tbreak;\n \t\tcase properties::CameraLocationExternal:\n-\t\t\tfacing_ = CAMERA_FACING_EXTERNAL;\n+\t\t\t/*\n+\t\t\t * \\todo Set this to EXTERNAL once we support\n+\t\t\t * HARDWARE_LEVEL_EXTERNAL\n+\t\t\t */\n+\t\t\tfacing_ = CAMERA_FACING_FRONT;\n \t\t\tbreak;\n \t\t}\n \t}\n","prefixes":["libcamera-devel","2/2"]}