[{"id":15234,"web_url":"https://patchwork.libcamera.org/comment/15234/","msgid":"<2acb88d0-5cc9-1031-8233-8b4b70058feb@ideasonboard.com>","date":"2021-02-19T10:58:55","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: camera_sensor: Print\n\twarning when orientation is unknown","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 19/02/2021 10:45, Paul Elder wrote:\n> Print a warining when the orientation of a sensor is unknown. The\n\ns/warining/warning/\n\n> location property is still defaulted to external.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/camera_sensor.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index c9e8d49b..397df266 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -446,6 +446,8 @@ int CameraSensor::initProperties()\n> \t\t\tbreak;\n> \t\t}\n> \t} else {\n> +\t\tLOG(CameraSensor, Warning)\n> +\t\t\t<< \"No camera location, setting to External\";\n> \t\tpropertyValue = properties::CameraLocationExternal;\n> \t}\n> \tproperties_.set(properties::Location, propertyValue);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 74FACBD1F1\n\tfor ;\n\tFri, 19 Feb 2021 10:59:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 01837689C2;\n\tFri, 19 Feb 2021 11:59:00 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B523D60106\n\tfor ;\n\tFri, 19 Feb 2021 11:58:58 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2330D596;\n\tFri, 19 Feb 2021 11:58:58 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HIeqlHmn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613732338;\n\tbh=YXcZ5FIWfONL6Nrs+dKN9DuGK3gEmoxdco7FM6XSb9U=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=HIeqlHmnOsH3OBfPt4N5pAhW0y9tz7wG4DounDDgzz2KkUvicwjRCigTxcSRhApGs\n\tY68OlXsv41efz1CI46l0dWHBeqX4IGzMjCOyChNoWqCSL75A8EryR/FJdzDvkLMaeL\n\tbVJDdyuzBOLiDP9eTDhfQSbo9RLJnnvOM1gSdM9g=","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210219104544.53217-1-paul.elder@ideasonboard.com>\n\t<20210219104544.53217-2-paul.elder@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<2acb88d0-5cc9-1031-8233-8b4b70058feb@ideasonboard.com>","Date":"Fri, 19 Feb 2021 10:58:55 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210219104544.53217-2-paul.elder@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: camera_sensor: Print\n\twarning when orientation is unknown","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15242,"web_url":"https://patchwork.libcamera.org/comment/15242/","msgid":"","date":"2021-02-19T14:36:19","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: camera_sensor: Print\n\twarning when orientation is unknown","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Paul,\n\nThanks for your patch.\n\nOn 2021-02-19 19:45:43 +0900, Paul Elder wrote:\n> Print a warining when the orientation of a sensor is unknown. The\n> location property is still defaulted to external.\n> \n> Signed-off-by: Paul Elder \n> ---\n> src/libcamera/camera_sensor.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index c9e8d49b..397df266 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -446,6 +446,8 @@ int CameraSensor::initProperties()\n> \t\t\tbreak;\n> \t\t}\n> \t} else {\n> +\t\tLOG(CameraSensor, Warning)\n> +\t\t\t<< \"No camera location, setting to External\";\n\nI think we should mimic validateSensorDriver() here to really push for \nthat this should be fixed.\n\n ret = subdev_->getSelection(pad_, V4L2_SEL_TGT_CROP, &rect);\n if (ret) {\n\t LOG(CameraSensor, Warning)\n\t\t << \"Failed to retrieve the sensor crop rectangle\";\n\t err = -EINVAL;\n }\n\n if (err) {\n\t LOG(CameraSensor, Warning)\n\t\t << \"The sensor kernel driver needs to be fixed\";\n\t LOG(CameraSensor, Warning)\n\t\t << \"See Documentation/sensor_driver_requirements.rst in the libcamera sources for more information\";\n }\n\n> \t\tpropertyValue = properties::CameraLocationExternal;\n> \t}\n> \tproperties_.set(properties::Location, propertyValue);\n> -- \n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AC875BD1F6\n\tfor ;\n\tFri, 19 Feb 2021 14:36:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3EEDA602F5;\n\tFri, 19 Feb 2021 15:36:24 +0100 (CET)","from mail-lj1-x233.google.com (mail-lj1-x233.google.com\n\t[IPv6:2a00:1450:4864:20::233])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 890D3602F5\n\tfor ;\n\tFri, 19 Feb 2021 15:36:22 +0100 (CET)","by mail-lj1-x233.google.com with SMTP id y7so19506733lji.7\n\tfor ;\n\tFri, 19 Feb 2021 06:36:22 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\t199sm978679ljf.118.2021.02.19.06.36.19\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 19 Feb 2021 06:36:19 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"W+IIuOGF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=qCV8M4MmuUSjZ4DB8OBnCH8c/52hSEvjqNKOpkMVCh8=;\n\tb=W+IIuOGFmIaP8Y8r8DOamwQNP4WRq3X2qcEim6ioOZOAQpA8eTos1zmxOjC3e7//0G\n\tVOFF2deu8KYfusONH0pjD8afp+jx14gC3xMMnFIU0vX+aJYC2P3VGU2GR0ybIVJ0jP8Z\n\tnKzmxO1RXbn4+7Ltr0NORn/cMpkb3symwYxPOeNYs06Kfn4Ou2fv9b3xqxxa5sfu5DUZ\n\tTDdeGPx9FVaAqxZLfHeSBmau1Z+mlS3GX7hYQ/tjvqnC4pRma/wHzEUoAm2fSGHQ58iF\n\t9Sr5o3LfosOPb4Mdpf08+Oj5xnQdoO+c8l0iPQ2yYXK5zNBg6PTMzcnnbe4WQy0Qkohs\n\t72Ug==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=qCV8M4MmuUSjZ4DB8OBnCH8c/52hSEvjqNKOpkMVCh8=;\n\tb=oA1SqBuyync508aXkuLAQsbrxFNwJuUs/DU5iTh92MHlErHHbq525N16Xg0HCkSX6d\n\tODt05Edo7ZVppwgZ4/Hdng4SMaadufPg+FlVVSSHg5MU/Se2dT3MycArnXyATnB9pvRj\n\tYRR7YCNmK5oEtfEJkbqptlnocEa62voK7HblTgJwQQj3dDQRf6LAZmRnjB6G8+dQr3Ls\n\t4jGEty39+x59w8HIDvTH9+DIwiKi9J7IYWwsNh/OhXO6FiCuyCgSunYK7w4wxf1u54lI\n\tr+g4MBWu/fIjbug8aLLGfOzSntWSrQDb9wfD5kUG+0Y39EFaTqh1JT1CAZ0McfuNIrTl\n\tNZYg==","X-Gm-Message-State":"AOAM531DU59WTciz42PGiprxVeW3FsFsr//0ZI6ZJZHNZm+u65Ro6hrS\n\tFY4lp8INxE/ijZmf31e5FIfEfwUz2UhW3dza","X-Google-Smtp-Source":"ABdhPJyupzlXR8/3UrCtQEhrXqaT+XxiQ1qXxqZmyiFUKNZC4RH0kNuOmO/3PDPXMiv2LH/2k5dPmA==","X-Received":"by 2002:ac2:464b:: with SMTP id s11mr3817324lfo.11.1613745381916;\n\tFri, 19 Feb 2021 06:36:21 -0800 (PST)","Date":"Fri, 19 Feb 2021 15:36:19 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Paul Elder ","Message-ID":"","References":"<20210219104544.53217-1-paul.elder@ideasonboard.com>\n\t<20210219104544.53217-2-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210219104544.53217-2-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: camera_sensor: Print\n\twarning when orientation is unknown","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15245,"web_url":"https://patchwork.libcamera.org/comment/15245/","msgid":"<7a857c46-b6dc-600a-a215-486607ddfc2b@ideasonboard.com>","date":"2021-02-19T16:49:32","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: camera_sensor: Print\n\twarning when orientation is unknown","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 19/02/2021 14:36, Niklas Söderlund wrote:\n> Hi Paul,\n> \n> Thanks for your patch.\n> \n> On 2021-02-19 19:45:43 +0900, Paul Elder wrote:\n>> Print a warining when the orientation of a sensor is unknown. The\n>> location property is still defaulted to external.\n>>\n>> Signed-off-by: Paul Elder \n>> ---\n>> src/libcamera/camera_sensor.cpp | 2 ++\n>> 1 file changed, 2 insertions(+)\n>>\n>> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n>> index c9e8d49b..397df266 100644\n>> --- a/src/libcamera/camera_sensor.cpp\n>> +++ b/src/libcamera/camera_sensor.cpp\n>> @@ -446,6 +446,8 @@ int CameraSensor::initProperties()\n>> \t\t\tbreak;\n>> \t\t}\n>> \t} else {\n>> +\t\tLOG(CameraSensor, Warning)\n>> +\t\t\t<< \"No camera location, setting to External\";\n> \n> I think we should mimic validateSensorDriver() here to really push for \n> that this should be fixed.\n> \n> ret = subdev_->getSelection(pad_, V4L2_SEL_TGT_CROP, &rect);\n> if (ret) {\n> \t LOG(CameraSensor, Warning)\n> \t\t << \"Failed to retrieve the sensor crop rectangle\";\n> \t err = -EINVAL;\n> }\n> \n> if (err) {\n> \t LOG(CameraSensor, Warning)\n> \t\t << \"The sensor kernel driver needs to be fixed\";\n> \t LOG(CameraSensor, Warning)\n> \t\t << \"See Documentation/sensor_driver_requirements.rst in the libcamera sources for more information\";\n\nAs annoying as those messages are, I think that's a good idea ;-)\n\nShould they be 'Error' instead of 'Warning' too if we want to be really\nloud?\n\n--\nKieran\n\n\n\n> }\n> \n>> \t\tpropertyValue = properties::CameraLocationExternal;\n>> \t}\n>> \tproperties_.set(properties::Location, propertyValue);\n>> -- \n>> 2.27.0\n>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D36DDBD1F6\n\tfor ;\n\tFri, 19 Feb 2021 16:49:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 48766689D3;\n\tFri, 19 Feb 2021 17:49:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 516D8602F5\n\tfor ;\n\tFri, 19 Feb 2021 17:49:36 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A70D6596;\n\tFri, 19 Feb 2021 17:49:35 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZdCvK+l4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613753375;\n\tbh=jdzg1YqTXSlEgd89xROZ1Uas9x4dBeyAtf8Q7P2VLys=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=ZdCvK+l4TaujPXjzHLUdxYfeX/rSqcn7f4FxQQmB5BaaOu2FEJVqX8kZI3rzOhfLe\n\tievrEZuhR0rNIfZC2S6pI2iWWqpEe7sDAiJUYcp6zPtZgarBf86Yi4kANTc/qB6NI/\n\tciLzIkzaLgaHXUeQK7NcMdQ18kyhM+1hciqaVlgs=","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\tPaul Elder ","References":"<20210219104544.53217-1-paul.elder@ideasonboard.com>\n\t<20210219104544.53217-2-paul.elder@ideasonboard.com>\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<7a857c46-b6dc-600a-a215-486607ddfc2b@ideasonboard.com>","Date":"Fri, 19 Feb 2021 16:49:32 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: camera_sensor: Print\n\twarning when orientation is unknown","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15251,"web_url":"https://patchwork.libcamera.org/comment/15251/","msgid":"","date":"2021-02-19T17:19:36","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: camera_sensor: Print\n\twarning when orientation is unknown","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hello,\n\nOn 2021-02-19 16:49:32 +0000, Kieran Bingham wrote:\n> On 19/02/2021 14:36, Niklas Söderlund wrote:\n> > Hi Paul,\n> > \n> > Thanks for your patch.\n> > \n> > On 2021-02-19 19:45:43 +0900, Paul Elder wrote:\n> >> Print a warining when the orientation of a sensor is unknown. The\n> >> location property is still defaulted to external.\n> >>\n> >> Signed-off-by: Paul Elder \n> >> ---\n> >> src/libcamera/camera_sensor.cpp | 2 ++\n> >> 1 file changed, 2 insertions(+)\n> >>\n> >> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> >> index c9e8d49b..397df266 100644\n> >> --- a/src/libcamera/camera_sensor.cpp\n> >> +++ b/src/libcamera/camera_sensor.cpp\n> >> @@ -446,6 +446,8 @@ int CameraSensor::initProperties()\n> >> \t\t\tbreak;\n> >> \t\t}\n> >> \t} else {\n> >> +\t\tLOG(CameraSensor, Warning)\n> >> +\t\t\t<< \"No camera location, setting to External\";\n> > \n> > I think we should mimic validateSensorDriver() here to really push for \n> > that this should be fixed.\n> > \n> > ret = subdev_->getSelection(pad_, V4L2_SEL_TGT_CROP, &rect);\n> > if (ret) {\n> > \t LOG(CameraSensor, Warning)\n> > \t\t << \"Failed to retrieve the sensor crop rectangle\";\n> > \t err = -EINVAL;\n> > }\n> > \n> > if (err) {\n> > \t LOG(CameraSensor, Warning)\n> > \t\t << \"The sensor kernel driver needs to be fixed\";\n> > \t LOG(CameraSensor, Warning)\n> > \t\t << \"See Documentation/sensor_driver_requirements.rst in the libcamera sources for more information\";\n> \n> As annoying as those messages are, I think that's a good idea ;-)\n> \n> Should they be 'Error' instead of 'Warning' too if we want to be really\n> loud?\n\nI think this is a bikeshedding area. So to make it even more fun I throw \nin the idea of adding a new LOG level, Depreciated. This type of log \nmessages exists in other tools and I find them really useful.\n\nThe tool which comes to mind first is ansible. Once they decide a \nfeature is being removed or changed they add Depreciated warning when \nit's used in the soon to be removed fashion. Then in a few releases they \nturn the warning into a Fatal. This gives me as a user quiet some time \nto fix my setup to not be effected when upstream moves on.\n\nBut as with most bikeshedding I don't feel strongly about it. All I care \nabout is that we behave consistently. So if we switch to Error in this \npatch I think the LOG in validateSensorDriver() also should be updated \nto match.\n\n> \n> --\n> Kieran\n> \n> \n> \n> > }\n> > \n> >> \t\tpropertyValue = properties::CameraLocationExternal;\n> >> \t}\n> >> \tproperties_.set(properties::Location, propertyValue);\n> >> -- \n> >> 2.27.0\n> >>\n> >> _______________________________________________\n> >> libcamera-devel mailing list\n> >> libcamera-devel@lists.libcamera.org\n> >> https://lists.libcamera.org/listinfo/libcamera-devel\n> > \n> \n> -- \n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A4AB8BD1F1\n\tfor ;\n\tFri, 19 Feb 2021 17:19:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7023B689D8;\n\tFri, 19 Feb 2021 18:19:39 +0100 (CET)","from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com\n\t[IPv6:2a00:1450:4864:20::22d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EF787689CD\n\tfor ;\n\tFri, 19 Feb 2021 18:19:38 +0100 (CET)","by mail-lj1-x22d.google.com with SMTP id o16so19129902ljj.11\n\tfor ;\n\tFri, 19 Feb 2021 09:19:38 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\ta20sm305106lji.77.2021.02.19.09.19.36\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 19 Feb 2021 09:19:36 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"hKqZxnpm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=P0yvRQ6Q7OX71MnZuy86IYAT4RnvlpNLdbeq/eFGCcI=;\n\tb=hKqZxnpmNKsKy8Bl9QK6adBkV35nGKCHUl0dr7D870r/gbxCNMrj5iDDuHltuinw8g\n\t8g4xR1Jalib5s9dR6Sj0Ymdaitb5capsUP6KcHrjYIa2wG7hNIam77I5TYOizld8oT43\n\tA621mWAX8bQf4eo2YsAo3YO3KCSXyZyJpJJjt7TDewC7JYzCHDIlg06bHG43aZEHEBCq\n\tP9vQAI66OmnkaRCmBjiJWNhNSUByOawI4pr3Au4NuIGUHOkU/Jx6aOoAY+ViLo/FRvZu\n\tc/xV3E5E57Cin+2sLKYs86HuiECKuJG/ZxaRjuPuj+aPTR0tW+PxdC6dXLUQGkCUITDk\n\t9OPA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=P0yvRQ6Q7OX71MnZuy86IYAT4RnvlpNLdbeq/eFGCcI=;\n\tb=BJ+/Qui4b7ErgtO3zCBTyQHN4nt9q3Wi/QT9K/d37rHZrDOCZljxz6ZtbXgxNt8i8p\n\t61zOGACerzYw/gBGFKVmUnn2KNp6yQeJXS8ENyRF2luNKAt5yqJBBQ+DTO9dy/ogzhq4\n\tVy/lMo9VKg+u7SRBPbehYs89YA4dJbbyCWTpR8bYIEvodeeaFT+LX4chhdQBnBtPtg/1\n\t0hgnyG1JetSHP6SAY0KiteRhPcZfqgAwhIzVs6HZR3FxbM1eTEHSZq3sMcrVkhcZcY/6\n\t6qsbrUNiqcIke+MRsJNQpOwFQtdS2DCFMw+HH2o/Wu38/PkL9izxWyumwiwtlWtgAaGm\n\tvllA==","X-Gm-Message-State":"AOAM531dOkwRewdMAhVGhjBOxe9SVjtwE8yaCvVM0ZzoBJgXfyBw6ZNT\n\tJJsFnhRd+ImYfxzMqSpwOHRXeTfh8Vm0T0O/","X-Google-Smtp-Source":"ABdhPJyXh18RXZgQdXCBkbO1pFoswBTIJ7Fc+e6SgACyLCr0vMMdU0LXyjVkj47c0GOmz2J7TYpe9g==","X-Received":"by 2002:a2e:b5b4:: with SMTP id\n\tf20mr3447620ljn.445.1613755178462; \n\tFri, 19 Feb 2021 09:19:38 -0800 (PST)","Date":"Fri, 19 Feb 2021 18:19:36 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Message-ID":"","References":"<20210219104544.53217-1-paul.elder@ideasonboard.com>\n\t<20210219104544.53217-2-paul.elder@ideasonboard.com>\n\t\n\t<7a857c46-b6dc-600a-a215-486607ddfc2b@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<7a857c46-b6dc-600a-a215-486607ddfc2b@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: camera_sensor: Print\n\twarning when orientation is unknown","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15259,"web_url":"https://patchwork.libcamera.org/comment/15259/","msgid":"","date":"2021-02-21T19:16:36","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: camera_sensor: Print\n\twarning when orientation is unknown","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nOn Fri, Feb 19, 2021 at 06:19:36PM +0100, Niklas Söderlund wrote:\n> On 2021-02-19 16:49:32 +0000, Kieran Bingham wrote:\n> > On 19/02/2021 14:36, Niklas Söderlund wrote:\n> > > On 2021-02-19 19:45:43 +0900, Paul Elder wrote:\n> > >> Print a warining when the orientation of a sensor is unknown. The\n> > >> location property is still defaulted to external.\n> > >>\n> > >> Signed-off-by: Paul Elder \n> > >> ---\n> > >> src/libcamera/camera_sensor.cpp | 2 ++\n> > >> 1 file changed, 2 insertions(+)\n> > >>\n> > >> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> > >> index c9e8d49b..397df266 100644\n> > >> --- a/src/libcamera/camera_sensor.cpp\n> > >> +++ b/src/libcamera/camera_sensor.cpp\n> > >> @@ -446,6 +446,8 @@ int CameraSensor::initProperties()\n> > >> \t\t\tbreak;\n> > >> \t\t}\n> > >> \t} else {\n> > >> +\t\tLOG(CameraSensor, Warning)\n> > >> +\t\t\t<< \"No camera location, setting to External\";\n> > > \n> > > I think we should mimic validateSensorDriver() here to really push for \n> > > that this should be fixed.\n> > > \n> > > ret = subdev_->getSelection(pad_, V4L2_SEL_TGT_CROP, &rect);\n> > > if (ret) {\n> > > \t LOG(CameraSensor, Warning)\n> > > \t\t << \"Failed to retrieve the sensor crop rectangle\";\n> > > \t err = -EINVAL;\n> > > }\n> > > \n> > > if (err) {\n> > > \t LOG(CameraSensor, Warning)\n> > > \t\t << \"The sensor kernel driver needs to be fixed\";\n> > > \t LOG(CameraSensor, Warning)\n> > > \t\t << \"See Documentation/sensor_driver_requirements.rst in the libcamera sources for more information\";\n> > \n> > As annoying as those messages are, I think that's a good idea ;-)\n> > \n> > Should they be 'Error' instead of 'Warning' too if we want to be really\n> > loud?\n> \n> I think this is a bikeshedding area. So to make it even more fun I throw \n> in the idea of adding a new LOG level, Depreciated. This type of log \n> messages exists in other tools and I find them really useful.\n> \n> The tool which comes to mind first is ansible. Once they decide a \n> feature is being removed or changed they add Depreciated warning when \n> it's used in the soon to be removed fashion. Then in a few releases they \n> turn the warning into a Fatal. This gives me as a user quiet some time \n> to fix my setup to not be effected when upstream moves on.\n\nIt's an interesting idea, but given that our log levels mechanism is\nbased on an integer level from least important (Debug) to most important\n(Fatak), I wonder where you would put the deprecated level in that range\n:-)\n\n> But as with most bikeshedding I don't feel strongly about it. All I care \n> about is that we behave consistently. So if we switch to Error in this \n> patch I think the LOG in validateSensorDriver() also should be updated \n> to match.\n\nI'd keep Warning here, as it's not an error (yet), we can still operate.\n\n> > > }\n> > > \n> > >> \t\tpropertyValue = properties::CameraLocationExternal;\n> > >> \t}\n> > >> \tproperties_.set(properties::Location, propertyValue);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 636F2BD1F6\n\tfor ;\n\tSun, 21 Feb 2021 19:17:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BEC13689E3;\n\tSun, 21 Feb 2021 20:17:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7209B689C2\n\tfor ;\n\tSun, 21 Feb 2021 20:17:03 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CFB628D8;\n\tSun, 21 Feb 2021 20:17:02 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"M3Uky7Ih\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613935023;\n\tbh=9NA39OuRJBPgv7/yXRaOdEKBhqx+fYoWHAnT8bTCRSk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=M3Uky7Ihw29jo9MXwm+Zavy6wq+CRxYUaXJW1aFiD/UZxKkP1y2slgxedwdcAv4/T\n\tJm92pSU8Xrme67plr9Z+2ryEexFkkvqm4Pthd36VsDSki8r0SUMF+R+D93iQTpboDY\n\tQzJa6+gXGoGubtz67Y936wMhYUKnO8dFP3muIZgo=","Date":"Sun, 21 Feb 2021 21:16:36 +0200","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"","References":"<20210219104544.53217-1-paul.elder@ideasonboard.com>\n\t<20210219104544.53217-2-paul.elder@ideasonboard.com>\n\t\n\t<7a857c46-b6dc-600a-a215-486607ddfc2b@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: camera_sensor: Print\n\twarning when orientation is unknown","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15264,"web_url":"https://patchwork.libcamera.org/comment/15264/","msgid":"","date":"2021-02-21T22:17:28","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: camera_sensor: Print\n\twarning when orientation is unknown","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nOn 2021-02-21 21:16:36 +0200, Laurent Pinchart wrote:\n> Hi Niklas,\n> \n> On Fri, Feb 19, 2021 at 06:19:36PM +0100, Niklas Söderlund wrote:\n> > On 2021-02-19 16:49:32 +0000, Kieran Bingham wrote:\n> > > On 19/02/2021 14:36, Niklas Söderlund wrote:\n> > > > On 2021-02-19 19:45:43 +0900, Paul Elder wrote:\n> > > >> Print a warining when the orientation of a sensor is unknown. The\n> > > >> location property is still defaulted to external.\n> > > >>\n> > > >> Signed-off-by: Paul Elder \n> > > >> ---\n> > > >> src/libcamera/camera_sensor.cpp | 2 ++\n> > > >> 1 file changed, 2 insertions(+)\n> > > >>\n> > > >> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> > > >> index c9e8d49b..397df266 100644\n> > > >> --- a/src/libcamera/camera_sensor.cpp\n> > > >> +++ b/src/libcamera/camera_sensor.cpp\n> > > >> @@ -446,6 +446,8 @@ int CameraSensor::initProperties()\n> > > >> \t\t\tbreak;\n> > > >> \t\t}\n> > > >> \t} else {\n> > > >> +\t\tLOG(CameraSensor, Warning)\n> > > >> +\t\t\t<< \"No camera location, setting to External\";\n> > > > \n> > > > I think we should mimic validateSensorDriver() here to really push for \n> > > > that this should be fixed.\n> > > > \n> > > > ret = subdev_->getSelection(pad_, V4L2_SEL_TGT_CROP, &rect);\n> > > > if (ret) {\n> > > > \t LOG(CameraSensor, Warning)\n> > > > \t\t << \"Failed to retrieve the sensor crop rectangle\";\n> > > > \t err = -EINVAL;\n> > > > }\n> > > > \n> > > > if (err) {\n> > > > \t LOG(CameraSensor, Warning)\n> > > > \t\t << \"The sensor kernel driver needs to be fixed\";\n> > > > \t LOG(CameraSensor, Warning)\n> > > > \t\t << \"See Documentation/sensor_driver_requirements.rst in the libcamera sources for more information\";\n> > > \n> > > As annoying as those messages are, I think that's a good idea ;-)\n> > > \n> > > Should they be 'Error' instead of 'Warning' too if we want to be really\n> > > loud?\n> > \n> > I think this is a bikeshedding area. So to make it even more fun I throw \n> > in the idea of adding a new LOG level, Depreciated. This type of log \n> > messages exists in other tools and I find them really useful.\n> > \n> > The tool which comes to mind first is ansible. Once they decide a \n> > feature is being removed or changed they add Depreciated warning when \n> > it's used in the soon to be removed fashion. Then in a few releases they \n> > turn the warning into a Fatal. This gives me as a user quiet some time \n> > to fix my setup to not be effected when upstream moves on.\n> \n> It's an interesting idea, but given that our log levels mechanism is\n> based on an integer level from least important (Debug) to most important\n> (Fatak), I wonder where you would put the deprecated level in that range\n> :-)\n\nI would put it just bellow Fatal, as it would be a fatal error in a few \nreleases. \n\n> \n> > But as with most bikeshedding I don't feel strongly about it. All I care \n> > about is that we behave consistently. So if we switch to Error in this \n> > patch I think the LOG in validateSensorDriver() also should be updated \n> > to match.\n> \n> I'd keep Warning here, as it's not an error (yet), we can still operate.\n> \n> > > > }\n> > > > \n> > > >> \t\tpropertyValue = properties::CameraLocationExternal;\n> > > >> \t}\n> > > >> \tproperties_.set(properties::Location, propertyValue);\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 58A45BD1F6\n\tfor ;\n\tSun, 21 Feb 2021 22:17:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A0CD5689E9;\n\tSun, 21 Feb 2021 23:17:38 +0100 (CET)","from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com\n\t[IPv6:2a00:1450:4864:20::22f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB2B960106\n\tfor ;\n\tSun, 21 Feb 2021 23:17:36 +0100 (CET)","by mail-lj1-x22f.google.com with SMTP id r11so8059800ljk.9\n\tfor ;\n\tSun, 21 Feb 2021 14:17:36 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tb11sm904790ljb.17.2021.02.21.14.17.28\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 21 Feb 2021 14:17:29 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"JUjZ9ZSW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=RcBhD1Od/TpDDZjsIvsD5DodNpa0a25TWIDTkmrOqio=;\n\tb=JUjZ9ZSWo+rYSdRnmwUXhHf63gecme1qPxw8k36Th1zUNsi/bi38ZVaBi+6Vg1bNm+\n\tWFBv/tLiudqI23zqqj6UHF2bYphmczR6aw5zGNsdK181q446uCSO3U0jnSWOg3K3zw0K\n\tu6zfSHsSFvrONpa77raeM7sE5p0cXTCw4PMwzyoDd9q0RhbVd1IdQlLuZZDu/y9L4Zyv\n\t0aFTMLeUAqQLFtNHiQQKFVE0qsHndTTBxcDhC55NllcWH+NMHLAMHckJJkUpXB/keiuH\n\tLUzmrcN8nIWMHbkT5s2e78ocxsZt9SBIr5V+pKC1IhJz1fYg1YIsW/J0HrJ2AQuNQZIX\n\tpIdw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=RcBhD1Od/TpDDZjsIvsD5DodNpa0a25TWIDTkmrOqio=;\n\tb=UCId3X2n4I2MTZeuBZ2YLJIScXwoGn6xFpLa3fI6XRsEa6bQpXLY1hi79LF+ogSs81\n\tRRoDeMTbTpsZFM9DYmYs/C/iodgP/ZuVhsARsvu5rN4K/1l1UV3xEL2u72zr/zq3ce0R\n\tIzzfpjswMh3SPOjvP00xImZ996Ctx7kqEnb7CPB26KgcC/BuQb0GLWNq4bmKFKbzg6Rd\n\trZ+OmaxGs/rcKB4yUoIEXc1aiAIm63W0ccwldMx5QN+SQNJzMdRSSJo+ATEOi7PwRJYY\n\tpGPYzLhDXgnYqTcoSc/7sBi6V+LDZvNbptE4XVKVh8ZBxsU9+dcMzADwW9jDEMs0PydG\n\tKvLA==","X-Gm-Message-State":"AOAM530KqzfwxzvEkq1SEPKzfAM4QVzNJSlyh4uabDQDkB/Df8PIAw62\n\th4ZE825rxn00UEujY6kPTeUYLQEGXwtclA==","X-Google-Smtp-Source":"ABdhPJwi5ro1tWF1WOXehNSfbLlc/zIY0XMdPTzE9FWFlDDD20vkDDnH3QrBI8S/iA6oJLifxmr7Tw==","X-Received":"by 2002:a19:7005:: with SMTP id h5mr11258801lfc.21.1613945856298;\n\tSun, 21 Feb 2021 14:17:36 -0800 (PST)","Date":"Sun, 21 Feb 2021 23:17:28 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"","References":"<20210219104544.53217-1-paul.elder@ideasonboard.com>\n\t<20210219104544.53217-2-paul.elder@ideasonboard.com>\n\t\n\t<7a857c46-b6dc-600a-a215-486607ddfc2b@ideasonboard.com>\n\t\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: camera_sensor: Print\n\twarning when orientation is unknown","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]