{"id":11335,"url":"https://patchwork.libcamera.org/api/patches/11335/?format=json","web_url":"https://patchwork.libcamera.org/patch/11335/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210218134752.1303582-1-kieran.bingham@ideasonboard.com>","date":"2021-02-18T13:47:52","name":"[libcamera-devel] libcamera: pipeline: ipu3: Prevent unintialised memory use","commit_ref":"8201093830845f1ce420b8ca1dc550cd5a421b26","pull_url":null,"state":"accepted","archived":false,"hash":"102b0324ecb7ab8bfa79ab0499b26f2b623e693f","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11335/mbox/","series":[{"id":1707,"url":"https://patchwork.libcamera.org/api/series/1707/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1707","date":"2021-02-18T13:47:52","name":"[libcamera-devel] libcamera: pipeline: ipu3: Prevent unintialised memory use","version":1,"mbox":"https://patchwork.libcamera.org/series/1707/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11335/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11335/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 591AEBD1F6\n\tfor ;\n\tThu, 18 Feb 2021 13:47:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D06DC689BC;\n\tThu, 18 Feb 2021 14:47:58 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB5756835F\n\tfor ;\n\tThu, 18 Feb 2021 14:47:56 +0100 (CET)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6B9AE3E7;\n\tThu, 18 Feb 2021 14:47:56 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Y8nOhGFh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613656076;\n\tbh=P2hyrNAromnPRcOh45XrSuceNLEM5KUxa1nOxk012IY=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=Y8nOhGFhs71Fo5xAOVuI/ceyPIZHbnyP4tWV2f1o/j0n1yBJLphtSOu4z78VE8Lwn\n\tWMjE4uXA53c/28LRrz2wbvn4A7hTqbK2V5J/yJxqZ/Q0ZiCRGzJGNTHOWozPHVHKUC\n\t7V40VhPeZH45n5/xCEeqF7H4Zt/FZGYt3mAtnE5s=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Thu, 18 Feb 2021 13:47:52 +0000","Message-Id":"<20210218134752.1303582-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH] libcamera: pipeline: ipu3: Prevent\n\tunintialised memory use","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The call to setFormat uses uninitialised data, which whilst\nnot necessary a fault while setting, could cause unwanted effects.\n\nIt is also trapped and reported by valgrind.\n\nInitialise the V4L2SubdeviceFormat structure correctly before use.\n\nSigned-off-by: Kieran Bingham \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 3e6b88af4188..e2353e890e0f 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -846,7 +846,7 @@ int PipelineHandlerIPU3::initControls(IPU3CameraData *data)\n \t */\n \n \t/* Re-fetch the sensor info updated to use the largest resolution. */\n-\tV4L2SubdeviceFormat sensorFormat;\n+\tV4L2SubdeviceFormat sensorFormat = {};\n \tsensorFormat.size = sensor->resolution();\n \tret = sensor->setFormat(&sensorFormat);\n \tif (ret)\n","prefixes":["libcamera-devel"]}