[{"id":15219,"web_url":"https://patchwork.libcamera.org/comment/15219/","msgid":"","date":"2021-02-18T11:40:26","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Do not require SDN\n\t(spatial denoise) algorithm","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi David,\n\nOn 17/02/2021 15:24, David Plowman wrote:\n> A camera tuning is not required to load an SDN algorithm. In keeping\n> with other controls, do not fail when a particular control was\n> expecting this algorithm, just warn that it is not present.\n> \n> Signed-off-by: David Plowman \n\nReviewed-by: Kieran Bingham \n\nWe're in src/ipa here so perhaps a tag from Naush is useful, and we can\nadd it to the merge queue.\n--\nKieran\n\n\n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 81a3195c..4608dfd4 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -875,7 +875,11 @@ void IPARPi::queueRequest(const ControlList &controls)\n> \t\tcase controls::NOISE_REDUCTION_MODE: {\n> \t\t\tRPiController::DenoiseAlgorithm *sdn = dynamic_cast(\n> \t\t\t\tcontroller_.GetAlgorithm(\"SDN\"));\n> -\t\t\tASSERT(sdn);\n> +\t\t\tif (!sdn) {\n> +\t\t\t\tLOG(IPARPI, Warning)\n> +\t\t\t\t\t<< \"Could not set NOISE_REDUCTION_MODE - no SDN algorithm\";\n> +\t\t\t\tbreak;\n> +\t\t\t}\n> \n> \t\t\tint32_t idx = ctrl.second.get();\n> \t\t\tauto mode = DenoiseModeTable.find(idx);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D892EBD1F6\n\tfor ;\n\tThu, 18 Feb 2021 11:40:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 36432683C6;\n\tThu, 18 Feb 2021 12:40:31 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6B97168110\n\tfor ;\n\tThu, 18 Feb 2021 12:40:29 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DADFA3E7;\n\tThu, 18 Feb 2021 12:40:28 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YTZumzL5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613648429;\n\tbh=VgU0OOvTzaKTOe47UnQ3TtcY79c778BuQcw9NMvD3Qo=;\n\th=Reply-To:Subject:To:References:Cc:From:Date:In-Reply-To:From;\n\tb=YTZumzL5+uQ6g2Fe6ttv4n81N8q/4RmEidAcg0HRnJEg1HywPKsHJwpMOC7SorU5r\n\tX/aouaG0MnfQ5SX6x7kjS4t/DstRH1cb1fhQ5l+qdM5jLoo58AaUNrGQ+5mQkAlp4p\n\tJooO9Z0K2jV3RGg5Yxj3HCYoAk1GRLZ+gmcjhM6U=","To":"David Plowman ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210217152400.1996-1-david.plowman@raspberrypi.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Thu, 18 Feb 2021 11:40:26 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210217152400.1996-1-david.plowman@raspberrypi.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Do not require SDN\n\t(spatial denoise) algorithm","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15221,"web_url":"https://patchwork.libcamera.org/comment/15221/","msgid":"","date":"2021-02-18T12:39:23","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Do not require SDN\n\t(spatial denoise) algorithm","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nThank you for your patch.\n\nOn Wed, 17 Feb 2021 at 15:24, David Plowman \nwrote:\n\n> A camera tuning is not required to load an SDN algorithm. In keeping\n> with other controls, do not fail when a particular control was\n> expecting this algorithm, just warn that it is not present.\n>\n> Signed-off-by: David Plowman \n>\n\nReviewed-by: Naushir Patuck \n\n\n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp\n> b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 81a3195c..4608dfd4 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -875,7 +875,11 @@ void IPARPi::queueRequest(const ControlList &controls)\n> case controls::NOISE_REDUCTION_MODE: {\n> RPiController::DenoiseAlgorithm *sdn =\n> dynamic_cast(\n> controller_.GetAlgorithm(\"SDN\"));\n> - ASSERT(sdn);\n> + if (!sdn) {\n> + LOG(IPARPI, Warning)\n> + << \"Could not set\n> NOISE_REDUCTION_MODE - no SDN algorithm\";\n> + break;\n> + }\n>\n> int32_t idx = ctrl.second.get();\n> auto mode = DenoiseModeTable.find(idx);\n> --\n> 2.20.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 779DEBD1F6\n\tfor ;\n\tThu, 18 Feb 2021 12:39:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EBF816836F;\n\tThu, 18 Feb 2021 13:39:41 +0100 (CET)","from mail-lj1-x229.google.com (mail-lj1-x229.google.com\n\t[IPv6:2a00:1450:4864:20::229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E0D2968110\n\tfor ;\n\tThu, 18 Feb 2021 13:39:39 +0100 (CET)","by mail-lj1-x229.google.com with SMTP id q14so4049954ljp.4\n\tfor ;\n\tThu, 18 Feb 2021 04:39:39 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"axxwrB6R\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=FYF3+JvufsaC5wmYnLF36Zqs1TvJLhHt6agX36pY0HY=;\n\tb=axxwrB6RDjCy284BTpKbZjru2OXqltImU2BGlpONqjlRuaCoElQbgTiK5JP8Sqxqjm\n\tJ0BmDlbWKEkd5ddNmVaFjiCS+ggQGcQX4cY5N//ZapoH1lw9q3AkZSOmsgB2FlRSfObV\n\tziTZ+ukNM+WEFVqoQADuD82j5LmfvvyKvPud67ABIBlXgdjt5sFh4cPKbsUjG1LFnM7A\n\t+R/nECrnQmC7i4DS2ooLniKlrgWCd640dMWchc1Fwsx1SfwJeH7rEZjYQL358lfidDHa\n\tDAw9MDrSIwGOYknqvE72XJpbUERNyVrV5QFHZk5Chf4yGMieWX3QwJguB/igR8NoU7Uh\n\taSQg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=FYF3+JvufsaC5wmYnLF36Zqs1TvJLhHt6agX36pY0HY=;\n\tb=YIkl05fYnPerzm17qm/8xVpqHWoXrf1icD6lPRsMr9LR5qUC5FkNg9Ra81x8yX13rC\n\tgOedhmd5h9dY6rDlDhJhVNxDR1+ubGrwOMMnNtGwvxI1T2Q7LRywqR+h2/x2GgXtxJXk\n\tpIMN+WGuSHdzl3Ue6z6Ep9/s3wa/DChmF4YQ8iMGqmVSSb8mZlQmMYBoqSCHBH6jFj+u\n\t9jJWKf3MA7kMnQwVNu7briBOY+pYYjK8cDWj4ZTwSyil6DvEbshN8dMsR1SC3Yac0xpC\n\t2M4FMAQBpCgHkwYoBzqJVb1oXAorYuzG/KPUe4HwtMQtUF6NbY847owYa+W/ygDoGZwU\n\ttO7w==","X-Gm-Message-State":"AOAM533batxhdhAnFRW4yp/e/PHxLyKE0dcioabKoGmHRAqDrej5cHtl\n\t4N1iOefWFOOtE/zUYuBKk8be+nYsuRfnCFEX70VI0g==","X-Google-Smtp-Source":"ABdhPJz7S5Qn51iGvxQHCMQRiwgTfkKDIYyelsOtLvxlXiftMYNb9uSZHAiwgNbWeDNpjSeMR8TVKsaMGxfGsCqpvJU=","X-Received":"by 2002:a2e:9a49:: with SMTP id k9mr2439757ljj.400.1613651979272;\n\tThu, 18 Feb 2021 04:39:39 -0800 (PST)","MIME-Version":"1.0","References":"<20210217152400.1996-1-david.plowman@raspberrypi.com>","In-Reply-To":"<20210217152400.1996-1-david.plowman@raspberrypi.com>","From":"Naushir Patuck ","Date":"Thu, 18 Feb 2021 12:39:23 +0000","Message-ID":"","To":"David Plowman ","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Do not require SDN\n\t(spatial denoise) algorithm","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============7746374929031479148==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]