{"id":11328,"url":"https://patchwork.libcamera.org/api/patches/11328/?format=json","web_url":"https://patchwork.libcamera.org/patch/11328/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210217152400.1996-1-david.plowman@raspberrypi.com>","date":"2021-02-17T15:24:00","name":"[libcamera-devel] ipa: raspberrypi: Do not require SDN (spatial denoise) algorithm","commit_ref":"9fe81a51abd2ad875e4343df5f0c2007242b8bcf","pull_url":null,"state":"accepted","archived":false,"hash":"d1ced068da1f84ff4612e2d235dc35228cbe034f","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11328/mbox/","series":[{"id":1704,"url":"https://patchwork.libcamera.org/api/series/1704/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1704","date":"2021-02-17T15:24:00","name":"[libcamera-devel] ipa: raspberrypi: Do not require SDN (spatial denoise) algorithm","version":1,"mbox":"https://patchwork.libcamera.org/series/1704/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11328/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11328/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 25737BD1F1\n\tfor ;\n\tWed, 17 Feb 2021 15:24:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 99241680E9;\n\tWed, 17 Feb 2021 16:24:07 +0100 (CET)","from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com\n\t[IPv6:2a00:1450:4864:20::32f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CBCB463804\n\tfor ;\n\tWed, 17 Feb 2021 16:24:05 +0100 (CET)","by mail-wm1-x32f.google.com with SMTP id l17so2445051wmq.2\n\tfor ;\n\tWed, 17 Feb 2021 07:24:05 -0800 (PST)","from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\ty2sm3495010wmg.13.2021.02.17.07.24.04\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 17 Feb 2021 07:24:04 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Aw/j7F3q\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=o0qg0OfxMGbwWZERvrfrema4F+IiiceIbLXiio5L2wM=;\n\tb=Aw/j7F3qW9aw4FETzZ4y/Z4bDWPwZf64eETKX/1Z3oqPF8fyYaeiVEFjjhaoE57hkH\n\tRAd8uw//vhj0TjYwLNOSr86PWHz1/zE2h05h8Ug5xV5RDxVTqh0IOtBBX8qo3URo03Zn\n\tQGSUyaqXWorn12DTTThpg2UeIFpSdYciDgbXQfQjsyqowaEnIctKnH2+qMlMaZ9vt5MU\n\tH7NuvK7SWUKYqHTnvVoHRma32ensOC0uCjPS9Z+Mj379rLrcdSk+W4QYFbw3JfZseKj9\n\toCNgzFmCEUEq/t1OOBglQ0NcpRpDzl0VKvtcCaKE4gfd5GuraeHfSuyRQHnbwV2Rw73Y\n\tT/ww==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=o0qg0OfxMGbwWZERvrfrema4F+IiiceIbLXiio5L2wM=;\n\tb=rKXvvea2IUd2Bm+PNy6XBH8Y2XEbqrYxrR6Ti6A0QCBscc3Qdfcju+a3Pn8CItZAVX\n\tJFdNN5jbQAaIlOZ8gqN9bTvEVxhgmd9dHs/fuyV8WcxkQwX5f5IeW60vLisw1O373FyN\n\tveZuNCuViM6C4jX7Pvm+eatQWa1liLd8GlOT+lSmMXAGTFbkXYCIXfxWfrEZfm47pa/I\n\tWiOlJ3EA6kY+DLeV6n8FiBcaVqZvINZpukPeOkxhRaIU0sXjsE+Vs0f+2TV+j7fpMvCC\n\tJ8plenEYHILLUS1IGpLANRi3lgkMVS8Tz8tSnXKuV4f/ZrEtqkxNznfWMxZnjCe4cCIU\n\tn+mg==","X-Gm-Message-State":"AOAM531BYsx8951FPtiGMwwCJIitIPwY5JDkP0i+Vfh87Ia7teHyefXI\n\t0oJJo9KNho1FwycHpG4TMvQa6aZdTlWSprsz","X-Google-Smtp-Source":"ABdhPJynsRiyQF2gJ6PBGhtjuYiqCqQuFAe+NaX61TOcHBtJMzs6NfNHR6pYtgF5k4nJmW0LGgNwdA==","X-Received":"by 2002:a1c:5584:: with SMTP id\n\tj126mr7573223wmb.153.1613575445193; \n\tWed, 17 Feb 2021 07:24:05 -0800 (PST)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 17 Feb 2021 15:24:00 +0000","Message-Id":"<20210217152400.1996-1-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH] ipa: raspberrypi: Do not require SDN\n\t(spatial denoise) algorithm","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"A camera tuning is not required to load an SDN algorithm. In keeping\nwith other controls, do not fail when a particular control was\nexpecting this algorithm, just warn that it is not present.\n\nSigned-off-by: David Plowman \n---\n src/ipa/raspberrypi/raspberrypi.cpp | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex 81a3195c..4608dfd4 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -875,7 +875,11 @@ void IPARPi::queueRequest(const ControlList &controls)\n \t\tcase controls::NOISE_REDUCTION_MODE: {\n \t\t\tRPiController::DenoiseAlgorithm *sdn = dynamic_cast(\n \t\t\t\tcontroller_.GetAlgorithm(\"SDN\"));\n-\t\t\tASSERT(sdn);\n+\t\t\tif (!sdn) {\n+\t\t\t\tLOG(IPARPI, Warning)\n+\t\t\t\t\t<< \"Could not set NOISE_REDUCTION_MODE - no SDN algorithm\";\n+\t\t\t\tbreak;\n+\t\t\t}\n \n \t\t\tint32_t idx = ctrl.second.get();\n \t\t\tauto mode = DenoiseModeTable.find(idx);\n","prefixes":["libcamera-devel"]}