{"id":11320,"url":"https://patchwork.libcamera.org/api/patches/11320/?format=json","web_url":"https://patchwork.libcamera.org/patch/11320/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210217100852.1542397-3-naush@raspberrypi.com>","date":"2021-02-17T10:08:52","name":"[libcamera-devel,3/3] pipeline: raspberrypi: Update lens shading control in-place","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f1c867c03fc45ff529a0b510a2e9c3de16d5920d","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11320/mbox/","series":[{"id":1700,"url":"https://patchwork.libcamera.org/api/series/1700/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1700","date":"2021-02-17T10:08:50","name":"[libcamera-devel,1/3] pipeline: ipa: raspberrypi: Various fixups after IPAInterface changes","version":1,"mbox":"https://patchwork.libcamera.org/series/1700/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11320/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11320/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 46474BD1F1\n\tfor ;\n\tWed, 17 Feb 2021 10:09:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1222A6381F;\n\tWed, 17 Feb 2021 11:09:02 +0100 (CET)","from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com\n\t[IPv6:2a00:1450:4864:20::42a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7DA56637F7\n\tfor ;\n\tWed, 17 Feb 2021 11:08:58 +0100 (CET)","by mail-wr1-x42a.google.com with SMTP id b3so16732187wrj.5\n\tfor ;\n\tWed, 17 Feb 2021 02:08:58 -0800 (PST)","from naush-laptop.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tl38sm2132481wmp.19.2021.02.17.02.08.57\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 17 Feb 2021 02:08:57 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Uvly5XPo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=uuvSWvyj8WmCxY0N0GaNH8uEM5tK2g6h+wMnfKyKZG8=;\n\tb=Uvly5XPo7gjMch0Tr+071EJMcORWBXvhEs4UeHzLWKxijdmBxXgVNZ+Y0lv/icrYNp\n\txnyO3e/xS5I792JeV0toQ7OGGxJxgJojtgUDprdB0IZi87bcek8BkL+uHbgfWn0VT5af\n\tvEfKuqihn4N0VdK4g7NAsE0E/cFhZn6aXLnJzc3SUDUvQgsRMlPpSBtaSrehZk45NvnE\n\tkSG2GNCWHIh5CzNZTNjmD5YfvHF57rR30I84RO6ttPUbHqt9GBXujojyXbWxYw30vVTP\n\tF5WlYXYlS47eF95zz5AizXMTUHBE72SCFdUZEgMAgTqWSOEMq1rJsjo29wd2ZrsKx+9g\n\tGL/Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=uuvSWvyj8WmCxY0N0GaNH8uEM5tK2g6h+wMnfKyKZG8=;\n\tb=Sjb2k5kkl4K6GHhUiB1SkTnbp3F0Bx9c7Atv5Jy/1pc3L68Bc2mgMbBIBpVgAhiiwl\n\taNPUJWgvN6QddIu1z6TtVTW3bmiDmrVivHGs1JFYCHRzYmwlNYxoyMsZDZCBe4JvJCFt\n\tJLNrJNd3Bi3W77l420Y1SXfZsO8UXVPDcWeubytG35R/smAc6C20fQvPsUdc2EYjPFlS\n\tvquWA+zUlw1XwzQCbvvqcJ38rw0J+Qo1j1vmdBV6D3RKi/2LjaSIw8XWTHLkKcoscbZ+\n\tZEOOeOS9ctn3WLrYpTOdXLgOpdwsX0KQ8M3SCtEruSBoYCS5/IP8PXFtuMEDh03X34/f\n\t5EDQ==","X-Gm-Message-State":"AOAM5315Uqeu8ccbCybgQrSrzpAHaerbUqbo2PzEoPNxeqc7FFmEuqdc\n\tMK0e1VW2tYKLHBj0ZuMLZ41pwqQx5BYctnzS","X-Google-Smtp-Source":"ABdhPJzUoQurMOkW1jiXstGtzDckfZCMwt5B0yLCSZ+VwKvlUuLcAIAA2wy4FZrhXICHTpu2SZTjNg==","X-Received":"by 2002:adf:b18e:: with SMTP id\n\tq14mr29143160wra.396.1613556537948; \n\tWed, 17 Feb 2021 02:08:57 -0800 (PST)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 17 Feb 2021 10:08:52 +0000","Message-Id":"<20210217100852.1542397-3-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20210217100852.1542397-1-naush@raspberrypi.com>","References":"<20210217100852.1542397-1-naush@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 3/3] pipeline: raspberrypi: Update lens\n\tshading control in-place","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add the dmabuf file descriptor to the lens shading control in-place\nrather than taking a copy.\n\nSigned-off-by: Naushir Patuck \n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 11 ++++++-----\n 1 file changed, 6 insertions(+), 5 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 9dd4d112a907..a60415d93705 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -1338,13 +1338,14 @@ void RPiCameraData::embeddedComplete(uint32_t bufferId)\n \n void RPiCameraData::setIspControls(const ControlList &controls)\n {\n-\tControlList ctrls = controls;\n+\tControlList ctrls = std::move(controls);\n \n \tif (ctrls.contains(V4L2_CID_USER_BCM2835_ISP_LENS_SHADING)) {\n-\t\tSpan s =\n-\t\t\tctrls.get(V4L2_CID_USER_BCM2835_ISP_LENS_SHADING).data();\n-\t\tconst bcm2835_isp_lens_shading *ls =\n-\t\t\treinterpret_cast(s.data());\n+\t\tControlValue &value =\n+\t\t\tconst_cast(ctrls.get(V4L2_CID_USER_BCM2835_ISP_LENS_SHADING));\n+\t\tSpan s = value.data();\n+\t\tbcm2835_isp_lens_shading *ls =\n+\t\t\treinterpret_cast(s.data());\n \t\tls->dmabuf = lsTable_.fd();\n \t}\n \n","prefixes":["libcamera-devel","3/3"]}