[{"id":16631,"web_url":"https://patchwork.libcamera.org/comment/16631/","msgid":"","date":"2021-04-27T07:07:14","subject":"Re: [libcamera-devel] [PATCH 2/2] utils: tracepoints: ipa call\n\tanalyzer: Fix std dev calculation for single value","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Feb 17, 2021 at 06:29:37PM +0900, Paul Elder wrote:\n> Some IPA calls might only be called once, such as configure(), start(),\n> stop(), etc. This causes the analyzer to break as stddev() on a single\n\nThe function is called stdev, not stddev.\n\n> value is invalid. Set the stddev to zero if there is only one datapoint.\n\nThe variable is stddev though.\n\n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> utils/tracepoints/analyze-ipa-trace.py | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/utils/tracepoints/analyze-ipa-trace.py b/utils/tracepoints/analyze-ipa-trace.py\n> index 50fbbf42..cd7e9ffc 100755\n> --- a/utils/tracepoints/analyze-ipa-trace.py\n> +++ b/utils/tracepoints/analyze-ipa-trace.py\n> @@ -58,7 +58,7 @@ def main(argv):\n> rows.append(['pipeline:function', 'min', 'max', 'mean', 'stddev'])\n> for k, v in samples.items():\n> mean = int(stats.mean(v))\n> - stddev = int(stats.stdev(v))\n> + stddev = int(stats.stdev(v)) if len(v) > 1 else 0\n> minv = min(v)\n> maxv = max(v)\n> rows.append([k, str(minv), str(maxv), str(mean), str(stddev)])","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9455ABDE19\n\tfor ;\n\tTue, 27 Apr 2021 07:07:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 08F0F688B4;\n\tTue, 27 Apr 2021 09:07:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 104016885A\n\tfor ;\n\tTue, 27 Apr 2021 09:07:21 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 81231E9;\n\tTue, 27 Apr 2021 09:07:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"p097Sm/F\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1619507240;\n\tbh=AyWuoCkO+PkVoPCc795sN/RyYYGdDXJoc2MzCNV9tTM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=p097Sm/FeCUD18i9HOucPhZDB3vozheuvkl98OR9z9BOxjTBRxDcX6tcNXTK+SViz\n\tCz7p8nGbFpR+gm01UAZF4nwWnktDsjFC3WGIMDFnRpW5MyrNKM2ebjtpWEKflt1B1N\n\te1F9UL8aRw9VBRAdNLdZt6t9JI/u0bPP8Xq+iOQk=","Date":"Tue, 27 Apr 2021 10:07:14 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"","References":"<20210217092937.17167-1-paul.elder@ideasonboard.com>\n\t<20210217092937.17167-2-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210217092937.17167-2-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] utils: tracepoints: ipa call\n\tanalyzer: Fix std dev calculation for single value","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]