[{"id":15176,"web_url":"https://patchwork.libcamera.org/comment/15176/","msgid":"","date":"2021-02-16T10:48:14","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Fix exposure and\n\tgain delays for imx477","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for correcting this!\n\nReviewed-by: David Plowman \nTested-by: David Plowman \n\nBest regards\nDavid\n\nOn Tue, 16 Feb 2021 at 08:55, Naushir Patuck wrote:\n>\n> The exposure and gain delays for imx477 are both 2 frames. This error\n> was not noticeable because the controller was using the embedded\n> metadata to get the exposure and gain values for the frame.\n>\n> Signed-off-by: Naushir Patuck \n> ---\n> src/ipa/raspberrypi/cam_helper_imx477.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n>\n> diff --git a/src/ipa/raspberrypi/cam_helper_imx477.cpp b/src/ipa/raspberrypi/cam_helper_imx477.cpp\n> index 9a53c5dba9f8..e26c91f7d86d 100644\n> --- a/src/ipa/raspberrypi/cam_helper_imx477.cpp\n> +++ b/src/ipa/raspberrypi/cam_helper_imx477.cpp\n> @@ -37,6 +37,7 @@ public:\n> CamHelperImx477();\n> uint32_t GainCode(double gain) const override;\n> double Gain(uint32_t gain_code) const override;\n> + void GetDelays(int &exposure_delay, int &gain_delay) const override;\n> bool SensorEmbeddedDataPresent() const override;\n>\n> private:\n> @@ -62,6 +63,12 @@ double CamHelperImx477::Gain(uint32_t gain_code) const\n> return 1024.0 / (1024 - gain_code);\n> }\n>\n> +void CamHelperImx477::GetDelays(int &exposure_delay, int &gain_delay) const\n> +{\n> + exposure_delay = 2;\n> + gain_delay = 2;\n> +}\n> +\n> bool CamHelperImx477::SensorEmbeddedDataPresent() const\n> {\n> return true;\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CC8F5BD1EF\n\tfor ;\n\tTue, 16 Feb 2021 10:48:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 59426637DA;\n\tTue, 16 Feb 2021 11:48:29 +0100 (CET)","from mail-ot1-x32b.google.com (mail-ot1-x32b.google.com\n\t[IPv6:2607:f8b0:4864:20::32b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B0AD5637C9\n\tfor ;\n\tTue, 16 Feb 2021 11:48:27 +0100 (CET)","by mail-ot1-x32b.google.com with SMTP id e4so8605681ote.5\n\tfor ;\n\tTue, 16 Feb 2021 02:48:27 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"mJ09vp67\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=9qc+LrQ+48sebHIHpBGdsux6RFvCVlXAjzwd9Lk4ZhI=;\n\tb=mJ09vp672AaCaIyV3VgABoekmwQD4/7Wm+8neDNJGLJi3tqTygdOpLdy16kSvlj9BH\n\tmLO2idTrIvZ3/ba+1567E4EV8HQLV6kvFgBzxxR1UA5/bh3i+FkkJbV+SiealPBcfBhw\n\tGxSVz7U2K5DoPLyKcxR7778ZfhtDVopc+WpeITYd0bhe47ON+HZZNOcr+Hu+nolj/DSp\n\tjzDtKJCK8OEkpoJBYvNiGYoySiJiOKFwTXNPy0K9vu4V1iV1JFtH58VvVfsk4GbWrH/N\n\tXtQkmPCEPoD+4/fUNwqke+M1UF52USfhwnql9IwQhuvzv6Ic88HKDgffvzNCSSvldagI\n\teymA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=9qc+LrQ+48sebHIHpBGdsux6RFvCVlXAjzwd9Lk4ZhI=;\n\tb=NRtiJBsZgZUbqLE4xi12H2tLPhqHwOhP1KbwVfeT0QhvfEH0NUOc66ggWgBCXyJSCH\n\tYRuKCmEpqDR1rl2ZaZJimT4VazYA5r/abN2NCRudSbwecO6Se7vfw03ckXbENZ/vLd05\n\tYNLvHuodRB4G5BKVyJcpqBlQsL1uARbPmDeBKogHvsiGx0M2NelGtaXG7VFER/gchsj8\n\txXfuG4EqaYRTAAiIJX0qxuzr8zh9VH//wmjGbeewZIePbyZzq2RhacK9CMO6VuprYdmw\n\tEopevzR3QkVuZXmvrSfu2E2jYKH9oKH0wNFda6A4MsXrruAj0+5Hj9RdTe0QJsI6rxdx\n\to9WA==","X-Gm-Message-State":"AOAM532ttSo9bkkSdyv8r3nomnj9YlUXg1cbIs6m8qaNVeWmwVfZozXL\n\tHT2oNv31SrLrBLPnp/pdE9p0va00+u3+coRgy3OupVCstN49zT2b","X-Google-Smtp-Source":"ABdhPJwENX8zr8Vc7v4UUZp4195IlUIRq9v7S9/B4fPd5V3TkBsJS1/7hqNvxWc0KCEu9kRGFm5R4cF9J4qUrnfyNIc=","X-Received":"by 2002:a9d:4b14:: with SMTP id\n\tq20mr14155208otf.166.1613472505476; \n\tTue, 16 Feb 2021 02:48:25 -0800 (PST)","MIME-Version":"1.0","References":"<20210216085505.1018624-1-naush@raspberrypi.com>","In-Reply-To":"<20210216085505.1018624-1-naush@raspberrypi.com>","From":"David Plowman ","Date":"Tue, 16 Feb 2021 10:48:14 +0000","Message-ID":"","To":"Naushir Patuck ","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Fix exposure and\n\tgain delays for imx477","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15181,"web_url":"https://patchwork.libcamera.org/comment/15181/","msgid":"","date":"2021-02-16T23:37:20","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Fix exposure and\n\tgain delays for imx477","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Tue, Feb 16, 2021 at 08:55:05AM +0000, Naushir Patuck wrote:\n> The exposure and gain delays for imx477 are both 2 frames. This error\n> was not noticeable because the controller was using the embedded\n> metadata to get the exposure and gain values for the frame.\n> \n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Laurent Pinchart \n\nAnd pushed.\n\n> ---\n> src/ipa/raspberrypi/cam_helper_imx477.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/src/ipa/raspberrypi/cam_helper_imx477.cpp b/src/ipa/raspberrypi/cam_helper_imx477.cpp\n> index 9a53c5dba9f8..e26c91f7d86d 100644\n> --- a/src/ipa/raspberrypi/cam_helper_imx477.cpp\n> +++ b/src/ipa/raspberrypi/cam_helper_imx477.cpp\n> @@ -37,6 +37,7 @@ public:\n> \tCamHelperImx477();\n> \tuint32_t GainCode(double gain) const override;\n> \tdouble Gain(uint32_t gain_code) const override;\n> +\tvoid GetDelays(int &exposure_delay, int &gain_delay) const override;\n> \tbool SensorEmbeddedDataPresent() const override;\n> \n> private:\n> @@ -62,6 +63,12 @@ double CamHelperImx477::Gain(uint32_t gain_code) const\n> \treturn 1024.0 / (1024 - gain_code);\n> }\n> \n> +void CamHelperImx477::GetDelays(int &exposure_delay, int &gain_delay) const\n> +{\n> +\texposure_delay = 2;\n> +\tgain_delay = 2;\n> +}\n> +\n> bool CamHelperImx477::SensorEmbeddedDataPresent() const\n> {\n> \treturn true;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 672DFBD160\n\tfor ;\n\tTue, 16 Feb 2021 23:37:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C5986637E8;\n\tWed, 17 Feb 2021 00:37:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 529306165D\n\tfor ;\n\tWed, 17 Feb 2021 00:37:46 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AF3B28EF;\n\tWed, 17 Feb 2021 00:37:45 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cCM4NkTj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613518665;\n\tbh=RFGG0eo7TFccMn6rQMB/3eRoQ+hbkijCxLFIcJjNPjs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cCM4NkTjonWFjcvt01p+foU890F5FUTlr9BweyKUIDtEQSCBaaMKNtj7ImoeS5P1g\n\tlDnGKOappjHdvZNIn7Q263sqzTMEv3ab4Al9uSIXDUj9LovJA2Jn7B4jecU8BdYZ4v\n\tL1JME3aiH0eo/jsXyFPhFaRryd/E1vUUZ0/md4TE=","Date":"Wed, 17 Feb 2021 01:37:20 +0200","From":"Laurent Pinchart ","To":"Naushir Patuck ","Message-ID":"","References":"<20210216085505.1018624-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210216085505.1018624-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Fix exposure and\n\tgain delays for imx477","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]