{"id":11284,"url":"https://patchwork.libcamera.org/api/patches/11284/?format=json","web_url":"https://patchwork.libcamera.org/patch/11284/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210213042225.112477-8-paul.elder@ideasonboard.com>","date":"2021-02-13T04:22:20","name":"[libcamera-devel,v8,07/12] libcamera: PipelineHandler: Remove IPA from base class","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"213826e7e1e5d761d76bf7d1ca5cbf2749a99349","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11284/mbox/","series":[{"id":1688,"url":"https://patchwork.libcamera.org/api/series/1688/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1688","date":"2021-02-13T04:22:13","name":"IPA isolation: Part 2: Conversion and plumbing","version":8,"mbox":"https://patchwork.libcamera.org/series/1688/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11284/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11284/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9BEBBBD160\n\tfor ;\n\tSat, 13 Feb 2021 04:22:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6A383637C7;\n\tSat, 13 Feb 2021 05:22:57 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2E9336379C\n\tfor ;\n\tSat, 13 Feb 2021 05:22:56 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B6B16564;\n\tSat, 13 Feb 2021 05:22:53 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DavPAHXz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613190175;\n\tbh=E+OhVbeRS6r8vX1mg8Ro1N0CHCYfEC0FA46vYgDzfjg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=DavPAHXz+SIVIzqbV4KUdIpszk3Bei+qcz696TBWc+uOTHohsIlmD15OwMoGXE0g3\n\tL3Y9/qREkt851QCMnWb9fwHdqVCxUjDtMG2vKbAReTDvrAk9+NVzejDfCvVPKFoGFh\n\tzHZUYirwyG+lMYOD4759KDrTGjOVQxae6K2YncO0=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 13 Feb 2021 13:22:20 +0900","Message-Id":"<20210213042225.112477-8-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210213042225.112477-1-paul.elder@ideasonboard.com>","References":"<20210213042225.112477-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v8 07/12] libcamera: PipelineHandler:\n\tRemove IPA from base class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Since pipeline handlers now have their own IPA interface types, it can no\nlonger be defined in the base class, and each pipeline handler\nimplementation must declare it and its type themselves. Remove it from\nthe base class.\n\nSigned-off-by: Paul Elder \nReviewed-by: Niklas Söderlund \nReviewed-by: Jacopo Mondi \nReviewed-by: Laurent Pinchart \n\n---\nNo change in v8\n\nNo change in v7\n\nNo change in v6\n\nNo change in v5\n\nNo change in v4\n\nNo change in v3\n\nChanges in v2:\n- remove documentation\n---\n include/libcamera/internal/pipeline_handler.h | 1 -\n src/libcamera/pipeline_handler.cpp | 8 --------\n 2 files changed, 9 deletions(-)","diff":"diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\nindex d81c9b85..d455d3c9 100644\n--- a/include/libcamera/internal/pipeline_handler.h\n+++ b/include/libcamera/internal/pipeline_handler.h\n@@ -47,7 +47,6 @@ public:\n \tstd::list queuedRequests_;\n \tControlInfoMap controlInfo_;\n \tControlList properties_;\n-\tstd::unique_ptr ipa_;\n \n private:\n \tLIBCAMERA_DISABLE_COPY(CameraData)\ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex c2604d45..84d2555f 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -96,14 +96,6 @@ LOG_DEFINE_CATEGORY(Pipeline)\n * when creating the camera, and shall not be modified afterwards.\n */\n \n-/**\n- * \\var CameraData::ipa_\n- * \\brief The IPA module used by the camera\n- *\n- * Reference to the Image Processing Algorithms (IPA) operating on the camera's\n- * stream(s). If no IPA exists for the camera, this field is set to nullptr.\n- */\n-\n /**\n * \\class PipelineHandler\n * \\brief Create and manage cameras based on a set of media devices\n","prefixes":["libcamera-devel","v8","07/12"]}