[{"id":15147,"web_url":"https://patchwork.libcamera.org/comment/15147/","msgid":"","date":"2021-02-12T14:09:16","subject":"Re: [libcamera-devel] [PATCH v3 5/7] libcamera: controls: Utilise\n\tLIBCAMERA_DISABLE_COPY_AND_MOVE","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Fri, Feb 12, 2021 at 01:30:54PM +0000, Kieran Bingham wrote:\n> The ControlId and Control classes disable the copy constructor and\n> assignment operator, but they should also prevent move construction and\n> assignment.\n> \n> Utilise LIBCAMERA_DISABLE_COPY_AND_MOVE to fully disable these\n> functions.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/controls.h | 7 +++----\n> 1 file changed, 3 insertions(+), 4 deletions(-)\n> \n> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> index 3b7f3347761e..1a5690a5ccbe 100644\n> --- a/include/libcamera/controls.h\n> +++ b/include/libcamera/controls.h\n> @@ -14,6 +14,7 @@\n> #include \n> #include \n> \n> +#include \n> #include \n> #include \n> \n> @@ -220,8 +221,7 @@ public:\n> \tControlType type() const { return type_; }\n> \n> private:\n> -\tControlId &operator=(const ControlId &) = delete;\n> -\tControlId(const ControlId &) = delete;\n> +\tLIBCAMERA_DISABLE_COPY_AND_MOVE(ControlId)\n> \n> \tunsigned int id_;\n> \tstd::string name_;\n> @@ -260,8 +260,7 @@ public:\n> \t}\n> \n> private:\n> -\tControl(const Control &) = delete;\n> -\tControl &operator=(const Control &) = delete;\n> +\tLIBCAMERA_DISABLE_COPY_AND_MOVE(Control)\n> };\n> \n> class ControlInfo","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 69DDDBD162\n\tfor ;\n\tFri, 12 Feb 2021 14:09:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 37F1463789;\n\tFri, 12 Feb 2021 15:09:44 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D1AA963781\n\tfor ;\n\tFri, 12 Feb 2021 15:09:42 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 62CBC8B5;\n\tFri, 12 Feb 2021 15:09:42 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"P9GRlknf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613138982;\n\tbh=3RKIydUcq31HW6DNS3k9zbkGQptAtQOBRh2kqn4jKwU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=P9GRlknf+IPA03UV1KXkuTg2FiEl0JL5UuLeC7pen8yCfEq8fdp9RqGNJRRCsThZn\n\tGRRQKi56HYV9qDss94CPfKN5WNjrBksvT3ROJXrldvr9H12Y4XBQcIwpXWcqlqJfvd\n\tZGc7w78iBS9Gd9cT4AiWi3d1mP29iRYFtMNxEZoU=","Date":"Fri, 12 Feb 2021 16:09:16 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210212133056.873230-1-kieran.bingham@ideasonboard.com>\n\t<20210212133056.873230-6-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210212133056.873230-6-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 5/7] libcamera: controls: Utilise\n\tLIBCAMERA_DISABLE_COPY_AND_MOVE","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]