[{"id":15149,"web_url":"https://patchwork.libcamera.org/comment/15149/","msgid":"","date":"2021-02-12T14:17:49","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: ipu3: set\n\tV4L2_CID_INTEL_IPU3_MODE","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nThank you for the patch.\n\nOn Fri, Feb 12, 2021 at 02:18:51PM +0100, Jean-Michel Hautbois wrote:\n> In order to get the stats back, the imgu subdev needs to have the\n> V4L2_CID_INTEL_IPU3_MODE control set.\n> Set it to video mode by default to get the stats at each frame.\n> \n> Signed-off-by: Jean-Michel Hautbois \n> Reviewed-by: Jacopo Mondi \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 8 ++++++--\n> 1 file changed, 6 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 61f7bf43..6957e3a9 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -551,9 +551,13 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n> \n> \t/* Apply the \"pipe_mode\" control to the ImgU subdevice. */\n> \tControlList ctrls(imgu->imgu_->controls());\n> +\t/*\n> +\t * \\todo Set the ImgU pipe mode to 'Video' unconditionally to have statistics\n> +\t * generated and re-consider if 'Still Capture' should be used for\n> +\t * high quality RAW capture operations that do not involve the IPA.\n\nRaw images are captured at the output of the CIO2, the ImgU won't be in\nthe pipeline. However, when capturing raw frames we still want to run\nthe IPA, so we'll need statistics, which will be produced by the ImgU.\nThe output images will be discarded in that case.\n\nI however agree that we need to check what the use cases for still\ncapture mode are. If the mode exists, it's probably meant for something\n(although one never knows, I think you have first hand experience with\nthis). How about the following comment ?\n\n\t/*\n\t * Set the ImgU pipe mode to 'Video' unconditionally to have statistics\n\t * generated.\n\t *\n\t * \\todo Figure out what the 'Still Capture' mode is meant for, and use\n\t * it accordingly.\n\t */\n\nWith this,\n\nReviewed-by: Laurent Pinchart \n\n> +\t */\n> \tctrls.set(V4L2_CID_IPU3_PIPE_MODE,\n> -\t\t static_cast(vfCfg ? IPU3PipeModeVideo :\n> -\t\t\t\t IPU3PipeModeStillCapture));\n> +\t\t static_cast(IPU3PipeModeVideo));\n> \tret = imgu->imgu_->setControls(&ctrls);\n> \tif (ret) {\n> \t\tLOG(IPU3, Error) << \"Unable to set pipe_mode control\";","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 73D7FBD160\n\tfor ;\n\tFri, 12 Feb 2021 14:18:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D31E86378F;\n\tFri, 12 Feb 2021 15:18:16 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EC02263781\n\tfor ;\n\tFri, 12 Feb 2021 15:18:15 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 603B48B5;\n\tFri, 12 Feb 2021 15:18:15 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VasRChJz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613139495;\n\tbh=advugTTTgrNBUP/2pZvKsm7+F4LW7ZlEe64GTQkOa0M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=VasRChJzJEO4ldQUvQ2oVkAV7PVqtK9inVZiynC6HcK9Gv9pr7gMKrZse7j8tHDIX\n\tsscgAQj8TWRp5fAmznU5sYZgQKjPfR2Zuw2C0nuCdsJR9A92Vih3YBVuqkHZKKWlv0\n\thjY7iX06qnhswOIG9q34stUj+X2i61hvNFZLnN7g=","Date":"Fri, 12 Feb 2021 16:17:49 +0200","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20210212131851.22059-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210212131851.22059-1-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: ipu3: set\n\tV4L2_CID_INTEL_IPU3_MODE","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15152,"web_url":"https://patchwork.libcamera.org/comment/15152/","msgid":"<20210212152732.35c2xd6ur6xhusjk@uno.localdomain>","date":"2021-02-12T15:27:32","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: ipu3: set\n\tV4L2_CID_INTEL_IPU3_MODE","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Fri, Feb 12, 2021 at 04:17:49PM +0200, Laurent Pinchart wrote:\n> Hi Jean-Michel,\n>\n> Thank you for the patch.\n>\n> On Fri, Feb 12, 2021 at 02:18:51PM +0100, Jean-Michel Hautbois wrote:\n> > In order to get the stats back, the imgu subdev needs to have the\n> > V4L2_CID_INTEL_IPU3_MODE control set.\n> > Set it to video mode by default to get the stats at each frame.\n> >\n> > Signed-off-by: Jean-Michel Hautbois \n> > Reviewed-by: Jacopo Mondi \n> > ---\n> > src/libcamera/pipeline/ipu3/ipu3.cpp | 8 ++++++--\n> > 1 file changed, 6 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > index 61f7bf43..6957e3a9 100644\n> > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > @@ -551,9 +551,13 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n> >\n> > \t/* Apply the \"pipe_mode\" control to the ImgU subdevice. */\n> > \tControlList ctrls(imgu->imgu_->controls());\n> > +\t/*\n> > +\t * \\todo Set the ImgU pipe mode to 'Video' unconditionally to have statistics\n> > +\t * generated and re-consider if 'Still Capture' should be used for\n> > +\t * high quality RAW capture operations that do not involve the IPA.\n>\n> Raw images are captured at the output of the CIO2, the ImgU won't be in\n> the pipeline. However, when capturing raw frames we still want to run\n> the IPA, so we'll need statistics, which will be produced by the ImgU.\n> The output images will be discarded in that case.\n\nCorrect, sorry I was confused, of course RAW won't go through the ImgU\n\n>\n> I however agree that we need to check what the use cases for still\n> capture mode are. If the mode exists, it's probably meant for something\n> (although one never knows, I think you have first hand experience with\n> this). How about the following comment ?\n>\n> \t/*\n> \t * Set the ImgU pipe mode to 'Video' unconditionally to have statistics\n> \t * generated.\n> \t *\n> \t * \\todo Figure out what the 'Still Capture' mode is meant for, and use\n> \t * it accordingly.\n> \t */\n\nAgree. The question stays, what is still capture for if it does not\ngenerate statistics and goes through the ImgU...\n\n>\n> With this,\n>\n> Reviewed-by: Laurent Pinchart \n>\n> > +\t */\n> > \tctrls.set(V4L2_CID_IPU3_PIPE_MODE,\n> > -\t\t static_cast(vfCfg ? IPU3PipeModeVideo :\n> > -\t\t\t\t IPU3PipeModeStillCapture));\n> > +\t\t static_cast(IPU3PipeModeVideo));\n> > \tret = imgu->imgu_->setControls(&ctrls);\n> > \tif (ret) {\n> > \t\tLOG(IPU3, Error) << \"Unable to set pipe_mode control\";\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2B2A6BD160\n\tfor ;\n\tFri, 12 Feb 2021 15:27:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B452163781;\n\tFri, 12 Feb 2021 16:27:11 +0100 (CET)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7042D63781\n\tfor ;\n\tFri, 12 Feb 2021 16:27:09 +0100 (CET)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id A7770240002;\n\tFri, 12 Feb 2021 15:27:08 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Fri, 12 Feb 2021 16:27:32 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20210212152732.35c2xd6ur6xhusjk@uno.localdomain>","References":"<20210212131851.22059-1-jeanmichel.hautbois@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: ipu3: set\n\tV4L2_CID_INTEL_IPU3_MODE","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15238,"web_url":"https://patchwork.libcamera.org/comment/15238/","msgid":"<3f5a7241-9cc4-44a1-adfa-bd9886b19868@ideasonboard.com>","date":"2021-02-19T14:12:02","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: ipu3: set\n\tV4L2_CID_INTEL_IPU3_MODE","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nOn 12/02/2021 15:27, Jacopo Mondi wrote:\n> Hi Laurent,\n> \n> On Fri, Feb 12, 2021 at 04:17:49PM +0200, Laurent Pinchart wrote:\n>> Hi Jean-Michel,\n>>\n>> Thank you for the patch.\n>>\n>> On Fri, Feb 12, 2021 at 02:18:51PM +0100, Jean-Michel Hautbois wrote:\n>>> In order to get the stats back, the imgu subdev needs to have the\n>>> V4L2_CID_INTEL_IPU3_MODE control set.\n>>> Set it to video mode by default to get the stats at each frame.\n>>>\n>>> Signed-off-by: Jean-Michel Hautbois \n>>> Reviewed-by: Jacopo Mondi \n>>> ---\n>>> src/libcamera/pipeline/ipu3/ipu3.cpp | 8 ++++++--\n>>> 1 file changed, 6 insertions(+), 2 deletions(-)\n>>>\n>>> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n>>> index 61f7bf43..6957e3a9 100644\n>>> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n>>> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n>>> @@ -551,9 +551,13 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n>>>\n>>> \t/* Apply the \"pipe_mode\" control to the ImgU subdevice. */\n>>> \tControlList ctrls(imgu->imgu_->controls());\n>>> +\t/*\n>>> +\t * \\todo Set the ImgU pipe mode to 'Video' unconditionally to have statistics\n>>> +\t * generated and re-consider if 'Still Capture' should be used for\n>>> +\t * high quality RAW capture operations that do not involve the IPA.\n>>\n>> Raw images are captured at the output of the CIO2, the ImgU won't be in\n>> the pipeline. However, when capturing raw frames we still want to run\n>> the IPA, so we'll need statistics, which will be produced by the ImgU.\n>> The output images will be discarded in that case.\n> \n> Correct, sorry I was confused, of course RAW won't go through the ImgU\n> \n>>\n>> I however agree that we need to check what the use cases for still\n>> capture mode are. If the mode exists, it's probably meant for something\n>> (although one never knows, I think you have first hand experience with\n>> this). How about the following comment ?\n>>\n>> \t/*\n>> \t * Set the ImgU pipe mode to 'Video' unconditionally to have statistics\n>> \t * generated.\n>> \t *\n>> \t * \\todo Figure out what the 'Still Capture' mode is meant for, and use\n>> \t * it accordingly.\n>> \t */\n> \n> Agree. The question stays, what is still capture for if it does not\n> generate statistics and goes through the ImgU...\n\nAre you happy with the updated comment? Will you post a v3? or should I\njust apply Laurent's suggestion before merging?\n\n--\nKieran\n\n\n> \n>>\n>> With this,\n>>\n>> Reviewed-by: Laurent Pinchart \n>>\n>>> +\t */\n>>> \tctrls.set(V4L2_CID_IPU3_PIPE_MODE,\n>>> -\t\t static_cast(vfCfg ? IPU3PipeModeVideo :\n>>> -\t\t\t\t IPU3PipeModeStillCapture));\n>>> +\t\t static_cast(IPU3PipeModeVideo));\n>>> \tret = imgu->imgu_->setControls(&ctrls);\n>>> \tif (ret) {\n>>> \t\tLOG(IPU3, Error) << \"Unable to set pipe_mode control\";\n>>\n>> --\n>> Regards,\n>>\n>> Laurent Pinchart\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7D983BD1F6\n\tfor ;\n\tFri, 19 Feb 2021 14:12:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ED26C689C8;\n\tFri, 19 Feb 2021 15:12:06 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B186F602F5\n\tfor ;\n\tFri, 19 Feb 2021 15:12:05 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1A349596;\n\tFri, 19 Feb 2021 15:12:05 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"B2v6NBSv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613743925;\n\tbh=4AmbEvQofnYitvjr4RFv1CIg9zvi4fHdKbUBiQJEUe8=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=B2v6NBSveW8wVT2dslT4mqWOzgeo7hDdWQoTEFxRVkIxY9hkCfkS548DOfvvBNgBc\n\tt7iaaDKukR+/YWbetT4ks7ttCAyUwx9IrtvP9YYm/xSkTHPGmXfv0gMDIhaBRyGIHq\n\t+Jb05hsIXXB0xSq6Qu+mqHgwtVESUTrrKDEuYzh8=","To":"Jacopo Mondi ,\n\tLaurent Pinchart ","References":"<20210212131851.22059-1-jeanmichel.hautbois@ideasonboard.com>\n\t\n\t<20210212152732.35c2xd6ur6xhusjk@uno.localdomain>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<3f5a7241-9cc4-44a1-adfa-bd9886b19868@ideasonboard.com>","Date":"Fri, 19 Feb 2021 14:12:02 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210212152732.35c2xd6ur6xhusjk@uno.localdomain>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: ipu3: set\n\tV4L2_CID_INTEL_IPU3_MODE","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15239,"web_url":"https://patchwork.libcamera.org/comment/15239/","msgid":"","date":"2021-02-19T14:19:30","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: ipu3: set\n\tV4L2_CID_INTEL_IPU3_MODE","submitter":{"id":74,"url":"https://patchwork.libcamera.org/api/people/74/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@gmail.com"},"content":"Hi Kieran,\n\nOn 19/02/2021 15:12, Kieran Bingham wrote:\n> Hi Jean-Michel,\n> \n> On 12/02/2021 15:27, Jacopo Mondi wrote:\n>> Hi Laurent,\n>>\n>> On Fri, Feb 12, 2021 at 04:17:49PM +0200, Laurent Pinchart wrote:\n>>> Hi Jean-Michel,\n>>>\n>>> Thank you for the patch.\n>>>\n>>> On Fri, Feb 12, 2021 at 02:18:51PM +0100, Jean-Michel Hautbois wrote:\n>>>> In order to get the stats back, the imgu subdev needs to have the\n>>>> V4L2_CID_INTEL_IPU3_MODE control set.\n>>>> Set it to video mode by default to get the stats at each frame.\n>>>>\n>>>> Signed-off-by: Jean-Michel Hautbois \n>>>> Reviewed-by: Jacopo Mondi \n>>>> ---\n>>>> src/libcamera/pipeline/ipu3/ipu3.cpp | 8 ++++++--\n>>>> 1 file changed, 6 insertions(+), 2 deletions(-)\n>>>>\n>>>> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n>>>> index 61f7bf43..6957e3a9 100644\n>>>> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n>>>> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n>>>> @@ -551,9 +551,13 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n>>>>\n>>>> \t/* Apply the \"pipe_mode\" control to the ImgU subdevice. */\n>>>> \tControlList ctrls(imgu->imgu_->controls());\n>>>> +\t/*\n>>>> +\t * \\todo Set the ImgU pipe mode to 'Video' unconditionally to have statistics\n>>>> +\t * generated and re-consider if 'Still Capture' should be used for\n>>>> +\t * high quality RAW capture operations that do not involve the IPA.\n>>>\n>>> Raw images are captured at the output of the CIO2, the ImgU won't be in\n>>> the pipeline. However, when capturing raw frames we still want to run\n>>> the IPA, so we'll need statistics, which will be produced by the ImgU.\n>>> The output images will be discarded in that case.\n>>\n>> Correct, sorry I was confused, of course RAW won't go through the ImgU\n>>\n>>>\n>>> I however agree that we need to check what the use cases for still\n>>> capture mode are. If the mode exists, it's probably meant for something\n>>> (although one never knows, I think you have first hand experience with\n>>> this). How about the following comment ?\n>>>\n>>> \t/*\n>>> \t * Set the ImgU pipe mode to 'Video' unconditionally to have statistics\n>>> \t * generated.\n>>> \t *\n>>> \t * \\todo Figure out what the 'Still Capture' mode is meant for, and use\n>>> \t * it accordingly.\n>>> \t */\n>>\n>> Agree. The question stays, what is still capture for if it does not\n>> generate statistics and goes through the ImgU...\n> \n> Are you happy with the updated comment? Will you post a v3? or should I\n> just apply Laurent's suggestion before merging?\n\nOh dear, forgot about it :-(.\nYes, Laurent's comment it better, I can send a v3 or let you apply it\nwith updated comment, as you prefer !\n\nJM\n\n> --\n> Kieran\n> \n> \n>>\n>>>\n>>> With this,\n>>>\n>>> Reviewed-by: Laurent Pinchart \n>>>\n>>>> +\t */\n>>>> \tctrls.set(V4L2_CID_IPU3_PIPE_MODE,\n>>>> -\t\t static_cast(vfCfg ? IPU3PipeModeVideo :\n>>>> -\t\t\t\t IPU3PipeModeStillCapture));\n>>>> +\t\t static_cast(IPU3PipeModeVideo));\n>>>> \tret = imgu->imgu_->setControls(&ctrls);\n>>>> \tif (ret) {\n>>>> \t\tLOG(IPU3, Error) << \"Unable to set pipe_mode control\";\n>>>\n>>> --\n>>> Regards,\n>>>\n>>> Laurent Pinchart\n>>> _______________________________________________\n>>> libcamera-devel mailing list\n>>> libcamera-devel@lists.libcamera.org\n>>> https://lists.libcamera.org/listinfo/libcamera-devel\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel\n>>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 87D77BD1F1\n\tfor ;\n\tFri, 19 Feb 2021 14:19:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EF94E689C9;\n\tFri, 19 Feb 2021 15:19:33 +0100 (CET)","from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com\n\t[IPv6:2a00:1450:4864:20::32d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3AC3D602F5\n\tfor ;\n\tFri, 19 Feb 2021 15:19:32 +0100 (CET)","by mail-wm1-x32d.google.com with SMTP id l17so7223181wmq.2\n\tfor ;\n\tFri, 19 Feb 2021 06:19:32 -0800 (PST)","from ?IPv6:2a01:e0a:169:7140:e9be:2a73:b117:75b1?\n\t([2a01:e0a:169:7140:e9be:2a73:b117:75b1])\n\tby smtp.gmail.com with ESMTPSA id\n\td29sm7201654wra.51.2021.02.19.06.19.30\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tFri, 19 Feb 2021 06:19:30 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"L8pREtK4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=DJwgHlk0yZcRNPcQZN4rPVkk00iDtMXt/9kcfSNQmKg=;\n\tb=L8pREtK4ibheWjJnkYNCRWX5doOaKtv/XE1WdinobPQHmHgn45M3HpVh29a8wYqk+C\n\tjLR2AqNNqlJr9B+X5XGVYEbpaZMz1Vaj69rzeUtTggeD1Z7px2MwsCeh6uiaDeIEiAV3\n\t9Cwg3oKW0UKKvEwNBXn+6M10QCe2C51Gpcm56ybeznyVsLv1n0wd7AgAY9tNn+rAjfSv\n\tCPbGPZlCRMQMqOsGWLFIxbK6qkjmcSPG4Cs5celGqj3KndvyGykM3KfPbmlNjSBONKDX\n\tPDt4C1pJxTeRodZ6bpbuGO6AYUJgfG0mX20OvEjl4bmFBc4PvQbSR4x0KhIW+4/VCMar\n\taz6w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=DJwgHlk0yZcRNPcQZN4rPVkk00iDtMXt/9kcfSNQmKg=;\n\tb=hbBXRDsoHK8sxt1IVQ15ELxKJPVbUN8h/JITxuftXqae6jlcfdo73l/zXN6/mviGL5\n\typw5JNTgdlgTm0w84YfLf9pPA95cJeSTEgNwe4Q73UPV9bX5F+2cCiHywmsLh54CXvE7\n\t7WClueJEciK9vqc/Rq97xlbzofm1QdEiYRfME2FB4ZTe/pCJJTmDV9wlRNXdDkXEqA7p\n\tnLL5Y+qgUcmU9ID0YoAWU2lpoVxmlHy2sF7aEcDAlEcLeCEK2qaMOFQ+4mDB52vUWeVs\n\tlGzk5qTiZykxZz/xTNSdi5lzi/0NRNoxADY3gpYBmGKUsKqGxMV7W0sedAwICN6AKuXo\n\ttYrg==","X-Gm-Message-State":"AOAM531W2OTzX5EWunkIFAIrs3X8hk2mkvVrpCpgpUEKtDgTP8xwjlIv\n\tAeJcOoqIfxuGVMHl13QOY3Vhge410vyihA==","X-Google-Smtp-Source":"ABdhPJzQrmhGPxaw9Xg82DD03i8aVCxIUj1f4EncaeMhCFlBNoW20e1TTo5nhvrFzCD+Wmj9a2z40g==","X-Received":"by 2002:a1c:6806:: with SMTP id d6mr8776480wmc.119.1613744371352;\n\tFri, 19 Feb 2021 06:19:31 -0800 (PST)","To":"kieran.bingham@ideasonboard.com, Jacopo Mondi ,\n\tLaurent Pinchart ","References":"<20210212131851.22059-1-jeanmichel.hautbois@ideasonboard.com>\n\t\n\t<20210212152732.35c2xd6ur6xhusjk@uno.localdomain>\n\t<3f5a7241-9cc4-44a1-adfa-bd9886b19868@ideasonboard.com>","From":"Jean-Michel Hautbois ","Message-ID":"","Date":"Fri, 19 Feb 2021 15:19:30 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.7.1","MIME-Version":"1.0","In-Reply-To":"<3f5a7241-9cc4-44a1-adfa-bd9886b19868@ideasonboard.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: ipu3: set\n\tV4L2_CID_INTEL_IPU3_MODE","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15244,"web_url":"https://patchwork.libcamera.org/comment/15244/","msgid":"<515c44e1-e882-3b5b-1abc-27449f111aae@ideasonboard.com>","date":"2021-02-19T15:48:03","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: ipu3: set\n\tV4L2_CID_INTEL_IPU3_MODE","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 19/02/2021 14:19, Jean-Michel Hautbois wrote:\n> Hi Kieran,\n> \n> On 19/02/2021 15:12, Kieran Bingham wrote:\n>> Hi Jean-Michel,\n>>\n>> On 12/02/2021 15:27, Jacopo Mondi wrote:\n>>> Hi Laurent,\n>>>\n>>> On Fri, Feb 12, 2021 at 04:17:49PM +0200, Laurent Pinchart wrote:\n>>>> Hi Jean-Michel,\n>>>>\n>>>> Thank you for the patch.\n>>>>\n>>>> On Fri, Feb 12, 2021 at 02:18:51PM +0100, Jean-Michel Hautbois wrote:\n>>>>> In order to get the stats back, the imgu subdev needs to have the\n>>>>> V4L2_CID_INTEL_IPU3_MODE control set.\n>>>>> Set it to video mode by default to get the stats at each frame.\n>>>>>\n>>>>> Signed-off-by: Jean-Michel Hautbois \n>>>>> Reviewed-by: Jacopo Mondi \n>>>>> ---\n>>>>> src/libcamera/pipeline/ipu3/ipu3.cpp | 8 ++++++--\n>>>>> 1 file changed, 6 insertions(+), 2 deletions(-)\n>>>>>\n>>>>> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n>>>>> index 61f7bf43..6957e3a9 100644\n>>>>> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n>>>>> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n>>>>> @@ -551,9 +551,13 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n>>>>>\n>>>>> \t/* Apply the \"pipe_mode\" control to the ImgU subdevice. */\n>>>>> \tControlList ctrls(imgu->imgu_->controls());\n>>>>> +\t/*\n>>>>> +\t * \\todo Set the ImgU pipe mode to 'Video' unconditionally to have statistics\n>>>>> +\t * generated and re-consider if 'Still Capture' should be used for\n>>>>> +\t * high quality RAW capture operations that do not involve the IPA.\n>>>>\n>>>> Raw images are captured at the output of the CIO2, the ImgU won't be in\n>>>> the pipeline. However, when capturing raw frames we still want to run\n>>>> the IPA, so we'll need statistics, which will be produced by the ImgU.\n>>>> The output images will be discarded in that case.\n>>>\n>>> Correct, sorry I was confused, of course RAW won't go through the ImgU\n>>>\n>>>>\n>>>> I however agree that we need to check what the use cases for still\n>>>> capture mode are. If the mode exists, it's probably meant for something\n>>>> (although one never knows, I think you have first hand experience with\n>>>> this). How about the following comment ?\n>>>>\n>>>> \t/*\n>>>> \t * Set the ImgU pipe mode to 'Video' unconditionally to have statistics\n>>>> \t * generated.\n>>>> \t *\n>>>> \t * \\todo Figure out what the 'Still Capture' mode is meant for, and use\n>>>> \t * it accordingly.\n>>>> \t */\n>>>\n>>> Agree. The question stays, what is still capture for if it does not\n>>> generate statistics and goes through the ImgU...\n>>\n>> Are you happy with the updated comment? Will you post a v3? or should I\n>> just apply Laurent's suggestion before merging?\n> \n> Oh dear, forgot about it :-(.\n> Yes, Laurent's comment it better, I can send a v3 or let you apply it\n> with updated comment, as you prefer !\n\nPushed with the updated comment.\n--\nKieran\n\n\n> \n> JM\n> \n>> --\n>> Kieran\n>>\n>>\n>>>\n>>>>\n>>>> With this,\n>>>>\n>>>> Reviewed-by: Laurent Pinchart \n>>>>\n>>>>> +\t */\n>>>>> \tctrls.set(V4L2_CID_IPU3_PIPE_MODE,\n>>>>> -\t\t static_cast(vfCfg ? IPU3PipeModeVideo :\n>>>>> -\t\t\t\t IPU3PipeModeStillCapture));\n>>>>> +\t\t static_cast(IPU3PipeModeVideo));\n>>>>> \tret = imgu->imgu_->setControls(&ctrls);\n>>>>> \tif (ret) {\n>>>>> \t\tLOG(IPU3, Error) << \"Unable to set pipe_mode control\";\n>>>>\n>>>> --\n>>>> Regards,\n>>>>\n>>>> Laurent Pinchart\n>>>> _______________________________________________\n>>>> libcamera-devel mailing list\n>>>> libcamera-devel@lists.libcamera.org\n>>>> https://lists.libcamera.org/listinfo/libcamera-devel\n>>> _______________________________________________\n>>> libcamera-devel mailing list\n>>> libcamera-devel@lists.libcamera.org\n>>> https://lists.libcamera.org/listinfo/libcamera-devel\n>>>\n>>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C62B8BD1F1\n\tfor ;\n\tFri, 19 Feb 2021 15:48:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 42BD4689CF;\n\tFri, 19 Feb 2021 16:48:08 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1C149602F5\n\tfor ;\n\tFri, 19 Feb 2021 16:48:07 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 562C9E9;\n\tFri, 19 Feb 2021 16:48:06 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HPUpNfq4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613749686;\n\tbh=F92fi1b8xitJ1POMnn/JWGveoFQ36mnMa8WFz3Q1XIU=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=HPUpNfq468uontNz74sXL8s7EFGgRcsAZbTMlJX+Ez0noviMQsnzROmU//N9KiuuD\n\tmxfDSQWdRPXshZ2qa4FEjZQVkSsOZr6CoNqyBeArbAF1g6R/J0OD1VFET7Q2DcgntI\n\topb/DAruUvtxsj9CREoVa0q0kyLpnyCF/9myQwhY=","To":"Jean-Michel Hautbois ,\n\tJacopo Mondi ,\n\tLaurent Pinchart ","References":"<20210212131851.22059-1-jeanmichel.hautbois@ideasonboard.com>\n\t\n\t<20210212152732.35c2xd6ur6xhusjk@uno.localdomain>\n\t<3f5a7241-9cc4-44a1-adfa-bd9886b19868@ideasonboard.com>\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<515c44e1-e882-3b5b-1abc-27449f111aae@ideasonboard.com>","Date":"Fri, 19 Feb 2021 15:48:03 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: ipu3: set\n\tV4L2_CID_INTEL_IPU3_MODE","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]