[{"id":1529,"web_url":"https://patchwork.libcamera.org/comment/1529/","msgid":"<20190428235810.vsm6cfz6y6v4l37u@uno.localdomain>","date":"2019-04-28T23:58:10","subject":"Re: [libcamera-devel] [PATCH] libcamera: device_enumerator_udev:\n\tInclude missing header","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Apr 29, 2019 at 02:23:22AM +0300, Laurent Pinchart wrote:\n> The makedev() macro is defined in sys/sysmacros.h, include the header\n> explicitly.\n\nThank you.\n\nWith this, we're only 1 error away to succesfully compile with the\nclang version shipped by ChromeOS, so please push this.\n\nThanks\n   j\n\n\n>\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> ---\n>  src/libcamera/device_enumerator_udev.cpp | 1 +\n>  1 file changed, 1 insertion(+)\n>\n> diff --git a/src/libcamera/device_enumerator_udev.cpp b/src/libcamera/device_enumerator_udev.cpp\n> index cb2d21b90506..86f6ca184698 100644\n> --- a/src/libcamera/device_enumerator_udev.cpp\n> +++ b/src/libcamera/device_enumerator_udev.cpp\n> @@ -11,6 +11,7 @@\n>  #include <libudev.h>\n>  #include <string.h>\n>  #include <sys/ioctl.h>\n> +#include <sys/sysmacros.h>\n>  #include <unistd.h>\n>\n>  #include <libcamera/event_notifier.h>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<jacopo@jmondi.org>","Received":["from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 705D360E57\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Apr 2019 01:57:13 +0200 (CEST)","from uno.localdomain (net-37-182-44-227.cust.vodafonedsl.it\n\t[37.182.44.227]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 10C1920005;\n\tSun, 28 Apr 2019 23:57:12 +0000 (UTC)"],"X-Originating-IP":"37.182.44.227","Date":"Mon, 29 Apr 2019 01:58:10 +0200","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190428235810.vsm6cfz6y6v4l37u@uno.localdomain>","References":"<20190428232322.31151-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"xhptpibpc2w3r44v\"","Content-Disposition":"inline","In-Reply-To":"<20190428232322.31151-1-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH] libcamera: device_enumerator_udev:\n\tInclude missing header","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Sun, 28 Apr 2019 23:57:13 -0000"}}]