[{"id":15134,"web_url":"https://patchwork.libcamera.org/comment/15134/","msgid":"<20210212094014.dsxrxovyenmqupma@uno.localdomain>","date":"2021-02-12T09:40:14","subject":"Re: [libcamera-devel] [PATCH v2 3/4] android: camera_device:\n\tDefault the camera location to Front","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Fri, Feb 12, 2021 at 02:48:15PM +0900, Paul Elder wrote:\n> Since the libcamera camera now has an Unknown location, we can know if\n> the camera's location is actually unknown. In this case, set the android\n> camera location to front, as some systems may not support external\n> cameras.\n>\n> This allows the following CTS test to pass:\n> - android.hardware.camera2.cts.CameraManagerTest#testCameraManagerGetDeviceIdList\n>\n> Signed-off-by: Paul Elder \n> Reviewed-by: Kieran Bingham \n> Reviewed-by: Laurent Pinchart \n>\n> ---\n> No change in v2\n> ---\n> src/android/camera_device.cpp | 3 +++\n> 1 file changed, 3 insertions(+)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 1e2a5b5f..3d815d21 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -407,6 +407,9 @@ int CameraDevice::initialize()\n> \t\tcase properties::CameraLocationExternal:\n> \t\t\tfacing_ = CAMERA_FACING_EXTERNAL;\n> \t\t\tbreak;\n> +\t\tcase properties::CameraLocationUnknown:\n\nI would LOG(Warn) or Info that we are defaulting this.\nOnce we have support for a config file, I presume the information for\nthe HAL could come from there as well.\n\nThis is good in the meantime:\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> +\t\t\tfacing_ = CAMERA_FACING_FRONT;\n> +\t\t\tbreak;\n> \t\t}\n> \t}\n>\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 450C5BD160\n\tfor ;\n\tFri, 12 Feb 2021 09:39:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2028D63770;\n\tFri, 12 Feb 2021 10:39:51 +0100 (CET)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6A9A263762\n\tfor ;\n\tFri, 12 Feb 2021 10:39:50 +0100 (CET)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 08CA24000F;\n\tFri, 12 Feb 2021 09:39:49 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Fri, 12 Feb 2021 10:40:14 +0100","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20210212094014.dsxrxovyenmqupma@uno.localdomain>","References":"<20210212054816.53561-1-paul.elder@ideasonboard.com>\n\t<20210212054816.53561-4-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210212054816.53561-4-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 3/4] android: camera_device:\n\tDefault the camera location to Front","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]