[{"id":15133,"web_url":"https://patchwork.libcamera.org/comment/15133/","msgid":"<20210212093841.ugdtjctbod65qkva@uno.localdomain>","date":"2021-02-12T09:38:41","subject":"Re: [libcamera-devel] [PATCH v2 1/4] libcamera: properties: Add\n\tUnknown value to camera Location","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Fri, Feb 12, 2021 at 02:48:13PM +0900, Paul Elder wrote:\n> If a camera's location is unknown, it should be set so, and not\n> defaulted to another location. Add such a value to the Location property\n> enum.\n>\n> Signed-off-by: Paul Elder \n> Reviewed-by: Kieran Bingham \n> Reviewed-by: Laurent Pinchart \n>\n\nLooks good thanks\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> Changes in v2:\n> - Unknown is now 0, the rest are incremented by 1\n> ---\n> src/libcamera/property_ids.yaml | 10 +++++++---\n> 1 file changed, 7 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> index 104e9aaf..fd17bf0c 100644\n> --- a/src/libcamera/property_ids.yaml\n> +++ b/src/libcamera/property_ids.yaml\n> @@ -10,18 +10,22 @@ controls:\n> description: |\n> Camera mounting location\n> enum:\n> - - name: CameraLocationFront\n> + - name: CameraLocationUnknown\n> value: 0\n> + description: |\n> + The camera location is unknown\n> + - name: CameraLocationFront\n> + value: 1\n> description: |\n> The camera is mounted on the front side of the device, facing the\n> user\n> - name: CameraLocationBack\n> - value: 1\n> + value: 2\n> description: |\n> The camera is mounted on the back side of the device, facing away\n> from the user\n> - name: CameraLocationExternal\n> - value: 2\n> + value: 3\n> description: |\n> The camera is attached to the device in a way that allows it to\n> be moved freely\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E9187BD162\n\tfor ;\n\tFri, 12 Feb 2021 09:38:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C40416376D;\n\tFri, 12 Feb 2021 10:38:18 +0100 (CET)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1962F63762\n\tfor ;\n\tFri, 12 Feb 2021 10:38:17 +0100 (CET)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 9BC5D40008;\n\tFri, 12 Feb 2021 09:38:16 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Fri, 12 Feb 2021 10:38:41 +0100","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20210212093841.ugdtjctbod65qkva@uno.localdomain>","References":"<20210212054816.53561-1-paul.elder@ideasonboard.com>\n\t<20210212054816.53561-2-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210212054816.53561-2-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 1/4] libcamera: properties: Add\n\tUnknown value to camera Location","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]