{"id":11241,"url":"https://patchwork.libcamera.org/api/patches/11241/?format=json","web_url":"https://patchwork.libcamera.org/patch/11241/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210211133444.764808-4-kieran.bingham@ideasonboard.com>","date":"2021-02-11T13:34:41","name":"[libcamera-devel,v2,3/6] libcamera: buffer: Utilise DISABLE_COPY_AND_MOVE","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"10177c74e7a1d32d5c095878433b764f24914cfa","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":{"id":11,"url":"https://patchwork.libcamera.org/api/users/11/?format=json","username":"kbingham","first_name":"Kieran","last_name":"Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/11241/mbox/","series":[{"id":1679,"url":"https://patchwork.libcamera.org/api/series/1679/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1679","date":"2021-02-11T13:34:38","name":"Delete Copy-Move-Assign","version":2,"mbox":"https://patchwork.libcamera.org/series/1679/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11241/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11241/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2C873BD162\n\tfor ;\n\tThu, 11 Feb 2021 13:34:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 174AD63749;\n\tThu, 11 Feb 2021 14:34:52 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CCC18601B5\n\tfor ;\n\tThu, 11 Feb 2021 14:34:48 +0100 (CET)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 68D8ABB8;\n\tThu, 11 Feb 2021 14:34:48 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lvLEqEpl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613050488;\n\tbh=FB1s+iz4kmcj39ojfKPl8kzhw83A4CAnUksJqWzCo7g=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=lvLEqEplU12kUlao4xHIu9mPDKldmZwGzOTskmJhpA/Z0H2gRFIyYpD4iWBFQaivr\n\t+VW+nemzv8LxZWyfAH5wUPxjuDKutnx0Nb2KjZXoVLTsme7gSh8ZncG+QO15GOxhw1\n\tH1trFiUhEBPHVC2eRpD9D+Ts48Nki9UPD+AtiwAc=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Thu, 11 Feb 2021 13:34:41 +0000","Message-Id":"<20210211133444.764808-4-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20210211133444.764808-1-kieran.bingham@ideasonboard.com>","References":"<20210211133444.764808-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 3/6] libcamera: buffer: Utilise\n\tDISABLE_COPY_AND_MOVE","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Convert the existing copy, move and assignment operators to use the new\nmacros.\n\nSigned-off-by: Kieran Bingham \n---\n include/libcamera/buffer.h | 10 ++++------\n 1 file changed, 4 insertions(+), 6 deletions(-)","diff":"diff --git a/include/libcamera/buffer.h b/include/libcamera/buffer.h\nindex a26c8927d37a..d03af787cc08 100644\n--- a/include/libcamera/buffer.h\n+++ b/include/libcamera/buffer.h\n@@ -10,6 +10,7 @@\n #include \n #include \n \n+#include \n #include \n \n namespace libcamera {\n@@ -43,12 +44,6 @@ public:\n \n \tFrameBuffer(const std::vector &planes, unsigned int cookie = 0);\n \n-\tFrameBuffer(const FrameBuffer &) = delete;\n-\tFrameBuffer(FrameBuffer &&) = delete;\n-\n-\tFrameBuffer &operator=(const FrameBuffer &) = delete;\n-\tFrameBuffer &operator=(FrameBuffer &&) = delete;\n-\n \tconst std::vector &planes() const { return planes_; }\n \n \tRequest *request() const { return request_; }\n@@ -57,7 +52,10 @@ public:\n \n \tunsigned int cookie() const { return cookie_; }\n \tvoid setCookie(unsigned int cookie) { cookie_ = cookie; }\n+\n private:\n+\tLIBCAMERA_DISABLE_COPY_AND_MOVE(FrameBuffer);\n+\n \tfriend class Request; /* Needed to update request_. */\n \tfriend class V4L2VideoDevice; /* Needed to update metadata_. */\n \n","prefixes":["libcamera-devel","v2","3/6"]}