[{"id":15103,"web_url":"https://patchwork.libcamera.org/comment/15103/","msgid":"","date":"2021-02-11T21:08:43","subject":"Re: [libcamera-devel] [PATCH v2 2/6] libcamera: class: Provide move\n\tand copy disablers","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Thu, Feb 11, 2021 at 01:34:40PM +0000, Kieran Bingham wrote:\n> It can be difficult to correctly parse the syntax for copy/move and the\n> associated assignment operators.\n> \n> Provide helpers as syntactic sugar to facilitate disabling either the\n> copy constructor, and copy assignment operator, and the move constructor\n> and move assignment operator in a way which is explicit and clear.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> include/libcamera/class.h | 12 ++++++++++++\n> src/libcamera/class.cpp | 18 ++++++++++++++++++\n> 2 files changed, 30 insertions(+)\n> \n> diff --git a/include/libcamera/class.h b/include/libcamera/class.h\n> index 2d9b7ebfdb08..5cd31d1b9f37 100644\n> --- a/include/libcamera/class.h\n> +++ b/include/libcamera/class.h\n> @@ -11,6 +11,18 @@\n> \n> namespace libcamera {\n> \n> +#define LIBCAMERA_DISABLE_COPY(klass) \\\n> +\tklass(const klass &) = delete; \\\n> +\tklass &operator=(const klass &) = delete\n\nI'd add a ; here as other similar macros include the last ;.\n\n> +\n> +#define LIBCAMERA_DISABLE_MOVE(klass) \\\n> +\tklass(klass &&) = delete; \\\n> +\tklass &operator=(klass &&) = delete\n> +\n> +#define LIBCAMERA_DISABLE_COPY_AND_MOVE(klass) \\\n> +\tLIBCAMERA_DISABLE_COPY(klass); \\\n> +\tLIBCAMERA_DISABLE_MOVE(klass)\n> +\n> #ifndef __DOXYGEN__\n> #define LIBCAMERA_DECLARE_PRIVATE(klass)\t\t\t\t\\\n> public:\t\t\t\t\t\t\t\t\t\\\n> diff --git a/src/libcamera/class.cpp b/src/libcamera/class.cpp\n> index 8a608edb369b..b081d05ec3ac 100644\n> --- a/src/libcamera/class.cpp\n> +++ b/src/libcamera/class.cpp\n> @@ -17,6 +17,24 @@\n> \n> namespace libcamera {\n> \n> +/**\n> + * \\def LIBCAMERA_DISABLE_COPY\n> + * \\brief Delete the copy constructor and assignment operator.\n\ns/.$// and same below. I'd write \"Disable copy construction and\nassignment of the \\a klass\" to match the macro name.\n\n> + * \\param klass The identifier of the class to modify\n\ns/identifier/name/\n\nand s/to modify/for which to disable copy/ ?\n\nI'd also add example usage :\n\n * To disable copy of a class, use the LIBCAMERA_DISABLE_COPY macro in\n * the private section of the of the class declaration:\n *\n * \\code{.cpp}\n * class NonCopyable\n * {\n * public:\n * \tNonCopyable();\n * \t...\n *\n * private:\n * \tLIBCAMERA_DISABLE_COPY(NonCopyable)\n * };\n * \\encode\n\nSame below.\n\n> + */\n> +\n> +/**\n> + * \\def LIBCAMERA_DISABLE_MOVE\n> + * \\brief Delete the move construtor and assignment operator.\n> + * \\param klass The identifier of the class to modify\n> + */\n> +\n> +/**\n> + * \\def LIBCAMERA_DISABLE_COPY_AND_MOVE\n> + * \\brief Delete all copy and move constructors, and assignment operators.\n> + * \\param klass The identifier of the class to modify\n> + */\n> +\n> /**\n> * \\def LIBCAMERA_DECLARE_PRIVATE\n> * \\brief Declare private data for a public class","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 08673BD162\n\tfor ;\n\tThu, 11 Feb 2021 21:09:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7297C6374A;\n\tThu, 11 Feb 2021 22:09:11 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A336663746\n\tfor ;\n\tThu, 11 Feb 2021 22:09:09 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 135B841;\n\tThu, 11 Feb 2021 22:09:08 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"plzNDOj/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613077749;\n\tbh=YPAh70KHdhJlWUT3oWH3TzH1Jn1Ck05xOsB1ntde6l4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=plzNDOj/YEpIyXukO7+VGL3yvXaFyk2A4mgZQtJeCZgbSH1FWMAooJjjnuYYFtVqO\n\tuPkbvA2wSuisg1UhfSR34gDPF74ipOi8Ziyhy5/0V8n3NObLEdhR6je4HpwzITBhBC\n\tglb0fuOOQE2+InkJ/HUF6bQq4zi37iEitxsftFc4=","Date":"Thu, 11 Feb 2021 23:08:43 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210211133444.764808-1-kieran.bingham@ideasonboard.com>\n\t<20210211133444.764808-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210211133444.764808-3-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 2/6] libcamera: class: Provide move\n\tand copy disablers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15139,"web_url":"https://patchwork.libcamera.org/comment/15139/","msgid":"<0c5bb444-3727-6a88-0e12-9afef660b0c6@ideasonboard.com>","date":"2021-02-12T11:55:34","subject":"Re: [libcamera-devel] [PATCH v2 2/6] libcamera: class: Provide move\n\tand copy disablers","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 11/02/2021 21:08, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Thu, Feb 11, 2021 at 01:34:40PM +0000, Kieran Bingham wrote:\n>> It can be difficult to correctly parse the syntax for copy/move and the\n>> associated assignment operators.\n>>\n>> Provide helpers as syntactic sugar to facilitate disabling either the\n>> copy constructor, and copy assignment operator, and the move constructor\n>> and move assignment operator in a way which is explicit and clear.\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> include/libcamera/class.h | 12 ++++++++++++\n>> src/libcamera/class.cpp | 18 ++++++++++++++++++\n>> 2 files changed, 30 insertions(+)\n>>\n>> diff --git a/include/libcamera/class.h b/include/libcamera/class.h\n>> index 2d9b7ebfdb08..5cd31d1b9f37 100644\n>> --- a/include/libcamera/class.h\n>> +++ b/include/libcamera/class.h\n>> @@ -11,6 +11,18 @@\n>> \n>> namespace libcamera {\n>> \n>> +#define LIBCAMERA_DISABLE_COPY(klass) \\\n>> +\tklass(const klass &) = delete; \\\n>> +\tklass &operator=(const klass &) = delete\n> \n> I'd add a ; here as other similar macros include the last ;.\n> \n\nlots of extra semi-colons but yes, I remember that was previously discussed.\n\n\n>> +\n>> +#define LIBCAMERA_DISABLE_MOVE(klass) \\\n>> +\tklass(klass &&) = delete; \\\n>> +\tklass &operator=(klass &&) = delete\n>> +\n>> +#define LIBCAMERA_DISABLE_COPY_AND_MOVE(klass) \\\n>> +\tLIBCAMERA_DISABLE_COPY(klass); \\\n>> +\tLIBCAMERA_DISABLE_MOVE(klass)\n\nThat's now going to add two extra semi-colons of course ;-) But there's\nno difference between one, two or more 'free' semi-colons;;;; so it\nshould be fine.\n\n\n>> +\n>> #ifndef __DOXYGEN__\n>> #define LIBCAMERA_DECLARE_PRIVATE(klass)\t\t\t\t\\\n>> public:\t\t\t\t\t\t\t\t\t\\\n>> diff --git a/src/libcamera/class.cpp b/src/libcamera/class.cpp\n>> index 8a608edb369b..b081d05ec3ac 100644\n>> --- a/src/libcamera/class.cpp\n>> +++ b/src/libcamera/class.cpp\n>> @@ -17,6 +17,24 @@\n>> \n>> namespace libcamera {\n>> \n>> +/**\n>> + * \\def LIBCAMERA_DISABLE_COPY\n>> + * \\brief Delete the copy constructor and assignment operator.\n> \n> s/.$// and same below. I'd write \"Disable copy construction and\n> assignment of the \\a klass\" to match the macro name.\n> \n>> + * \\param klass The identifier of the class to modify\n> \n> s/identifier/name/\n> \n> and s/to modify/for which to disable copy/ ?\n\n'for which to' sounds hideous and sparks my Grammar-Warning-Light.\nAnything else I can think of duplicates the brief and becomes really long.\n\nOther uses of klass throughout this file simply call it\n \"The public class name\"\n\nGiven the brief is already descriptive, I don't think we need to\nduplicate the actions.\n\n\n> I'd also add example usage :\n> \n> * To disable copy of a class, use the LIBCAMERA_DISABLE_COPY macro in\n> * the private section of the of the class declaration:\n> *\n> * \\code{.cpp}\n> * class NonCopyable\n> * {\n> * public:\n> * \tNonCopyable();\n> * \t...\n> *\n> * private:\n> * \tLIBCAMERA_DISABLE_COPY(NonCopyable)\n> * };\n> * \\encode\n> \n> Same below.\n\nAdded.\n\n> \n>> + */\n>> +\n>> +/**\n>> + * \\def LIBCAMERA_DISABLE_MOVE\n>> + * \\brief Delete the move construtor and assignment operator.\n>> + * \\param klass The identifier of the class to modify\n>> + */\n>> +\n>> +/**\n>> + * \\def LIBCAMERA_DISABLE_COPY_AND_MOVE\n>> + * \\brief Delete all copy and move constructors, and assignment operators.\n>> + * \\param klass The identifier of the class to modify\n>> + */\n>> +\n>> /**\n>> * \\def LIBCAMERA_DECLARE_PRIVATE\n>> * \\brief Declare private data for a public class\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4F431BD162\n\tfor ;\n\tFri, 12 Feb 2021 11:55:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C6B516377E;\n\tFri, 12 Feb 2021 12:55:44 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0F7C363774\n\tfor ;\n\tFri, 12 Feb 2021 12:55:44 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6D9C08B5;\n\tFri, 12 Feb 2021 12:55:43 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Lwj0Q5l/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613130943;\n\tbh=NlEy8/wufmGuS+hV08fQ3PlvWs3CF8DTQRvFad57xMc=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=Lwj0Q5l/llDB+T8p5KkCwvCe6nbxYL8D3blR2qym7A9vVaweMjro+efSvZUyeyfHp\n\ts1cxGQlAVmKa5GPF+/ECjQVFlqKNwMxBrmQnKSFBu4H+i7XznSKECG85Ft4yho7CFq\n\tATN4CZzWxxlyWLKEWrAGYoRXLDt6cbjsiqPCy9ys=","To":"Laurent Pinchart ","References":"<20210211133444.764808-1-kieran.bingham@ideasonboard.com>\n\t<20210211133444.764808-3-kieran.bingham@ideasonboard.com>\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<0c5bb444-3727-6a88-0e12-9afef660b0c6@ideasonboard.com>","Date":"Fri, 12 Feb 2021 11:55:34 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 2/6] libcamera: class: Provide move\n\tand copy disablers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15140,"web_url":"https://patchwork.libcamera.org/comment/15140/","msgid":"","date":"2021-02-12T12:04:20","subject":"Re: [libcamera-devel] [PATCH v2 2/6] libcamera: class: Provide move\n\tand copy disablers","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Fri, Feb 12, 2021 at 11:55:34AM +0000, Kieran Bingham wrote:\n> On 11/02/2021 21:08, Laurent Pinchart wrote:\n> > On Thu, Feb 11, 2021 at 01:34:40PM +0000, Kieran Bingham wrote:\n> >> It can be difficult to correctly parse the syntax for copy/move and the\n> >> associated assignment operators.\n> >>\n> >> Provide helpers as syntactic sugar to facilitate disabling either the\n> >> copy constructor, and copy assignment operator, and the move constructor\n> >> and move assignment operator in a way which is explicit and clear.\n> >>\n> >> Signed-off-by: Kieran Bingham \n> >> ---\n> >> include/libcamera/class.h | 12 ++++++++++++\n> >> src/libcamera/class.cpp | 18 ++++++++++++++++++\n> >> 2 files changed, 30 insertions(+)\n> >>\n> >> diff --git a/include/libcamera/class.h b/include/libcamera/class.h\n> >> index 2d9b7ebfdb08..5cd31d1b9f37 100644\n> >> --- a/include/libcamera/class.h\n> >> +++ b/include/libcamera/class.h\n> >> @@ -11,6 +11,18 @@\n> >> \n> >> namespace libcamera {\n> >> \n> >> +#define LIBCAMERA_DISABLE_COPY(klass) \\\n> >> +\tklass(const klass &) = delete; \\\n> >> +\tklass &operator=(const klass &) = delete\n> > \n> > I'd add a ; here as other similar macros include the last ;.\n> \n> lots of extra semi-colons but yes, I remember that was previously discussed.\n\nI don't think there will be extra semicolons, the user shouldn't add\nany.\n\n> >> +\n> >> +#define LIBCAMERA_DISABLE_MOVE(klass) \\\n> >> +\tklass(klass &&) = delete; \\\n> >> +\tklass &operator=(klass &&) = delete\n> >> +\n> >> +#define LIBCAMERA_DISABLE_COPY_AND_MOVE(klass) \\\n> >> +\tLIBCAMERA_DISABLE_COPY(klass); \\\n> >> +\tLIBCAMERA_DISABLE_MOVE(klass)\n> \n> That's now going to add two extra semi-colons of course ;-) But there's\n> no difference between one, two or more 'free' semi-colons;;;; so it\n> should be fine.\n\nSame here,\n\n#define LIBCAMERA_DISABLE_COPY_AND_MOVE(klass)\t\\\n\tLIBCAMERA_DISABLE_COPY(klass)\t\t\\\n\tLIBCAMERA_DISABLE_MOVE(klass)\n\n> >> +\n> >> #ifndef __DOXYGEN__\n> >> #define LIBCAMERA_DECLARE_PRIVATE(klass)\t\t\t\t\\\n> >> public:\t\t\t\t\t\t\t\t\t\\\n> >> diff --git a/src/libcamera/class.cpp b/src/libcamera/class.cpp\n> >> index 8a608edb369b..b081d05ec3ac 100644\n> >> --- a/src/libcamera/class.cpp\n> >> +++ b/src/libcamera/class.cpp\n> >> @@ -17,6 +17,24 @@\n> >> \n> >> namespace libcamera {\n> >> \n> >> +/**\n> >> + * \\def LIBCAMERA_DISABLE_COPY\n> >> + * \\brief Delete the copy constructor and assignment operator.\n> > \n> > s/.$// and same below. I'd write \"Disable copy construction and\n> > assignment of the \\a klass\" to match the macro name.\n> > \n> >> + * \\param klass The identifier of the class to modify\n> > \n> > s/identifier/name/\n> > \n> > and s/to modify/for which to disable copy/ ?\n> \n> 'for which to' sounds hideous and sparks my Grammar-Warning-Light.\n> Anything else I can think of duplicates the brief and becomes really long.\n> \n> Other uses of klass throughout this file simply call it\n> \"The public class name\"\n> \n> Given the brief is already descriptive, I don't think we need to\n> duplicate the actions.\n\nOK.\n\n> > I'd also add example usage :\n> > \n> > * To disable copy of a class, use the LIBCAMERA_DISABLE_COPY macro in\n> > * the private section of the of the class declaration:\n> > *\n> > * \\code{.cpp}\n> > * class NonCopyable\n> > * {\n> > * public:\n> > * \tNonCopyable();\n> > * \t...\n> > *\n> > * private:\n> > * \tLIBCAMERA_DISABLE_COPY(NonCopyable)\n> > * };\n> > * \\encode\n> > \n> > Same below.\n> \n> Added.\n> \n> >> + */\n> >> +\n> >> +/**\n> >> + * \\def LIBCAMERA_DISABLE_MOVE\n> >> + * \\brief Delete the move construtor and assignment operator.\n> >> + * \\param klass The identifier of the class to modify\n> >> + */\n> >> +\n> >> +/**\n> >> + * \\def LIBCAMERA_DISABLE_COPY_AND_MOVE\n> >> + * \\brief Delete all copy and move constructors, and assignment operators.\n> >> + * \\param klass The identifier of the class to modify\n> >> + */\n> >> +\n> >> /**\n> >> * \\def LIBCAMERA_DECLARE_PRIVATE\n> >> * \\brief Declare private data for a public class\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 792C7BD160\n\tfor ;\n\tFri, 12 Feb 2021 12:04:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 05DE863778;\n\tFri, 12 Feb 2021 13:04:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CFEE963772\n\tfor ;\n\tFri, 12 Feb 2021 13:04:46 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3D0398B5;\n\tFri, 12 Feb 2021 13:04:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nQgI2lYX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613131486;\n\tbh=wVxSb/RcfzwucSUNAODif+DI11S7yNi8j6hBnziBPxA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=nQgI2lYX+hMTTyeBsJM7TMV/rvOP/o7MGmWKICLd07Hzl2wMrdTK7cT6voxHgJ8GD\n\tv3OfL/8Yrh1y1VceU2rJ1W9LMBC6WgmQQPDOiAG+fXrG8FHh4HQTqUkoE06GRfPxwn\n\tLbXKqJJb7gL/4T/XkPqLLtxd/A4Z5L4YuWpLtJJ0=","Date":"Fri, 12 Feb 2021 14:04:20 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210211133444.764808-1-kieran.bingham@ideasonboard.com>\n\t<20210211133444.764808-3-kieran.bingham@ideasonboard.com>\n\t\n\t<0c5bb444-3727-6a88-0e12-9afef660b0c6@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<0c5bb444-3727-6a88-0e12-9afef660b0c6@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 2/6] libcamera: class: Provide move\n\tand copy disablers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]