[{"id":1528,"web_url":"https://patchwork.libcamera.org/comment/1528/","msgid":"<20190428235701.2tr6fn7lgyipbl4y@uno.localdomain>","date":"2019-04-28T23:57:01","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Use compile\n\toptimisation by default","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Apr 29, 2019 at 02:12:38AM +0300, Laurent Pinchart wrote:\n> Set the compiler optimisation level to 2 by default.\n>\n> Signed-off-by: Laurent Pinchart \n\nThanks,\nReviewed-by: Jacopo Mondi \n\n> ---\n> meson.build | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/meson.build b/meson.build\n> index d272ff33b100..a11a1e4c238e 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -5,6 +5,7 @@ project('libcamera', 'c', 'cpp',\n> 'werror=true',\n> 'warning_level=2',\n> 'cpp_std=c++11',\n> + 'optimization=2',\n> ],\n> license : 'LGPL 2.1+')\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 36ADF60E58\n\tfor ;\n\tMon, 29 Apr 2019 01:56:05 +0200 (CEST)","from uno.localdomain (net-37-182-44-227.cust.vodafonedsl.it\n\t[37.182.44.227]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id CC3D5FF814;\n\tSun, 28 Apr 2019 23:56:04 +0000 (UTC)"],"X-Originating-IP":"37.182.44.227","Date":"Mon, 29 Apr 2019 01:57:01 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190428235701.2tr6fn7lgyipbl4y@uno.localdomain>","References":"<20190428231238.30547-1-laurent.pinchart@ideasonboard.com>\n\t<20190428231238.30547-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"fxdelzoo7j5iv4po\"","Content-Disposition":"inline","In-Reply-To":"<20190428231238.30547-2-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Use compile\n\toptimisation by default","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 28 Apr 2019 23:56:05 -0000"}},{"id":1532,"web_url":"https://patchwork.libcamera.org/comment/1532/","msgid":"","date":"2019-04-29T12:37:55","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Use compile\n\toptimisation by default","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 29/04/2019 00:12, Laurent Pinchart wrote:\n> Set the compiler optimisation level to 2 by default.\n> \n\nIsn't this handled already by the buildtype?\n\nbuildtype {plain, debug, debugoptimized, release, minsize, custom}\n\nThe default buildtype is 'debug', which I would expect to have an\noptimization level of '0' or 'g' to make debugging in GDB easier.\n\n\nLooking at https://mesonbuild.com/Running-Meson.html, it states that the\nbuildtype has the following effects:\n\n========================================================================\nYou can specify a different type of build with the --buildtype command\nline argument. It can have one of the following values.\n\nvalue\t \tmeaning\n\nplain\t\tno extra build flags are used, even for compiler\n\t\twarnings, useful for distro packagers and other cases\n\t\twhere you need to specify all arguments by yourself\n\ndebug\t\tdebug info is generated but the result is not optimized,\n\t\tthis is the default\n\ndebugoptimized\tdebug info is generated and the code is optimized (on\n\t\tmost compilers this means -g -O2)\n\nrelease\t\tfull optimization, no debug info\n========================================================================\n\nSo I think this patch is unnecessary.\n\n--\nRegards\n\nKieran\n\n\n> Signed-off-by: Laurent Pinchart \n> ---\n> meson.build | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/meson.build b/meson.build\n> index d272ff33b100..a11a1e4c238e 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -5,6 +5,7 @@ project('libcamera', 'c', 'cpp',\n> 'werror=true',\n> 'warning_level=2',\n> 'cpp_std=c++11',\n> + 'optimization=2',\n> ],\n> license : 'LGPL 2.1+')\n> \n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7FC1F60C46\n\tfor ;\n\tMon, 29 Apr 2019 14:37:59 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F34692E7;\n\tMon, 29 Apr 2019 14:37:58 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1556541479;\n\tbh=cJkWaUv7TDB+FhP20AAZmlWnLqDm9LpJmLA8A6EthYs=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=f0pfYaxHJjoonLAZYyybDYi05buEqjPbn4+swdC1053y3ZaNdoxpa1lIV07QtYW97\n\tuTePIGN17lWNGVOFA5KNIwlDFAG3tp8DfyOn/z423DarOLlYBmN0CRtXyogy+1eRGh\n\tUjqfrXLfMIlhBlprOd3hs/lSmN8V2ExYwfAQhXhQ=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20190428231238.30547-1-laurent.pinchart@ideasonboard.com>\n\t<20190428231238.30547-2-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"","Date":"Mon, 29 Apr 2019 13:37:55 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.6.1","MIME-Version":"1.0","In-Reply-To":"<20190428231238.30547-2-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Use compile\n\toptimisation by default","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 29 Apr 2019 12:37:59 -0000"}},{"id":1533,"web_url":"https://patchwork.libcamera.org/comment/1533/","msgid":"<20190429124751.GC24837@pendragon.ideasonboard.com>","date":"2019-04-29T12:47:51","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Use compile\n\toptimisation by default","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Mon, Apr 29, 2019 at 01:37:55PM +0100, Kieran Bingham wrote:\n> On 29/04/2019 00:12, Laurent Pinchart wrote:\n> > Set the compiler optimisation level to 2 by default.\n> \n> Isn't this handled already by the buildtype?\n> \n> buildtype {plain, debug, debugoptimized, release, minsize, custom}\n> \n> The default buildtype is 'debug', which I would expect to have an\n> optimization level of '0' or 'g' to make debugging in GDB easier.\n> \n> \n> Looking at https://mesonbuild.com/Running-Meson.html, it states that the\n> buildtype has the following effects:\n> \n> ========================================================================\n> You can specify a different type of build with the --buildtype command\n> line argument. It can have one of the following values.\n> \n> value\t \tmeaning\n> \n> plain\t\tno extra build flags are used, even for compiler\n> \t\twarnings, useful for distro packagers and other cases\n> \t\twhere you need to specify all arguments by yourself\n> \n> debug\t\tdebug info is generated but the result is not optimized,\n> \t\tthis is the default\n> \n> debugoptimized\tdebug info is generated and the code is optimized (on\n> \t\tmost compilers this means -g -O2)\n> \n> release\t\tfull optimization, no debug info\n> ========================================================================\n> \n> So I think this patch is unnecessary.\n\nI've tested this before and the optimisation level wasn't set\nappropriately, but I think I made a mistake somewhere, as testing it now\nproduces the expected results. I thus agree with you, I'll drop this\npatch.\n\nGiven that optimised builds use _FORTIFY_SOURCE by default with gcc,\nshould we enable that in the libcamera buildroot package ? Or does\nbuildroot handle that internally ?\n\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > meson.build | 1 +\n> > 1 file changed, 1 insertion(+)\n> > \n> > diff --git a/meson.build b/meson.build\n> > index d272ff33b100..a11a1e4c238e 100644\n> > --- a/meson.build\n> > +++ b/meson.build\n> > @@ -5,6 +5,7 @@ project('libcamera', 'c', 'cpp',\n> > 'werror=true',\n> > 'warning_level=2',\n> > 'cpp_std=c++11',\n> > + 'optimization=2',\n> > ],\n> > license : 'LGPL 2.1+')\n> >","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E1A4460C46\n\tfor ;\n\tMon, 29 Apr 2019 14:48:03 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(net-37-182-44-227.cust.vodafonedsl.it [37.182.44.227])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4A1112E7;\n\tMon, 29 Apr 2019 14:48:03 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1556542083;\n\tbh=EsDnYBUeiw6V2m4jM4iDmnvUsJRe88PN8Tu/TcBBZy0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HUi6fnOTGl7aTxrGmh1GRiN80UCaOcGH0VNrJbGEenU00cX1DSsv+aW5Hf1bxOH88\n\t18HzkAfQErZwIjVrta/zKTZm7DNrNncGOZ8fJSe7JrFgPWcc+AZrrwoxFzCQKsKHZJ\n\tbvIQQTtkXgGfxHMcM0u7+XFAQTHFAYW4jIL7e7mI=","Date":"Mon, 29 Apr 2019 15:47:51 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190429124751.GC24837@pendragon.ideasonboard.com>","References":"<20190428231238.30547-1-laurent.pinchart@ideasonboard.com>\n\t<20190428231238.30547-2-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Use compile\n\toptimisation by default","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 29 Apr 2019 12:48:04 -0000"}}]