[{"id":15102,"web_url":"https://patchwork.libcamera.org/comment/15102/","msgid":"","date":"2021-02-11T20:57:28","subject":"Re: [libcamera-devel] [PATCH v2 1/6] libcamera: Move extensible to\n\tclass","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Thu, Feb 11, 2021 at 01:34:39PM +0000, Kieran Bingham wrote:\n> The Extensible concept is a generic Class helper. To prepare for\n> further class helper additions, move the specific extensible\n> implementation and header to a more generic class header and source.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> include/libcamera/camera.h | 2 +-\n> include/libcamera/camera_manager.h | 2 +-\n> include/libcamera/{extensible.h => class.h} | 8 ++++----\n> include/libcamera/meson.build | 1 -\n> src/libcamera/{extensible.cpp => class.cpp} | 11 +++++++----\n> src/libcamera/meson.build | 2 +-\n> 6 files changed, 14 insertions(+), 12 deletions(-)\n> rename include/libcamera/{extensible.h => class.h} (86%)\n> rename src/libcamera/{extensible.cpp => class.cpp} (94%)\n> \n> diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\n> index f94f859988fe..cff9f46e801b 100644\n> --- a/include/libcamera/camera.h\n> +++ b/include/libcamera/camera.h\n> @@ -12,8 +12,8 @@\n> #include \n> #include \n> \n> +#include \n> #include \n> -#include \n> #include \n> #include \n> #include \n> diff --git a/include/libcamera/camera_manager.h b/include/libcamera/camera_manager.h\n> index 8c8830e7ff1d..7b8e533fadd6 100644\n> --- a/include/libcamera/camera_manager.h\n> +++ b/include/libcamera/camera_manager.h\n> @@ -12,7 +12,7 @@\n> #include \n> #include \n> \n> -#include \n> +#include \n> #include \n> #include \n> \n> diff --git a/include/libcamera/extensible.h b/include/libcamera/class.h\n> similarity index 86%\n> rename from include/libcamera/extensible.h\n> rename to include/libcamera/class.h\n> index 3f25a47c5064..2d9b7ebfdb08 100644\n> --- a/include/libcamera/extensible.h\n> +++ b/include/libcamera/class.h\n> @@ -2,10 +2,10 @@\n> /*\n> * Copyright (C) 2020, Google Inc.\n> *\n> - * extensible.h - Utilities to create extensible public classes with stable ABIs\n> + * class.h - Utilities and helpers for public classes\n\nI'd drop \"public\" as the macros you will introduce are useful for\ninternal classes too.\n\n> */\n> -#ifndef __LIBCAMERA_EXTENSIBLE_H__\n> -#define __LIBCAMERA_EXTENSIBLE_H__\n> +#ifndef __LIBCAMERA_CLASS_H__\n> +#define __LIBCAMERA_CLASS_H__\n> \n> #include \n> \n> @@ -84,4 +84,4 @@ private:\n> \n> } /* namespace libcamera */\n> \n> -#endif /* __LIBCAMERA_EXTENSIBLE_H__ */\n> +#endif /* __LIBCAMERA_CLASS_H__ */\n> diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\n> index 13e9eeb6d6ad..aefc60d8c9b4 100644\n> --- a/include/libcamera/meson.build\n> +++ b/include/libcamera/meson.build\n> @@ -7,7 +7,6 @@ libcamera_public_headers = files([\n> 'camera_manager.h',\n\nMissing class.h ?\n\n> 'compiler.h',\n> 'controls.h',\n> - 'extensible.h',\n> 'file_descriptor.h',\n> 'framebuffer_allocator.h',\n> 'geometry.h',\n> diff --git a/src/libcamera/extensible.cpp b/src/libcamera/class.cpp\n> similarity index 94%\n> rename from src/libcamera/extensible.cpp\n> rename to src/libcamera/class.cpp\n> index 1dcb0bf1b12f..8a608edb369b 100644\n> --- a/src/libcamera/extensible.cpp\n> +++ b/src/libcamera/class.cpp\n> @@ -2,14 +2,17 @@\n> /*\n> * Copyright (C) 2020, Google Inc.\n> *\n> - * extensible.cpp - Utilities to create extensible public classes with stable ABIs\n> + * class.cpp - Utilities and helpers for public classes\n\nDitto.\n\n> */\n> \n> -#include \n> +#include \n> \n> /**\n> - * \\file extensible.h\n> - * \\brief Utilities to create extensible public classes with stable ABIs\n> + * \\file class.h\n> + * \\brief Utilities to help constructing public class interfaces\n\nAnd similarly here.\n\nReviewed-by: Laurent Pinchart \n\n> + *\n> + * The extensible class can be inheritted to create public classes with stable\n> + * ABIs.\n> */\n> \n> namespace libcamera {\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 5a4bf0d7ba4f..552893a29dc0 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -9,6 +9,7 @@ libcamera_sources = files([\n> 'camera_controls.cpp',\n> 'camera_manager.cpp',\n> 'camera_sensor.cpp',\n> + 'class.cpp',\n> 'controls.cpp',\n> 'control_serializer.cpp',\n> 'control_validator.cpp',\n> @@ -18,7 +19,6 @@ libcamera_sources = files([\n> 'event_dispatcher.cpp',\n> 'event_dispatcher_poll.cpp',\n> 'event_notifier.cpp',\n> - 'extensible.cpp',\n> 'file.cpp',\n> 'file_descriptor.cpp',\n> 'formats.cpp',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7CD5FBD160\n\tfor ;\n\tThu, 11 Feb 2021 20:57:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0622263749;\n\tThu, 11 Feb 2021 21:57:56 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 598D5601B5\n\tfor ;\n\tThu, 11 Feb 2021 21:57:54 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B4CAF41;\n\tThu, 11 Feb 2021 21:57:53 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LbJbOWuL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613077073;\n\tbh=komTa4w1GbwBtOAUY56Pmi+/d+IeGWOQVHlYZPZ0mxo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=LbJbOWuLiDoXguocT7TMTVvnRQBXbsdRNf/5d7EbwpyMo7fl3ual8NWa/nlJ+BeX0\n\tZRuf3hnCE7Fkz0d0f1UZqfzxvu9KTUcyO6tD6+XJxx9EDRcsbOUHyDb5ktQqY9oJOX\n\tUafedUn69UtjsqUNdh8H29Q30Ctjs0CX1vL/QkX0=","Date":"Thu, 11 Feb 2021 22:57:28 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210211133444.764808-1-kieran.bingham@ideasonboard.com>\n\t<20210211133444.764808-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210211133444.764808-2-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 1/6] libcamera: Move extensible to\n\tclass","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15131,"web_url":"https://patchwork.libcamera.org/comment/15131/","msgid":"<4ac6f8bc-a28d-78d4-a75b-2e6653315fb1@ideasonboard.com>","date":"2021-02-12T09:25:34","subject":"Re: [libcamera-devel] [PATCH v2 1/6] libcamera: Move extensible to\n\tclass","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 11/02/2021 20:57, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Thu, Feb 11, 2021 at 01:34:39PM +0000, Kieran Bingham wrote:\n>> The Extensible concept is a generic Class helper. To prepare for\n>> further class helper additions, move the specific extensible\n>> implementation and header to a more generic class header and source.\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> include/libcamera/camera.h | 2 +-\n>> include/libcamera/camera_manager.h | 2 +-\n>> include/libcamera/{extensible.h => class.h} | 8 ++++----\n>> include/libcamera/meson.build | 1 -\n>> src/libcamera/{extensible.cpp => class.cpp} | 11 +++++++----\n>> src/libcamera/meson.build | 2 +-\n>> 6 files changed, 14 insertions(+), 12 deletions(-)\n>> rename include/libcamera/{extensible.h => class.h} (86%)\n>> rename src/libcamera/{extensible.cpp => class.cpp} (94%)\n>>\n>> diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\n>> index f94f859988fe..cff9f46e801b 100644\n>> --- a/include/libcamera/camera.h\n>> +++ b/include/libcamera/camera.h\n>> @@ -12,8 +12,8 @@\n>> #include \n>> #include \n>> \n>> +#include \n>> #include \n>> -#include \n>> #include \n>> #include \n>> #include \n>> diff --git a/include/libcamera/camera_manager.h b/include/libcamera/camera_manager.h\n>> index 8c8830e7ff1d..7b8e533fadd6 100644\n>> --- a/include/libcamera/camera_manager.h\n>> +++ b/include/libcamera/camera_manager.h\n>> @@ -12,7 +12,7 @@\n>> #include \n>> #include \n>> \n>> -#include \n>> +#include \n>> #include \n>> #include \n>> \n>> diff --git a/include/libcamera/extensible.h b/include/libcamera/class.h\n>> similarity index 86%\n>> rename from include/libcamera/extensible.h\n>> rename to include/libcamera/class.h\n>> index 3f25a47c5064..2d9b7ebfdb08 100644\n>> --- a/include/libcamera/extensible.h\n>> +++ b/include/libcamera/class.h\n>> @@ -2,10 +2,10 @@\n>> /*\n>> * Copyright (C) 2020, Google Inc.\n>> *\n>> - * extensible.h - Utilities to create extensible public classes with stable ABIs\n>> + * class.h - Utilities and helpers for public classes\n> \n> I'd drop \"public\" as the macros you will introduce are useful for\n> internal classes too.\n\nAck\n\n> \n>> */\n>> -#ifndef __LIBCAMERA_EXTENSIBLE_H__\n>> -#define __LIBCAMERA_EXTENSIBLE_H__\n>> +#ifndef __LIBCAMERA_CLASS_H__\n>> +#define __LIBCAMERA_CLASS_H__\n>> \n>> #include \n>> \n>> @@ -84,4 +84,4 @@ private:\n>> \n>> } /* namespace libcamera */\n>> \n>> -#endif /* __LIBCAMERA_EXTENSIBLE_H__ */\n>> +#endif /* __LIBCAMERA_CLASS_H__ */\n>> diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\n>> index 13e9eeb6d6ad..aefc60d8c9b4 100644\n>> --- a/include/libcamera/meson.build\n>> +++ b/include/libcamera/meson.build\n>> @@ -7,7 +7,6 @@ libcamera_public_headers = files([\n>> 'camera_manager.h',\n> \n> Missing class.h ?\n\nOh indeed! I would have expected that to be caught by checkstyle...\n\n> \n>> 'compiler.h',\n>> 'controls.h',\n>> - 'extensible.h',\n>> 'file_descriptor.h',\n>> 'framebuffer_allocator.h',\n>> 'geometry.h',\n>> diff --git a/src/libcamera/extensible.cpp b/src/libcamera/class.cpp\n>> similarity index 94%\n>> rename from src/libcamera/extensible.cpp\n>> rename to src/libcamera/class.cpp\n>> index 1dcb0bf1b12f..8a608edb369b 100644\n>> --- a/src/libcamera/extensible.cpp\n>> +++ b/src/libcamera/class.cpp\n>> @@ -2,14 +2,17 @@\n>> /*\n>> * Copyright (C) 2020, Google Inc.\n>> *\n>> - * extensible.cpp - Utilities to create extensible public classes with stable ABIs\n>> + * class.cpp - Utilities and helpers for public classes\n> \n> Ditto.\n\nAck\n\n> \n>> */\n>> \n>> -#include \n>> +#include \n>> \n>> /**\n>> - * \\file extensible.h\n>> - * \\brief Utilities to create extensible public classes with stable ABIs\n>> + * \\file class.h\n>> + * \\brief Utilities to help constructing public class interfaces\n> \n> And similarly here.\n> \n> Reviewed-by: Laurent Pinchart \n\nThanks\n\n> \n>> + *\n>> + * The extensible class can be inheritted to create public classes with stable\n\ns/inheritted/inherited/ too.\n\n\n>> + * ABIs.\n>> */\n>> \n>> namespace libcamera {\n>> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n>> index 5a4bf0d7ba4f..552893a29dc0 100644\n>> --- a/src/libcamera/meson.build\n>> +++ b/src/libcamera/meson.build\n>> @@ -9,6 +9,7 @@ libcamera_sources = files([\n>> 'camera_controls.cpp',\n>> 'camera_manager.cpp',\n>> 'camera_sensor.cpp',\n>> + 'class.cpp',\n>> 'controls.cpp',\n>> 'control_serializer.cpp',\n>> 'control_validator.cpp',\n>> @@ -18,7 +19,6 @@ libcamera_sources = files([\n>> 'event_dispatcher.cpp',\n>> 'event_dispatcher_poll.cpp',\n>> 'event_notifier.cpp',\n>> - 'extensible.cpp',\n>> 'file.cpp',\n>> 'file_descriptor.cpp',\n>> 'formats.cpp',\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9AF87BD160\n\tfor ;\n\tFri, 12 Feb 2021 09:25:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 30B536376A;\n\tFri, 12 Feb 2021 10:25:38 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EBA5D63762\n\tfor ;\n\tFri, 12 Feb 2021 10:25:36 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 632538B5;\n\tFri, 12 Feb 2021 10:25:36 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tFkVO94W\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613121936;\n\tbh=69zhz2Hm0v0x0GAvzASREY2/NJ0f2Si2vAfiCd9yPDg=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=tFkVO94WvgWlyh8ESHZjvqCLoeiz7WGlyhbuio0U8uHCq46Zr3Fp/KQPMv1YFpGZE\n\tHIaERg/027dtyc8XWDE+EDrMM4BbaTA7KSDK1tdKvYBSFS0CjMPHz38/ba9wcE+XQy\n\tSIq1j4Dq5c06yJDZyyKdo+JOCGX9pEhsOICMkf8I=","To":"Laurent Pinchart ","References":"<20210211133444.764808-1-kieran.bingham@ideasonboard.com>\n\t<20210211133444.764808-2-kieran.bingham@ideasonboard.com>\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<4ac6f8bc-a28d-78d4-a75b-2e6653315fb1@ideasonboard.com>","Date":"Fri, 12 Feb 2021 09:25:34 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 1/6] libcamera: Move extensible to\n\tclass","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]