{"id":11239,"url":"https://patchwork.libcamera.org/api/patches/11239/?format=json","web_url":"https://patchwork.libcamera.org/patch/11239/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210211133444.764808-2-kieran.bingham@ideasonboard.com>","date":"2021-02-11T13:34:39","name":"[libcamera-devel,v2,1/6] libcamera: Move extensible to class","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"5c5d6f006a130abf671af6c7b90d57900e2ec9ef","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11239/mbox/","series":[{"id":1679,"url":"https://patchwork.libcamera.org/api/series/1679/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1679","date":"2021-02-11T13:34:38","name":"Delete Copy-Move-Assign","version":2,"mbox":"https://patchwork.libcamera.org/series/1679/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11239/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11239/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EFDCABD162\n\tfor ;\n\tThu, 11 Feb 2021 13:34:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0578563745;\n\tThu, 11 Feb 2021 14:34:51 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4FE6561661\n\tfor ;\n\tThu, 11 Feb 2021 14:34:48 +0100 (CET)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CD5F045E;\n\tThu, 11 Feb 2021 14:34:47 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GwaZlBOw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613050488;\n\tbh=+5h03PsthcwfZKzhw/S8i9/yWivYhHzcNQHhd3vXTJc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=GwaZlBOwBXMN2KYqBaO2Sn17QHGWxYKU1DYPMa7iN8OtSSmXmuvbu6X3v6ZKV0dz1\n\tWdU82yDFVTWJQW0YbOTOKDo+5N1RfeOX6W89oMI2m0AM35CQcACsLC40Ofc3q7jn8G\n\tn89MGQ+ZZdQ72Mz86z5pYi3BbbXQLlVR06+8i+Rs=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Thu, 11 Feb 2021 13:34:39 +0000","Message-Id":"<20210211133444.764808-2-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20210211133444.764808-1-kieran.bingham@ideasonboard.com>","References":"<20210211133444.764808-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 1/6] libcamera: Move extensible to class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The Extensible concept is a generic Class helper. To prepare for\nfurther class helper additions, move the specific extensible\nimplementation and header to a more generic class header and source.\n\nSigned-off-by: Kieran Bingham \n---\n include/libcamera/camera.h | 2 +-\n include/libcamera/camera_manager.h | 2 +-\n include/libcamera/{extensible.h => class.h} | 8 ++++----\n include/libcamera/meson.build | 1 -\n src/libcamera/{extensible.cpp => class.cpp} | 11 +++++++----\n src/libcamera/meson.build | 2 +-\n 6 files changed, 14 insertions(+), 12 deletions(-)\n rename include/libcamera/{extensible.h => class.h} (86%)\n rename src/libcamera/{extensible.cpp => class.cpp} (94%)","diff":"diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h\nindex f94f859988fe..cff9f46e801b 100644\n--- a/include/libcamera/camera.h\n+++ b/include/libcamera/camera.h\n@@ -12,8 +12,8 @@\n #include \n #include \n \n+#include \n #include \n-#include \n #include \n #include \n #include \ndiff --git a/include/libcamera/camera_manager.h b/include/libcamera/camera_manager.h\nindex 8c8830e7ff1d..7b8e533fadd6 100644\n--- a/include/libcamera/camera_manager.h\n+++ b/include/libcamera/camera_manager.h\n@@ -12,7 +12,7 @@\n #include \n #include \n \n-#include \n+#include \n #include \n #include \n \ndiff --git a/include/libcamera/extensible.h b/include/libcamera/class.h\nsimilarity index 86%\nrename from include/libcamera/extensible.h\nrename to include/libcamera/class.h\nindex 3f25a47c5064..2d9b7ebfdb08 100644\n--- a/include/libcamera/extensible.h\n+++ b/include/libcamera/class.h\n@@ -2,10 +2,10 @@\n /*\n * Copyright (C) 2020, Google Inc.\n *\n- * extensible.h - Utilities to create extensible public classes with stable ABIs\n+ * class.h - Utilities and helpers for public classes\n */\n-#ifndef __LIBCAMERA_EXTENSIBLE_H__\n-#define __LIBCAMERA_EXTENSIBLE_H__\n+#ifndef __LIBCAMERA_CLASS_H__\n+#define __LIBCAMERA_CLASS_H__\n \n #include \n \n@@ -84,4 +84,4 @@ private:\n \n } /* namespace libcamera */\n \n-#endif /* __LIBCAMERA_EXTENSIBLE_H__ */\n+#endif /* __LIBCAMERA_CLASS_H__ */\ndiff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\nindex 13e9eeb6d6ad..aefc60d8c9b4 100644\n--- a/include/libcamera/meson.build\n+++ b/include/libcamera/meson.build\n@@ -7,7 +7,6 @@ libcamera_public_headers = files([\n 'camera_manager.h',\n 'compiler.h',\n 'controls.h',\n- 'extensible.h',\n 'file_descriptor.h',\n 'framebuffer_allocator.h',\n 'geometry.h',\ndiff --git a/src/libcamera/extensible.cpp b/src/libcamera/class.cpp\nsimilarity index 94%\nrename from src/libcamera/extensible.cpp\nrename to src/libcamera/class.cpp\nindex 1dcb0bf1b12f..8a608edb369b 100644\n--- a/src/libcamera/extensible.cpp\n+++ b/src/libcamera/class.cpp\n@@ -2,14 +2,17 @@\n /*\n * Copyright (C) 2020, Google Inc.\n *\n- * extensible.cpp - Utilities to create extensible public classes with stable ABIs\n+ * class.cpp - Utilities and helpers for public classes\n */\n \n-#include \n+#include \n \n /**\n- * \\file extensible.h\n- * \\brief Utilities to create extensible public classes with stable ABIs\n+ * \\file class.h\n+ * \\brief Utilities to help constructing public class interfaces\n+ *\n+ * The extensible class can be inheritted to create public classes with stable\n+ * ABIs.\n */\n \n namespace libcamera {\ndiff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex 5a4bf0d7ba4f..552893a29dc0 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -9,6 +9,7 @@ libcamera_sources = files([\n 'camera_controls.cpp',\n 'camera_manager.cpp',\n 'camera_sensor.cpp',\n+ 'class.cpp',\n 'controls.cpp',\n 'control_serializer.cpp',\n 'control_validator.cpp',\n@@ -18,7 +19,6 @@ libcamera_sources = files([\n 'event_dispatcher.cpp',\n 'event_dispatcher_poll.cpp',\n 'event_notifier.cpp',\n- 'extensible.cpp',\n 'file.cpp',\n 'file_descriptor.cpp',\n 'formats.cpp',\n","prefixes":["libcamera-devel","v2","1/6"]}