[{"id":15091,"web_url":"https://patchwork.libcamera.org/comment/15091/","msgid":"","date":"2021-02-11T13:50:37","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: properties: Add\n\tUnknown value to camera Location","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Paul,\n\nOn 11/02/2021 08:55, Paul Elder wrote:\n> If a camera's location is unknown, it should be set so, and not\n> defaulted to another location. Add such a value to the Location property\n> enum.\n> \n> Signed-off-by: Paul Elder \n> ---\n> src/libcamera/property_ids.yaml | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> index 104e9aaf..66deaa84 100644\n> --- a/src/libcamera/property_ids.yaml\n> +++ b/src/libcamera/property_ids.yaml\n> @@ -25,6 +25,10 @@ controls:\n> description: |\n> The camera is attached to the device in a way that allows it to\n> be moved freely\n> + - name: CameraLocationUnknown\n> + value: 3\n\nWould it make sense to set the Unknown value as 0 (and put it first in\nthe list?).\n\nOf course that would mean adjusting the other valuees in this enum too,\nbut while we do not have a stable ABI, I don't see that as being a problem.\n\nThat would mean that if this property were read as uninitialised (or\ndefaulted?) it would be read as 'unknown' rather than 'Front' ?\n\nIt probably doesn't matter and doesn't make a difference as if it's set,\nit would be expected to be set correctly though.\n\nWhichever you decide:\n\nReviewed-by: Kieran Bingham \n\n\n> + description: |\n> + The camera location is unknown\n> \n> - Rotation:\n> type: int32_t\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DB25BBD160\n\tfor ;\n\tThu, 11 Feb 2021 13:50:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 68AE7616A1;\n\tThu, 11 Feb 2021 14:50:41 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0FEF2601B5\n\tfor ;\n\tThu, 11 Feb 2021 14:50:40 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 72F4541;\n\tThu, 11 Feb 2021 14:50:39 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QqztHNEs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613051439;\n\tbh=HdXlzh51uiNkuszAjTVsMZPJxFUJCiVoCs72e5pCtXM=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=QqztHNEsaQ1bKfGoYVrRCUggMcaicTjbpxDL5Q/ax99EWzaRIGlDATLBHfkAbFmbc\n\tdcFA7/JyHmQnisFipiC3ZpsiEDBBqzAL6Xupz1Nz33MNmjrNxFawqF2oo4+4pzOTjt\n\tBD/2w1AWggIBqNFWIhvBtjtltJPdApZ07SOZvWFw=","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210211085527.44667-1-paul.elder@ideasonboard.com>\n\t<20210211085527.44667-2-paul.elder@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Thu, 11 Feb 2021 13:50:37 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210211085527.44667-2-paul.elder@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: properties: Add\n\tUnknown value to camera Location","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15108,"web_url":"https://patchwork.libcamera.org/comment/15108/","msgid":"","date":"2021-02-11T21:41:25","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: properties: Add\n\tUnknown value to camera Location","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Thu, Feb 11, 2021 at 01:50:37PM +0000, Kieran Bingham wrote:\n> On 11/02/2021 08:55, Paul Elder wrote:\n> > If a camera's location is unknown, it should be set so, and not\n> > defaulted to another location. Add such a value to the Location property\n> > enum.\n> > \n> > Signed-off-by: Paul Elder \n> > ---\n> > src/libcamera/property_ids.yaml | 4 ++++\n> > 1 file changed, 4 insertions(+)\n> > \n> > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> > index 104e9aaf..66deaa84 100644\n> > --- a/src/libcamera/property_ids.yaml\n> > +++ b/src/libcamera/property_ids.yaml\n> > @@ -25,6 +25,10 @@ controls:\n> > description: |\n> > The camera is attached to the device in a way that allows it to\n> > be moved freely\n> > + - name: CameraLocationUnknown\n> > + value: 3\n> \n> Would it make sense to set the Unknown value as 0 (and put it first in\n> the list?).\n> \n> Of course that would mean adjusting the other valuees in this enum too,\n> but while we do not have a stable ABI, I don't see that as being a problem.\n> \n> That would mean that if this property were read as uninitialised (or\n> defaulted?) it would be read as 'unknown' rather than 'Front' ?\n> \n> It probably doesn't matter and doesn't make a difference as if it's set,\n> it would be expected to be set correctly though.\n\nI think it's a good idea.\n\nReviewed-by: Laurent Pinchart \n\n> Whichever you decide:\n> \n> Reviewed-by: Kieran Bingham \n> \n> \n> > + description: |\n> > + The camera location is unknown\n> > \n> > - Rotation:\n> > type: int32_t\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BB3B7BD162\n\tfor ;\n\tThu, 11 Feb 2021 21:41:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 266326374C;\n\tThu, 11 Feb 2021 22:41:52 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BBA58601B5\n\tfor ;\n\tThu, 11 Feb 2021 22:41:50 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2A39D41;\n\tThu, 11 Feb 2021 22:41:50 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lpsL2kZW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613079710;\n\tbh=VXAnAI46rf8bNdxFY6dQ/SRXDMgzc4FCWqqKqYfv9Eg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lpsL2kZWmUM0qm8v1yskA5w0dh7GK80FbChOAdCPX2I6GgjFvNjHd4RqPz3V9vFVl\n\tkRq+AcQcpJWAsG5LJe9it7yP8ODXb9qM1Hal00b+yvi2TxQGSxk7K/Z9Tt9MHRSXUM\n\tV9ogZlJgS4RbvbftcaIP8mu+f2mY32mvrty2DLBc=","Date":"Thu, 11 Feb 2021 23:41:25 +0200","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"","References":"<20210211085527.44667-1-paul.elder@ideasonboard.com>\n\t<20210211085527.44667-2-paul.elder@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: properties: Add\n\tUnknown value to camera Location","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15124,"web_url":"https://patchwork.libcamera.org/comment/15124/","msgid":"<20210212045502.GB45982@pyrite.rasen.tech>","date":"2021-02-12T04:55:02","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: properties: Add\n\tUnknown value to camera Location","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Thu, Feb 11, 2021 at 01:50:37PM +0000, Kieran Bingham wrote:\n> Hi Paul,\n> \n> On 11/02/2021 08:55, Paul Elder wrote:\n> > If a camera's location is unknown, it should be set so, and not\n> > defaulted to another location. Add such a value to the Location property\n> > enum.\n> > \n> > Signed-off-by: Paul Elder \n> > ---\n> > src/libcamera/property_ids.yaml | 4 ++++\n> > 1 file changed, 4 insertions(+)\n> > \n> > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> > index 104e9aaf..66deaa84 100644\n> > --- a/src/libcamera/property_ids.yaml\n> > +++ b/src/libcamera/property_ids.yaml\n> > @@ -25,6 +25,10 @@ controls:\n> > description: |\n> > The camera is attached to the device in a way that allows it to\n> > be moved freely\n> > + - name: CameraLocationUnknown\n> > + value: 3\n> \n> Would it make sense to set the Unknown value as 0 (and put it first in\n> the list?).\n> \n> Of course that would mean adjusting the other valuees in this enum too,\n> but while we do not have a stable ABI, I don't see that as being a problem.\n\nThat's what I was concerned about, but I guess if it's not a concern\nthen I'll reorder them.\n\n\nThanks,\n\nPaul\n\n> That would mean that if this property were read as uninitialised (or\n> defaulted?) it would be read as 'unknown' rather than 'Front' ?\n> \n> It probably doesn't matter and doesn't make a difference as if it's set,\n> it would be expected to be set correctly though.\n> \n> Whichever you decide:\n> \n> Reviewed-by: Kieran Bingham \n> \n> \n> > + description: |\n> > + The camera location is unknown\n> > \n> > - Rotation:\n> > type: int32_t\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 46EAABD160\n\tfor ;\n\tFri, 12 Feb 2021 04:55:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B7E356375D;\n\tFri, 12 Feb 2021 05:55:10 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 593BB63758\n\tfor ;\n\tFri, 12 Feb 2021 05:55:09 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CC5568B5;\n\tFri, 12 Feb 2021 05:55:07 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Shgbk6vt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613105708;\n\tbh=1Ef2p8bD9gYAzMsGJZcSgvB+EguJ4uUBG+hpVaVHqJE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Shgbk6vtncbrtxqUeMlovyCHMOYFuyPvj/MawanaP+9S6bjPso6iPUGz1aiykLndo\n\t5hSrSkBG/gOD7NIJDOl/6q38shk6k+H+j3NHWFLgEwh9+F1DR1Na5nuWegVnHiIj4h\n\tEhsN33AM8S10nRRiz2ZYbeD0hhSRHqz5gtFHkCf8=","Date":"Fri, 12 Feb 2021 13:55:02 +0900","From":"paul.elder@ideasonboard.com","To":"Kieran Bingham ","Message-ID":"<20210212045502.GB45982@pyrite.rasen.tech>","References":"<20210211085527.44667-1-paul.elder@ideasonboard.com>\n\t<20210211085527.44667-2-paul.elder@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: properties: Add\n\tUnknown value to camera Location","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]